OCA\Contacts\Search\Provider

Complexity

Total Complexity

2

Size/Duplication

Total Lines	17
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

0%

1 Method

Rating	Name	Duplication	Size	Complexity
A	search()	0	8	2

<?php

/**
 * ownCloud
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
 * License as published by the Free Software Foundation; either
 * version 3 of the License, or any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU AFFERO GENERAL PUBLIC LICENSE for more details.
 *
 * You should have received a copy of the GNU Affero General Public
 * License along with this library.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OCA\Contacts\Search;

/**
 * The updated contacts search provider
 */
class Provider extends \OCP\Search\Provider {

	/**
	 * Search for contacts
	 *
	 * @param string $query
	 * @return array list of \OCA\Calendar\Search\Contact
	 */
	function search($query) {

It is generally recommended to explicitly declare the visibility for methods.

The variable $_results is not named in camelCase.

The variable $_result is not named in camelCase.

It is recommend to declare an explicit visibility for search.

		$_results = \OCP\Contacts::search($query, array('N', 'FN', 'EMAIL', 'NICKNAME', 'ORG'));
		$results = array();
		foreach ($_results as $_result) {
			$results[] = new \OCA\Contacts\Search\Contact($_result);
		}
		return $results;
	}
}