OCA\Contacts\Backend\BackendTest

Complexity

Total Complexity

21

Size/Duplication

Total Lines	190
Duplicated Lines	11.05 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	2
Bugs	1	Features	1

19 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	4	1
A	tearDown()	0	4	1
A	testHasContactMethodFor()	0	7	2
A	testHasAddressBookMethodFor()	0	7	2
A	testgetAddressBooksForUser()	0	5	1
A	testDeleteAddressBook()	0	6	1
A	testCreateAddressBook()	0	13	1
A	testCreateAddressBookFail()	0	8	1
A	testUpdateAddressBook()	11	11	1
A	testUpdateAddressBookFail()	0	7	1
A	testGetAddressBook()	0	6	1
A	testGetAddressBookFail()	0	5	1
A	testGetLastModifiedAddressBook()	0	5	1
A	testGetContact()	0	9	1
A	testGetContactFail()	0	5	1
A	testCreateContact()	10	10	1
A	testGetContacts()	0	10	1
A	testUpdateContact()	0	14	1
A	testDeleteContact()	0	6	1

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 16 and the first side effect is on line 14.

/**
 * Copyright (c) 2013 Thomas Tanghus (thomas@tanghus.net)
 * This file is licensed under the Affero General Public License version 3 or
 * later.
 * See the COPYING-README file.
 */

namespace OCA\Contacts\Backend;

use Sabre\VObject\Reader;
use Test\TestCase;

require_once __DIR__ .'/mock.php';

class BackendTest extends TestCase {

	/**
	* @var array
	*/
	protected $abinfo;

	/**
	* @var array
	*/
	protected $permissions = array(
		\OCP\PERMISSION_READ,
		\OCP\PERMISSION_CREATE,
		\OCP\PERMISSION_UPDATE,
		\OCP\PERMISSION_DELETE
	);

	/**
	* @var \OCA\Contacts\Backend\AbstractBackend
	*/
	protected $backend;

	public function setUp() {
		parent::setUp();
		$this->backend = new Mock('foobar');
	}

	public function tearDown() {
		unset($this->backend);
		parent::tearDown();
	}

	public function testHasContactMethodFor() {

		foreach($this->permissions as $permission) {
			$this->assertTrue($this->backend->hasContactMethodFor($permission));
		}

	}

	public function testHasAddressBookMethodFor() {

		foreach($this->permissions as $permission) {
			$this->assertTrue($this->backend->hasAddressBookMethodFor($permission));
		}

	}

	public function testgetAddressBooksForUser() {

		$this->assertEquals(1, count($this->backend->getAddressBooksForUser()));

	}

	public function testDeleteAddressBook() {

		$this->assertTrue($this->backend->deleteAddressBook('foo'));
		$this->assertEquals(array(), $this->backend->addressBooks);

The property addressBooks does not seem to exist in OCA\Contacts\Backend\AbstractBackend.

	}

	public function testCreateAddressBook() {

		$id = $this->backend->createAddressBook(array('displayname' => 'bar'));

		$this->assertNotEquals(false, $id);

		$this->assertEquals(2, count($this->backend->getAddressBooksForUser()));

		$book = $this->backend->getAddressBook($id);

		$this->assertEquals('bar', $book['displayname']);

	}

	public function testCreateAddressBookFail() {

		// displayname must be provided.
		$id = $this->backend->createAddressBook(array('description' => 'foo bar'));

		$this->assertFalse($id);

	}

	public function testUpdateAddressBook() {

This method seems to be duplicated in your project.

		$this->assertTrue(
			$this->backend->updateAddressBook('foo', array('displayname' => 'bar'))
		);

		$this->assertEquals('bar', $this->backend->addressBooks[0]['displayname']);

The property addressBooks does not seem to exist in OCA\Contacts\Backend\AbstractBackend.

		return $this->backend;

	}

	public function testUpdateAddressBookFail() {

		$this->assertFalse(
			$this->backend->updateAddressBook('foo', array('description' => 'foo bar'))
		);

	}

	/**
	* @depends testUpdateAddressBook
	*/
	public function testGetAddressBook($backend) {

		$book = $backend->getAddressBook('foo');
		$this->assertEquals('bar', $book['displayname']);

	}

	public function testGetAddressBookFail() {

		$this->assertNull($this->backend->getAddressBook('bar'));

	}

	public function testGetLastModifiedAddressBook() {

		$this->assertNull($this->backend->lastModifiedAddressBook('foo'));

	}

	public function testGetContact() {

		$contact = $this->backend->getContact('foo', '123');
		$this->assertTrue(is_array($contact));
		$this->assertEquals('Max Mustermann', $contact['displayname']);
		$this->assertEquals('foobar', $contact['owner']);
		$this->assertEquals(\OCP\PERMISSION_ALL, $contact['permissions']);

	}

	public function testGetContactFail() {

		$this->assertNull($this->backend->getContact('foo', '1234'));

	}

	public function testCreateContact() {

This method seems to be duplicated in your project.

		$carddata = file_get_contents(__DIR__ . '/../../data/test2.vcf');
		$vcard = Reader::read($carddata);
		$id = $this->backend->createContact('foo', $vcard);

		$this->assertNotEquals(false, $id);

		return $this->backend;
	}

	/**
	* @depends testCreateContact
	*/
	public function testGetContacts($backend) {

		$contacts = $backend->getContacts('foo');

		$this->assertCount(2, $contacts);

		$this->assertEquals('Max Mustermann', $contacts[0]['displayname']);
		$this->assertEquals('John Q. Public', $contacts[1]['displayname']);

	}

	public function testUpdateContact() {

		$carddata = file_get_contents(__DIR__ . '/../../data/test2.vcf');
		$vcard = Reader::read($carddata);

		$this->assertInstanceOf('OCA\\Contacts\\VObject\\VCard', $vcard);

		$this->assertTrue($this->backend->updateContact('foo', '123', $vcard));

		$contact = $this->backend->getContact('foo', '123');

		$this->assertEquals('John Q. Public', $contact['displayname']);

	}

	public function testDeleteContact() {

		$this->assertTrue($this->backend->deleteContact('foo', '123'));
		$this->assertEquals(array(), $this->backend->getContacts('foo'));

	}

}