Issues in removefile.php (master) - Issues in master - owncloud/chat - Measure and Improve Code Quality continuously with Scrutinizer

Issues (158)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/och/commands/removefile.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Copyright (c) 2014, Tobia De Koninck hey--at--ledfan.be
 * This file is licensed under the AGPL version 3 or later.
 * See the COPYING file.
 */

namespace OCA\Chat\OCH\Commands;

use \OCA\Chat\OCH\ChatAPI;
use \OCA\Chat\OCH\Db\Attachment;
use OCA\Chat\OCH\Db\AttachmentMapper;
use \OCA\Chat\OCH\Db\PushMessage;
use \OCA\Chat\OCH\Exceptions\RequestDataInvalid;
use \OCA\Chat\Controller\OCH\ApiController;

class RemoveFile extends ChatAPI {

    /**
     * @var $pushMessageMapper \OCA\Chat\OCH\Db\PushMessageMapper
     */
    private $pushMessageMapper;

    /**
     * @var $attachmentMapper \OCA\Chat\OCH\Db\AttachmentMapper
     */
    private $attachmentMapper;

    /**
     * @var $userMapper \OCA\Chat\OCH\Db\UserMapper
     */
    private $userMapper;

    public function __construct(
        Chat $app,
        PushMessageMapper $pushMessageMapper,
        AttachmentMapper $attachmentMapper,
        UserMapper $userMapper
    ){
        $this->app = $app;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->pushMessageMapper = $pushMessageMapper;
        $this->attachmentMapper = $attachmentMapper;
        $this->userMapper = $userMapper;
    }



	/*
	 * @param $requestData['user'] String user id of the client
	 * @param $requestData['session_id'] String session_id of the client
	 * @param $requestData['timestamp'] Int timestamp when the command was send
	*/
	public function setRequestData(array $requestData){
		$this->requestData = $requestData;
        $attachment = $this->attachmentMapper->findByPathAndConvId($this->requestData['path'], $this->requestData['conv_id']);
        if ($attachment->getOwner() !== $this->app->getUserId()){
            throw new RequestDataInvalid(ApiController::NOT_OWNER_OF_FILE);
        }
    }

	public function execute(){

		$fileId = $this->app->getFileId($this->requestData['path']);
		$file = new Attachment();
		$file->setConvId($this->requestData['conv_id']);
		$file->setFileId($fileId);
		$this->attachmentMapper->deleteByConvAndFileID($file);
        $this->sendPushMessage($this->requestData['path']);
		$users = $this->userMapper->findUsersInConv($this->requestData['conv_id']);
		foreach ($users as $user) {
			if ($user !== $this->app->getUserId()) {
				$this->unShare($fileId, $user);
			}
		}
	}

	/**
	 * @param $fileId the fileId of the file
	 * @param $shareWIth the ownCloud user to share the file with
	 */
	private function unShare($fileId, $shareWIth){
		try {
			\OCP\Share::unshare('file', $fileId, \OCP\Share::SHARE_TYPE_USER, $shareWIth);
		} Catch (\Exception $e){


		}
	}

    private function sendPushMessage($path){
        $users = $this->userMapper->findSessionsByConversation($this->requestData['conv_id']);
        $command = json_encode(array(
            'type' => 'file_removed',
            'data' => array(
                'user' => $this->requestData['user'],
                'conv_id' => $this->requestData['conv_id'],
                'timestamp' => $this->requestData['timestamp'],
                'path' => $path
            )
        ));
        foreach($users as $receiver) {
            if($receiver->getUser() !== $this->requestData['user']['id']) {
                $pushMessage = new PushMessage();
                $pushMessage->setSender($this->requestData['user']['id']);
                $pushMessage->setReceiver($receiver->getUser());
                $pushMessage->setReceiverSessionId($receiver->getSessionId());
                $pushMessage->setCommand($command);
                $this->pushMessageMapper->insert($pushMessage);
            }
        }
    }


}


1			<?php
2			/**
3			* Copyright (c) 2014, Tobia De Koninck hey--at--ledfan.be
4			* This file is licensed under the AGPL version 3 or later.
5			* See the COPYING file.
6			*/
7
8			namespace OCA\Chat\OCH\Commands;
9
10			use \OCA\Chat\OCH\ChatAPI;
11			use \OCA\Chat\OCH\Db\Attachment;
12			use OCA\Chat\OCH\Db\AttachmentMapper;
13			use \OCA\Chat\OCH\Db\PushMessage;
14			use \OCA\Chat\OCH\Exceptions\RequestDataInvalid;
15			use \OCA\Chat\Controller\OCH\ApiController;
16
17			class RemoveFile extends ChatAPI {
18
19			/**
20			* @var $pushMessageMapper \OCA\Chat\OCH\Db\PushMessageMapper
21			*/
22			private $pushMessageMapper;
23
24			/**
25			* @var $attachmentMapper \OCA\Chat\OCH\Db\AttachmentMapper
26			*/
27			private $attachmentMapper;
28
29			/**
30			* @var $userMapper \OCA\Chat\OCH\Db\UserMapper
31			*/
32			private $userMapper;
33
34			public function __construct(
35			Chat $app,
36			PushMessageMapper $pushMessageMapper,
37			AttachmentMapper $attachmentMapper,
38			UserMapper $userMapper
39			){
40			$this->app = $app;
			0 ignored issues – show Bug introduced 2015-12-29 06:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `app` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
41			$this->pushMessageMapper = $pushMessageMapper;
42			$this->attachmentMapper = $attachmentMapper;
43			$this->userMapper = $userMapper;
44			}
45
46
47
48			/*
49			* @param $requestData['user'] String user id of the client
50			* @param $requestData['session_id'] String session_id of the client
51			* @param $requestData['timestamp'] Int timestamp when the command was send
52			*/
53			public function setRequestData(array $requestData){
54			$this->requestData = $requestData;
55			$attachment = $this->attachmentMapper->findByPathAndConvId($this->requestData['path'], $this->requestData['conv_id']);
56			if ($attachment->getOwner() !== $this->app->getUserId()){
57			throw new RequestDataInvalid(ApiController::NOT_OWNER_OF_FILE);
58			}
59			}
60
61			public function execute(){
62
63			$fileId = $this->app->getFileId($this->requestData['path']);
64			$file = new Attachment();
65			$file->setConvId($this->requestData['conv_id']);
66			$file->setFileId($fileId);
67			$this->attachmentMapper->deleteByConvAndFileID($file);
68			$this->sendPushMessage($this->requestData['path']);
69			$users = $this->userMapper->findUsersInConv($this->requestData['conv_id']);
70			foreach ($users as $user) {
71			if ($user !== $this->app->getUserId()) {
72			$this->unShare($fileId, $user);
73			}
74			}
75			}
76
77			/**
78			* @param $fileId the fileId of the file
79			* @param $shareWIth the ownCloud user to share the file with
80			*/
81			private function unShare($fileId, $shareWIth){
82			try {
83			\OCP\Share::unshare('file', $fileId, \OCP\Share::SHARE_TYPE_USER, $shareWIth);
84			} Catch (\Exception $e){
			0 ignored issues – show Coding Style Comprehensibility introduced 2015-12-29 06:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider adding a comment why this CATCH block is empty. Loading history...
85
86			}
87			}
88
89			private function sendPushMessage($path){
90			$users = $this->userMapper->findSessionsByConversation($this->requestData['conv_id']);
91			$command = json_encode(array(
92			'type' => 'file_removed',
93			'data' => array(
94			'user' => $this->requestData['user'],
95			'conv_id' => $this->requestData['conv_id'],
96			'timestamp' => $this->requestData['timestamp'],
97			'path' => $path
98			)
99			));
100			foreach($users as $receiver) {
101			if($receiver->getUser() !== $this->requestData['user']['id']) {
102			$pushMessage = new PushMessage();
103			$pushMessage->setSender($this->requestData['user']['id']);
104			$pushMessage->setReceiver($receiver->getUser());
105			$pushMessage->setReceiverSessionId($receiver->getSessionId());
106			$pushMessage->setCommand($command);
107			$this->pushMessageMapper->insert($pushMessage);
108			}
109			}
110			}
111
112
113			}
114

owncloud / chat

Issues (158)

Security Analysis no request data

lib/och/commands/removefile.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like