Issues in avatar.js (master) - Issues in master - owncloud/chat - Measure and Improve Code Quality continuously with Scrutinizer

Issues (158)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

js/src/app/directives/avatar.js (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

angular.module('chat').directive('avatar', ['contacts', function(contacts) {
	return {
		restrict: 'A',
		link: function ($scope, element, attrs) {
			applyContactAvatar(element, attrs.addressbookBackend, attrs.addressbookId, attrs.id, attrs.displayname, attrs.size);
			if(attrs.online !== undefined){
				element.online(attrs.isonline);
				$scope.$watch('contacts', function(){
					element.online(contacts.contacts[attrs.id].online);
				}, true);
			}
		}
	};

	function applyContactAvatar(element, addressbookBackend, addressBookId, id, displayname, size){
		var cacheTime = Cache.day(1);
		element.height(size);
		element.width(size);

		// First generate an id of this contact which is used in the cache
		var cacheId = id;
		// Next check if the cacheId occurs in the cache
		var value = Cache.get(cacheId)

		if (value !== undefined) {
			if (value.noAvatar == true) {

				element.imageplaceholder(displayname);
			} else {
				applyAvatar(value.base64 + "?requesttoken=" + oc_requesttoken, size);
			}
		} else {
			// check if the contact is an ownCloud user or a contact
			if (addressbookBackend === 'local' && addressBookId === "-1") {
				// This is a NOT saved contact
				element.imageplaceholder(displayname);
			}
			else if (addressbookBackend === 'local' && addressBookId === "") {
				// ownCloud user
				var url = OC.generateUrl(
					'/avatar/{user}/{size}?requesttoken={requesttoken}',
					{
						user: id,
						size: size * window.devicePixelRatio,
						requesttoken: oc_requesttoken
					});
				var urlWithoutRT = OC.generateUrl(
					'/avatar/{user}/{size}',
					{user: id, size: size * window.devicePixelRatio});
				$.get(url, function (result) {
					if (typeof(result) === 'object') {
						Cache.set(cacheId, {"noAvatar": true}, cacheTime);
						element.imageplaceholder(displayname);
					} else {
						Cache.set(cacheId, {
							"noAvatar": false,
							"base64": urlWithoutRT
						}, cacheTime);
						applyAvatar(url, size);
					}
				});
			} else {
				var url = OC.generateUrl('/apps/contacts/addressbook/{backend}/{addressbook_id}/contact/{contact_id}/photo?requesttoken={requesttoken}',

					{
						backend: addressbookBackend,
						contact_id: id,
						addressbook_id: addressBookId,
						requesttoken: oc_requesttoken
					});
				var urlWithoutRT = OC.generateUrl('/apps/contacts/addressbook/{backend}/{addressbook_id}/contact/{contact_id}/photo',

					{
						backend: addressbookBackend,
						contact_id: id,
						addressbook_id: addressBookId
					});
				$.get(url, function (result) {
					if (typeof(result) === 'object') {
						Cache.set(cacheId, {"noAvatar": true}, cacheTime);
						element.imageplaceholder(displayname);
					} else {
						Cache.set(cacheId, {
							"noAvatar": false,
							"base64": url
						}, cacheTime);
						applyAvatar(url, size);
					}
				});
			}

		}
	}
	function applyAvatar(url, size){
		element.show();
		element.html('<img width="' + size + '" height="' + size + '" src="'+ url +'">');
	}
}]);

1			angular.module('chat').directive('avatar', ['contacts', function(contacts) {
2			return {
3			restrict: 'A',
4			link: function ($scope, element, attrs) {
5			applyContactAvatar(element, attrs.addressbookBackend, attrs.addressbookId, attrs.id, attrs.displayname, attrs.size);
6			if(attrs.online !== undefined){
7			element.online(attrs.isonline);
8			$scope.$watch('contacts', function(){
9			element.online(contacts.contacts[attrs.id].online);
10			}, true);
11			}
12			}
13			};
14
15			function applyContactAvatar(element, addressbookBackend, addressBookId, id, displayname, size){
16			var cacheTime = Cache.day(1);
17			element.height(size);
18			element.width(size);
19
20			// First generate an id of this contact which is used in the cache
21			var cacheId = id;
22			// Next check if the cacheId occurs in the cache
23			var value = Cache.get(cacheId)
			0 ignored issues – show Coding Style introduced 2015-12-29 06:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this There should be a semicolon. Requirement of semicolons purely is a coding style issue since JavaScript has specific rules about semicolons which are followed by all browsers. Further Readings: An Open Letter to JavaScript Leaders Regarding Semicolons by Isaac Schlueter JavaScript Semicolon Insertion Loading history...
24			if (value !== undefined) {
25			if (value.noAvatar == true) {
			0 ignored issues – show Coding Style introduced 2015-12-29 06:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is recommended to use `===` to compare with `true`. Generally, it is recommended to use strict comparison whenever possible and not to rely on the weaker type-juggling comparison operator. Read more about comparison operations. Loading history...
26			element.imageplaceholder(displayname);
27			} else {
28			applyAvatar(value.base64 + "?requesttoken=" + oc_requesttoken, size);
29			}
30			} else {
31			// check if the contact is an ownCloud user or a contact
32			if (addressbookBackend === 'local' && addressBookId === "-1") {
33			// This is a NOT saved contact
34			element.imageplaceholder(displayname);
35			}
36			else if (addressbookBackend === 'local' && addressBookId === "") {
37			// ownCloud user
38			var url = OC.generateUrl(
39			'/avatar/{user}/{size}?requesttoken={requesttoken}',
40			{
41			user: id,
42			size: size * window.devicePixelRatio,
43			requesttoken: oc_requesttoken
44			});
45			var urlWithoutRT = OC.generateUrl(
46			'/avatar/{user}/{size}',
47			{user: id, size: size * window.devicePixelRatio});
48			$.get(url, function (result) {
49			if (typeof(result) === 'object') {
50			Cache.set(cacheId, {"noAvatar": true}, cacheTime);
51			element.imageplaceholder(displayname);
52			} else {
53			Cache.set(cacheId, {
54			"noAvatar": false,
55			"base64": urlWithoutRT
56			}, cacheTime);
57			applyAvatar(url, size);
58			}
59			});
60			} else {
61			var url = OC.generateUrl('/apps/contacts/addressbook/{backend}/{addressbook_id}/contact/{contact_id}/photo?requesttoken={requesttoken}',
			0 ignored issues – show Bug introduced 2015-12-29 06:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `url` was already defined. Loading history...
62			{
63			backend: addressbookBackend,
64			contact_id: id,
65			addressbook_id: addressBookId,
66			requesttoken: oc_requesttoken
67			});
68			var urlWithoutRT = OC.generateUrl('/apps/contacts/addressbook/{backend}/{addressbook_id}/contact/{contact_id}/photo',
			0 ignored issues – show Bug introduced 2015-12-29 06:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `urlWithoutRT` was already defined. Loading history...
69			{
70			backend: addressbookBackend,
71			contact_id: id,
72			addressbook_id: addressBookId
73			});
74			$.get(url, function (result) {
75			if (typeof(result) === 'object') {
76			Cache.set(cacheId, {"noAvatar": true}, cacheTime);
77			element.imageplaceholder(displayname);
78			} else {
79			Cache.set(cacheId, {
80			"noAvatar": false,
81			"base64": url
82			}, cacheTime);
83			applyAvatar(url, size);
84			}
85			});
86			}
87
88			}
89			}
90			function applyAvatar(url, size){
91			element.show();
92			element.html('<img width="' + size + '" height="' + size + '" src="'+ url +'">');
93			}
94			}]);

owncloud / chat

Issues (158)

Security Analysis no request data

js/src/app/directives/avatar.js (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like