owncloud /
chat
| Conditions | 15 |
| Paths | 51 |
| Total Lines | 70 |
| Code Lines | 56 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 55 | public function route($type, $data){ |
||
| 56 | session_write_close(); |
||
| 57 | list($requestType, $action, $httpType) = explode("::", $type); |
||
| 58 | |||
| 59 | if($httpType === "request"){ |
||
| 60 | if(!empty($data['session_id'])){ |
||
| 61 | if(!empty($data['user'])){ |
||
| 62 | if($data['user']['id'] === $this->app->getUserId()){ |
||
| 63 | try{ |
||
| 64 | switch($requestType){ |
||
| 65 | case "command": |
||
| 66 | $possibleCommands = array('greet', 'join', 'invite', 'send_chat_msg', 'online', 'offline', 'start_conv', 'delete_init_conv', 'attach_file', 'remove_file'); |
||
| 67 | if(in_array($action, $possibleCommands)){ |
||
| 68 | $commandClass = $this->container->query($this->convertClassName($action) . 'Command'); |
||
| 69 | $commandClass->setRequestData($data); |
||
| 70 | $data = $commandClass->execute(); |
||
| 71 | if($data){ |
||
| 72 | return new Success("command", $action, $data); |
||
| 73 | } else { |
||
| 74 | return new Success("command", $action); |
||
| 75 | } |
||
| 76 | } else { |
||
| 77 | return new Error("command", $action, self::COMMAND_NOT_FOUND); |
||
| 78 | } |
||
| 79 | break; |
||
|
|
|||
| 80 | case "push": |
||
| 81 | $possibleCommands = array('get', 'delete'); |
||
| 82 | if(in_array($action, $possibleCommands)){ |
||
| 83 | $pushClass = $this->container->query($this->convertClassName($action) . 'Push'); |
||
| 84 | $pushClass->setRequestData($data); |
||
| 85 | return $pushClass->execute(); |
||
| 86 | } else { |
||
| 87 | return new Error("push", $action, self::PUSH_ACTION_NOT_FOUND); |
||
| 88 | } |
||
| 89 | break; |
||
| 90 | case "data": |
||
| 91 | $possibleCommands = array('messages', 'get_users'); |
||
| 92 | if(in_array($action, $possibleCommands)){ |
||
| 93 | $dataClass = $this->container->query($this->convertClassName($action) . 'Data'); |
||
| 94 | $dataClass->setRequestData($data); |
||
| 95 | $data = $dataClass->execute(); |
||
| 96 | if($data){ |
||
| 97 | return new Success("data", $action, $data); |
||
| 98 | } else { |
||
| 99 | return new Success("data", $action); |
||
| 100 | } |
||
| 101 | } else { |
||
| 102 | return new Error("data", $action, self::DATA_ACTION_NOT_FOUND); |
||
| 103 | } |
||
| 104 | break; |
||
| 105 | } |
||
| 106 | }catch(DBException $e){ |
||
| 107 | return new Error($requestType, $action, "ERROR::DB::" . $e->getMessage()); |
||
| 108 | } |
||
| 109 | catch(RequestDataInvalid $e){ |
||
| 110 | return new Error($requestType, $action, $e->getMessage()); |
||
| 111 | } |
||
| 112 | } else { |
||
| 113 | return new Error($requestType, $action, self::USER_NOT_EQUAL_TO_OC_USER); |
||
| 114 | } |
||
| 115 | } else { |
||
| 116 | return new Error($requestType, $action, self::NO_USER); |
||
| 117 | } |
||
| 118 | } else { |
||
| 119 | return new Error($requestType, $action, self::NO_SESSION_ID); |
||
| 120 | } |
||
| 121 | } else { |
||
| 122 | return new Error($requestType, $action, self::INVALID_HTTP_TYPE); |
||
| 123 | } |
||
| 124 | } |
||
| 125 | |||
| 140 |
Loading history...
This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed.
Unreachable code is most often the result of
return,dieorexitstatements that have been added for debug purposes.In the above example, the last
return falsewill never be executed, because a return statement has already been met in every possible execution path.