viewcontrollerTest.php ➔ file_get_contents() - Code Metrics - Inspection of "[tx-robot] updated from transifex" - owncloud/calendar - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — new-loading-classe ( ae9924 )

unknown

created 2016-05-10 03:47 UTC

viewcontrollerTest.php ➔ file_get_contents() A

↳ Parent: Project

Complexity

Conditions	4
Paths	4

Size

Total Lines	18
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Metric	Value
cc	4
eloc	13
nc	4
nop	1
dl	0
loc	18
rs	9.2

<?php
/**
 * ownCloud - Calendar App
 *
 * @author Georg Ehrke
 * @copyright 2016 Georg Ehrke <[email protected]>
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
 * License as published by the Free Software Foundation; either
 * version 3 of the License, or any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU AFFERO GENERAL PUBLIC LICENSE for more details.
 *
 * You should have received a copy of the GNU Affero General Public
 * License along with this library.  If not, see <http://www.gnu.org/licenses/>.
 *
 */
namespace OCA\Calendar\Controller;

function scandir($directory) {
	$dir = substr(__DIR__, 0, -strlen('tests/unit/controller')) . 'controller/../timezones/';
	return $dir === $directory ? [
		'..',
		'.',
		'TIMEZONE1.ics',
		'TIMEZONE2.ics',
		'REG-CIT.ics',
		'INFO.md',
	] : [];
}

function file_get_contents($file) {
	$file_parts = explode('/', $file);
	end($file_parts);
	$file = current($file_parts);
	switch($file) {
		case 'TIMEZONE1.ics':
			return 'TIMEZONE1-data';

		case 'TIMEZONE2.ics':
			return 'ANOTHER TIMEZONE DATA';

		case 'REG-CIT.ics':
			return 'TIMEZONE DATA WITH REGION AND CITY';

		default:
			return null;
	}
}

class ViewControllerTest extends \PHPUnit_Framework_TestCase {

	private $appName;
	private $request;
	private $config;
	private $userSession;

	private $dummyUser;

	private $controller;

	public function setUp() {

		$this->appName = 'calendar';
		$this->request = $this->getMockBuilder('\OCP\IRequest')
			->disableOriginalConstructor()
			->getMock();
		$this->config = $this->getMockBuilder('\OCP\IConfig')
			->disableOriginalConstructor()
			->getMock();
		$this->userSession = $this->getMockBuilder('\OCP\IUserSession')
			->disableOriginalConstructor()
			->getMock();

		$this->dummyUser = $this->getMockBuilder('OCP\IUser')
			->disableOriginalConstructor()
			->getMock();

		$this->controller = new ViewController($this->appName, $this->request,
			$this->userSession, $this->config);
	}

	/**
	 * @dataProvider indexDataProvider
	 */
	public function testIndex($isAssetPipelineEnabled) {
		$this->config->expects($this->once())
			->method('getSystemValue')
			->with('asset-pipeline.enabled', false)
			->will($this->returnValue($isAssetPipelineEnabled));

		if ($isAssetPipelineEnabled) {
			$actual = $this->controller->index();

			$this->assertInstanceOf('OCP\AppFramework\Http\TemplateResponse', $actual);
			$this->assertEquals([], $actual->getParams());
			$this->assertEquals('main-asset-pipeline-unsupported', $actual->getTemplateName());
		} else {
			$this->userSession->expects($this->once())
				->method('getUser')
				->will($this->returnValue($this->dummyUser));

			$this->dummyUser->expects($this->once())
				->method('getUID')
				->will($this->returnValue('user123'));

			$this->config->expects($this->once())
				->method('getAppValue')
				->with($this->appName, 'installed_version')
				->will($this->returnValue('42.13.37'));

			$this->config->expects($this->at(2))
				->method('getUserValue')
				->with('user123', $this->appName, 'currentView', 'month')
				->will($this->returnValue('someView'));

			$this->config->expects($this->at(3))
				->method('getUserValue')
				->with('user123', 'settings', 'email')
				->will($this->returnValue('[email protected]'));

			$actual = $this->controller->index();

			$this->assertInstanceOf('OCP\AppFramework\Http\TemplateResponse', $actual);
			$this->assertEquals([
				'appVersion' => '42.13.37',
				'defaultView' => 'someView',
				'emailAddress' => '[email protected]',
			], $actual->getParams());
			$this->assertEquals('main', $actual->getTemplateName());
		}

	}

	public function indexDataProvider() {
		return [
			[true],
			[false]
		];
	}

	public function testGetTimezone() {
		$actual = $this->controller->getTimezone('TIMEZONE1.ics');

		$this->assertInstanceOf('OCP\AppFramework\Http\DataDisplayResponse', $actual);
		$this->assertEquals('TIMEZONE1-data', $actual->getData());
	}

	public function testGetTimezoneWithFakeTz() {
		$actual = $this->controller->getTimezone('TIMEZONE42.ics');

		$this->assertInstanceOf('OCP\AppFramework\Http\NotFoundResponse', $actual);
	}

	public function testGetTimezoneWithRegion() {
		$actual = $this->controller->getTimezoneWithRegion('REG', 'CIT.ics');

		$this->assertInstanceOf('OCP\AppFramework\Http\DataDisplayResponse', $actual);
		$this->assertEquals('TIMEZONE DATA WITH REGION AND CITY', $actual->getData());
	}

	public function testGetTimezoneWithRegionWithFakeTz() {
		$actual = $this->controller->getTimezoneWithRegion('EUROPE', 'BERLIN.ics');

		$this->assertInstanceOf('OCP\AppFramework\Http\NotFoundResponse', $actual);
	}
}


1		<?php
2		/**
3		* ownCloud - Calendar App
4		*
5		* @author Georg Ehrke
6		* @copyright 2016 Georg Ehrke <[email protected]>
7		*
8		* This library is free software; you can redistribute it and/or
9		* modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
10		* License as published by the Free Software Foundation; either
11		* version 3 of the License, or any later version.
12		*
13		* This library is distributed in the hope that it will be useful,
14		* but WITHOUT ANY WARRANTY; without even the implied warranty of
15		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16		* GNU AFFERO GENERAL PUBLIC LICENSE for more details.
17		*
18		* You should have received a copy of the GNU Affero General Public
19		* License along with this library. If not, see <http://www.gnu.org/licenses/>.
20		*
21		*/
22		namespace OCA\Calendar\Controller;
23
24		function scandir($directory) {
25		$dir = substr(__DIR__, 0, -strlen('tests/unit/controller')) . 'controller/../timezones/';
26		return $dir === $directory ? [
27		'..',
28		'.',
29		'TIMEZONE1.ics',
30		'TIMEZONE2.ics',
31		'REG-CIT.ics',
32		'INFO.md',
33		] : [];
34		}
35
36		function file_get_contents($file) {
37		$file_parts = explode('/', $file);
38		end($file_parts);
39		$file = current($file_parts);
40		switch($file) {
41		case 'TIMEZONE1.ics':
42		return 'TIMEZONE1-data';
43
44		case 'TIMEZONE2.ics':
45		return 'ANOTHER TIMEZONE DATA';
46
47		case 'REG-CIT.ics':
48		return 'TIMEZONE DATA WITH REGION AND CITY';
49
50		default:
51		return null;
52		}
53		}
54
55		class ViewControllerTest extends \PHPUnit_Framework_TestCase {
56
57		private $appName;
58		private $request;
59		private $config;
60		private $userSession;
61
62		private $dummyUser;
63
64		private $controller;
65
66	View Code Duplication	public function setUp() {
		0 ignored issues – show Duplication introduced 2016-03-01 08:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
67		$this->appName = 'calendar';
68		$this->request = $this->getMockBuilder('\OCP\IRequest')
69		->disableOriginalConstructor()
70		->getMock();
71		$this->config = $this->getMockBuilder('\OCP\IConfig')
72		->disableOriginalConstructor()
73		->getMock();
74		$this->userSession = $this->getMockBuilder('\OCP\IUserSession')
75		->disableOriginalConstructor()
76		->getMock();
77
78		$this->dummyUser = $this->getMockBuilder('OCP\IUser')
79		->disableOriginalConstructor()
80		->getMock();
81
82		$this->controller = new ViewController($this->appName, $this->request,
83		$this->userSession, $this->config);
84		}
85
86		/**
87		* @dataProvider indexDataProvider
88		*/
89		public function testIndex($isAssetPipelineEnabled) {
90		$this->config->expects($this->once())
91		->method('getSystemValue')
92		->with('asset-pipeline.enabled', false)
93		->will($this->returnValue($isAssetPipelineEnabled));
94
95		if ($isAssetPipelineEnabled) {
96		$actual = $this->controller->index();
97
98		$this->assertInstanceOf('OCP\AppFramework\Http\TemplateResponse', $actual);
99		$this->assertEquals([], $actual->getParams());
100		$this->assertEquals('main-asset-pipeline-unsupported', $actual->getTemplateName());
101		} else {
102		$this->userSession->expects($this->once())
103		->method('getUser')
104		->will($this->returnValue($this->dummyUser));
105
106		$this->dummyUser->expects($this->once())
107		->method('getUID')
108		->will($this->returnValue('user123'));
109
110		$this->config->expects($this->once())
111		->method('getAppValue')
112		->with($this->appName, 'installed_version')
113		->will($this->returnValue('42.13.37'));
114
115		$this->config->expects($this->at(2))
116		->method('getUserValue')
117		->with('user123', $this->appName, 'currentView', 'month')
118		->will($this->returnValue('someView'));
119
120		$this->config->expects($this->at(3))
121		->method('getUserValue')
122		->with('user123', 'settings', 'email')
123		->will($this->returnValue('[email protected]'));
124
125		$actual = $this->controller->index();
126
127		$this->assertInstanceOf('OCP\AppFramework\Http\TemplateResponse', $actual);
128		$this->assertEquals([
129		'appVersion' => '42.13.37',
130		'defaultView' => 'someView',
131		'emailAddress' => '[email protected]',
132		], $actual->getParams());
133		$this->assertEquals('main', $actual->getTemplateName());
134		}
135
136		}
137
138		public function indexDataProvider() {
139		return [
140		[true],
141		[false]
142		];
143		}
144
145		public function testGetTimezone() {
146		$actual = $this->controller->getTimezone('TIMEZONE1.ics');
147
148		$this->assertInstanceOf('OCP\AppFramework\Http\DataDisplayResponse', $actual);
149		$this->assertEquals('TIMEZONE1-data', $actual->getData());
150		}
151
152		public function testGetTimezoneWithFakeTz() {
153		$actual = $this->controller->getTimezone('TIMEZONE42.ics');
154
155		$this->assertInstanceOf('OCP\AppFramework\Http\NotFoundResponse', $actual);
156		}
157
158		public function testGetTimezoneWithRegion() {
159		$actual = $this->controller->getTimezoneWithRegion('REG', 'CIT.ics');
160
161		$this->assertInstanceOf('OCP\AppFramework\Http\DataDisplayResponse', $actual);
162		$this->assertEquals('TIMEZONE DATA WITH REGION AND CITY', $actual->getData());
163		}
164
165		public function testGetTimezoneWithRegionWithFakeTz() {
166		$actual = $this->controller->getTimezoneWithRegion('EUROPE', 'BERLIN.ics');
167
168		$this->assertInstanceOf('OCP\AppFramework\Http\NotFoundResponse', $actual);
169		}
170		}
171

owncloud / calendar

Push — new-loading-classe ( ae9924 )

viewcontrollerTest.php ➔ file_get_contents() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like