Issues in webviewcontroller.php (master) - Issues in master - owncloud/bookmarks - Measure and Improve Code Quality continuously with Scrutinizer

Issues (33)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

controller/webviewcontroller.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * ownCloud - bookmarks
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the COPYING file.
 *
 * @author Stefan Klemm <[email protected]>
 * @copyright Stefan Klemm 2014
 */

namespace OCA\Bookmarks\Controller;

use OCP\AppFramework\Http\ContentSecurityPolicy;
use \OCP\IRequest;
use \OCP\AppFramework\Http\TemplateResponse;
use \OCP\AppFramework\Controller;
use \OCP\IDb;
use \OCA\Bookmarks\Controller\Lib\Bookmarks;
use OCP\IURLGenerator;

class WebViewController extends Controller {

	/** @var  string */
	private $userId;

	/** @var IURLGenerator  */
	private $urlgenerator;

	/** @var IDb  */
	private $db;

	/**
	 * WebViewController constructor.
	 *
	 * @param string $appName
	 * @param IRequest $request
	 * @param $userId
	 * @param IURLGenerator $urlgenerator
	 * @param IDb $db
	 */
	public function __construct($appName, IRequest $request, $userId, IURLGenerator $urlgenerator, IDb $db) {
		parent::__construct($appName, $request);
		$this->userId = $userId;
		$this->urlgenerator = $urlgenerator;
		$this->db = $db;
	}

	/**
	 * @NoAdminRequired
	 * @NoCSRFRequired
	 */
	public function index() {
		$bookmarkleturl = $this->urlgenerator->getAbsoluteURL('index.php/apps/bookmarks/bookmarklet');
		$params = array('user' => $this->userId, 'bookmarkleturl' => $bookmarkleturl);

		$policy = new ContentSecurityPolicy();
		$policy->addAllowedFrameDomain("'self'");

		$response = new TemplateResponse('bookmarks', 'main', $params);
		$response->setContentSecurityPolicy($policy);
		return $response;
	}

	/**
	 * @param string $url
	 * @param string $title
	 * @return TemplateResponse
	 *
	 * @NoAdminRequired
	 * @NoCSRFRequired
	 */
	public function bookmarklet($url = "", $title = "") {
		$bookmarkExists = Bookmarks::bookmarkExists($url, $this->userId, $this->db);
		$description = "";
        $tags = [];
		if ($bookmarkExists !== false){
			$bookmark = Bookmarks::findUniqueBookmark($bookmarkExists, $this->userId, $this->db);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$description = $bookmark['description'];
            $tags = $bookmark['tags'];
		}
		$params = array(
            'url'           => $url,
            'title'         => $title,
            'description'   => $description,
            'bookmarkExists'=> $bookmarkExists,
            'tags'          => $tags
        );
		return new TemplateResponse('bookmarks', 'addBookmarklet', $params);  // templates/main.php
	}

}


1			<?php
2
3			/**
4			* ownCloud - bookmarks
5			*
6			* This file is licensed under the Affero General Public License version 3 or
7			* later. See the COPYING file.
8			*
9			* @author Stefan Klemm <[email protected]>
10			* @copyright Stefan Klemm 2014
11			*/
12
13			namespace OCA\Bookmarks\Controller;
14
15			use OCP\AppFramework\Http\ContentSecurityPolicy;
16			use \OCP\IRequest;
17			use \OCP\AppFramework\Http\TemplateResponse;
18			use \OCP\AppFramework\Controller;
19			use \OCP\IDb;
20			use \OCA\Bookmarks\Controller\Lib\Bookmarks;
21			use OCP\IURLGenerator;
22
23			class WebViewController extends Controller {
24
25			/** @var string */
26			private $userId;
27
28			/** @var IURLGenerator */
29			private $urlgenerator;
30
31			/** @var IDb */
32			private $db;
33
34			/**
35			* WebViewController constructor.
36			*
37			* @param string $appName
38			* @param IRequest $request
39			* @param $userId
40			* @param IURLGenerator $urlgenerator
41			* @param IDb $db
42			*/
43			public function __construct($appName, IRequest $request, $userId, IURLGenerator $urlgenerator, IDb $db) {
44			parent::__construct($appName, $request);
45			$this->userId = $userId;
46			$this->urlgenerator = $urlgenerator;
47			$this->db = $db;
48			}
49
50			/**
51			* @NoAdminRequired
52			* @NoCSRFRequired
53			*/
54			public function index() {
55			$bookmarkleturl = $this->urlgenerator->getAbsoluteURL('index.php/apps/bookmarks/bookmarklet');
56			$params = array('user' => $this->userId, 'bookmarkleturl' => $bookmarkleturl);
57
58			$policy = new ContentSecurityPolicy();
59			$policy->addAllowedFrameDomain("'self'");
60
61			$response = new TemplateResponse('bookmarks', 'main', $params);
62			$response->setContentSecurityPolicy($policy);
63			return $response;
64			}
65
66			/**
67			* @param string $url
68			* @param string $title
69			* @return TemplateResponse
70			*
71			* @NoAdminRequired
72			* @NoCSRFRequired
73			*/
74			public function bookmarklet($url = "", $title = "") {
75			$bookmarkExists = Bookmarks::bookmarkExists($url, $this->userId, $this->db);
76			$description = "";
77			$tags = [];
78			if ($bookmarkExists !== false){
79			$bookmark = Bookmarks::findUniqueBookmark($bookmarkExists, $this->userId, $this->db);
			0 ignored issues – show Documentation introduced 2016-07-31 21:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$bookmarkExists` is of type `boolean`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
80			$description = $bookmark['description'];
81			$tags = $bookmark['tags'];
82			}
83			$params = array(
84			'url' => $url,
85			'title' => $title,
86			'description' => $description,
87			'bookmarkExists'=> $bookmarkExists,
88			'tags' => $tags
89			);
90			return new TemplateResponse('bookmarks', 'addBookmarklet', $params); // templates/main.php
91			}
92
93			}
94

owncloud / bookmarks

Issues (33)

Security Analysis no request data

controller/webviewcontroller.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like