OCA\Bookmarks\Controller\Rest\PublicController

Complexity

Total Complexity

17

Size/Duplication

Total Lines	147
Duplicated Lines	24.49 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

23.19%

Importance

Changes	7
Bugs	0	Features	3

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	returnAddAsJson()	18	18	3
A	returnUpdateAsJson()	18	18	3
A	returnDeleteAsJson()	0	15	2
A	returnClickBookmarkAsJson()	0	21	2
A	newJsonErrorMessage()	0	6	1
B	returnAsJson()	0	23	5

<?php

namespace OCA\Bookmarks\Controller\Rest;

use \OCP\AppFramework\ApiController;
use \OCP\IRequest;
use \OCP\IDb;
use \OCP\AppFramework\Http\JSONResponse;
use \OC\User\Manager;
use OCA\Bookmarks\Controller\Lib\Bookmarks;

class PublicController extends ApiController {

	private $db;
	private $userManager;

	public function __construct($appName, IRequest $request, IDb $db, Manager $userManager) {
		parent::__construct(
				$appName, $request);

		$this->db = $db;
		$this->userManager = $userManager;
	}

    /**
	 * @CORS
	 * @NoAdminRequired
	 * @NoCSRFRequired
	 */
	public function returnAsJson($user, $tags = array(), $conjunction = "or", $select = null, $sortby = "") {

		if ($tags != null && $tags[0] == "") {
			$tags = array();
		}

		$attributesToSelect = array('url', 'title');

		if ($select != null) {
			$attributesToSelect = array_merge($attributesToSelect, $select);
			$attributesToSelect = array_unique($attributesToSelect);
		}

		$output = Bookmarks::findBookmarks($user, $this->db, 0, $sortby, $tags, true, -1, false, $attributesToSelect, $conjunction);

		if (count($output) == 0) {
			$output["status"] = 'error';
			$output["message"] = "No results from this query";
			return new JSONResponse($output);
		}

		return new JSONResponse($output);
	}


    /**
     * @CORS
     * @NoAdminRequired
     * @NoCSRFRequired
     */
    public function returnAddAsJson($user, $url = "", $tags = array(), $title = "", $description = "") {

This method seems to be duplicated in your project.

        if ($tags[0] == "") {
            $tags = array();
        }

        $output = Bookmarks::addBookmark($user, $this->db, $url, $title, $tags, $description, false);

        if (count($output) == 0) {
            $output["status"] = 'error';
            $output["message"] = "No results from this query";
            return new JSONResponse($output);
        }

        $output = Bookmarks::findUniqueBookmark($output,$user,$this->db);

        return new JSONResponse($output);
    }

    /**
     * @CORS
     * @NoAdminRequired
     * @NoCSRFRequired
     */
    public function returnUpdateAsJson($user, $id, $url = "", $tags = array(), $title = "", $description = "") {

This method seems to be duplicated in your project.

        if ($tags[0] == "") {
            $tags = array();
        }

        $output = Bookmarks::editBookmark($user, $this->db, $id, $url, $title, $tags, $description, false);

        if (count($output) == 0) {
            $output["status"] = 'error';
            $output["message"] = "No results from this query";
            return new JSONResponse($output);
        }

        $output = Bookmarks::findUniqueBookmark($output,$user,$this->db);

        return new JSONResponse($output);
    }

    /**
     * @CORS
     * @NoAdminRequired
     * @NoCSRFRequired
     */
    public function returnDeleteAsJson($user, $id) {
        $output = Bookmarks::deleteUrl($user, $this->db, $id);

        if (!$output) {
            $output = array();
            $output["status"] = 'error';
            $output["message"] = "Cannot delete bookmark";
            return new JSONResponse($output);
        }else{
            $output = array();
            $output["status"] = 'success';
            $output["message"] = "Bookmark deleted";
            return new JSONResponse($output);
        }
    }

    /**
     * @CORS
     * @NoAdminRequired
     * @NoCSRFRequired
     */
    public function returnClickBookmarkAsJson($user, $url) {

        // Check if it is a valid URL
        if (filter_var($url, FILTER_VALIDATE_URL) === FALSE) {
            return new JSONResponse(array(), Http::STATUS_BAD_REQUEST);
        }

        $query = $this->db->prepareQuery('
            UPDATE `*PREFIX*bookmarks`
            SET `clickcount` = `clickcount` + 1
            WHERE `user_id` = ?
                AND `url` LIKE ?
            ');

        $params = array($user, htmlspecialchars_decode($url));
        $query->execute($params);

        $output = array();
        $output["status"] = "success";
        return new JSONResponse($output);
    }

	public function newJsonErrorMessage($message) {
		$output = array();
		$output["status"] = 'error';
		$output["message"] = $message;
		return new JSONResponse($output);
	}

}