BookmarkController - Code Metrics - Inspection of "Merge pull request #241 from owncloud/backport-240..." - owncloud/bookmarks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — stable9 ( 06c556...cf9757 )

by Blizzz

created 2016-04-24 15:43 UTC

BookmarkController B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	256
Duplicated Lines	5.86 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

Importance

Changes	4
Bugs	1	Features	0

Metric	Value
wmc	41
c	4
b	1
f	0
lcom	1
cbo	2
dl	15
loc	256
ccs	0
cts	153
cp	0
rs	8.2769

11 Methods

Rating	Name	Duplication	Size	Complexity
A	legacyGetBookmarks()	0	3	1
A	__construct()	6	6	1
A	getBookmarks()	0	20	3
D	newBookmark()	3	41	10
A	legacyEditBookmark()	0	7	2
B	editBookmark()	3	21	7
A	legacyDeleteBookmark()	0	3	1
A	deleteBookmark()	0	11	3
A	clickBookmark()	3	20	4
B	importBookmark()	0	25	4
B	exportBookmark()	0	28	5

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like BookmarkController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use BookmarkController, and based on these observations, apply Extract Interface, too.

<?php

/**
 * ownCloud - bookmarks
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the COPYING file.
 *
 * @author Stefan Klemm <[email protected]>
 * @copyright Stefan Klemm 2014
 */

namespace OCA\Bookmarks\Controller\Rest;

use \OCP\IRequest;
use \OCP\AppFramework\ApiController;
use \OCP\AppFramework\Http\JSONResponse;
use \OCP\AppFramework\Http;
use \OCP\IDb;
use \OCA\Bookmarks\Controller\Lib\Bookmarks;
use \OCA\Bookmarks\Controller\Lib\ExportResponse;

class BookmarkController extends ApiController {

	private $userId;
	private $db;

	public function __construct($appName, IRequest $request, $userId, IDb $db) {

		parent::__construct($appName, $request);
		$this->userId = $userId;
		$this->db = $db;
		$this->request = $request;
	}

	/**
	 * @NoAdminRequired
	 */
	public function legacyGetBookmarks($type = "bookmark", $tag = '', $page = 0, $sort = "bookmarks_sorting_recent") {
		return $this->getBookmarks($type, $tag, $page, $sort);
	}

	/**
	 * @NoAdminRequired
	 */
	public function getBookmarks($type = "bookmark", $tag = '', $page = 0, $sort = "bookmarks_sorting_recent") {

		if ($type == 'rel_tags') {
			$tags = Bookmarks::analyzeTagRequest($tag);
			$qtags = Bookmarks::findTags($this->userId, $this->db, $tags);
			return new JSONResponse(array('data' => $qtags, 'status' => 'success'));
		} else { // type == bookmark
			$filterTag = Bookmarks::analyzeTagRequest($tag);

			$offset = $page * 10;

			if ($sort == 'bookmarks_sorting_clicks') {
				$sqlSortColumn = 'clickcount';
			} else {
				$sqlSortColumn = 'lastmodified';
			}
			$bookmarks = Bookmarks::findBookmarks($this->userId, $this->db, $offset, $sqlSortColumn, $filterTag, true);
			return new JSONResponse(array('data' => $bookmarks, 'status' => 'success'));
		}
	}

	/**
	 * @NoAdminRequired
	 */
	public function newBookmark($url = "", $item = array(), $from_own = 0, $title = "", $is_public = false, $description = "") {

		if ($from_own == 0) {
			// allow only http(s) and (s)ftp
			$protocols = '/^(https?|s?ftp)\:\/\//i';
			if (preg_match($protocols, $url)) {
				$datas = Bookmarks::getURLMetadata($url);
			// if not (allowed) protocol is given, assume http and https (and fetch both)
			} else { 
				// append https to url and fetch it
				$url_https = 'https://' . $url;
				$datas_https = Bookmarks::getURLMetadata($url_https);
				// append http to url and fetch it
				$url_http = 'http://' . $url;
				$datas_http = Bookmarks::getURLMetadata($url_http);
			}
			
			if (isset($datas['title'])) { // prefer original url if working
				$title = $datas['title'];
				//url remains unchanged
			} elseif (isset($datas_https['title'])) { // test if https works
				$title = $datas_https['title'];
				$url = $url_https;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
			} elseif (isset($datas_http['title'])) { // otherwise test http for results
				$title = $datas_http['title'];
				$url = $url_http;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
			}
		}

		// Check if it is a valid URL (after adding http(s) prefix)
		$urlData = parse_url($url);
		if ($urlData === false || !isset($urlData['scheme']) || !isset($urlData['host'])) {

			return new JSONResponse(array('status' => 'error'), Http::STATUS_BAD_REQUEST);
		}

		$tags = isset($item['tags']) ? $item['tags'] : array();

		$id = Bookmarks::addBookmark($this->userId, $this->db, $url, $title, $tags, $description, $is_public);
		$bm = Bookmarks::findUniqueBookmark($id, $this->userId, $this->db);
		return new JSONResponse(array('item' => $bm, 'status' => 'success'));
	}

	/**
	  @NoAdminRequired
	 * 
	 * @param int $id
	 * @param bool $is_public Description
	 * @return \OCP\AppFramework\Http\TemplateResponse
	 */
	//TODO id vs record_id?
	public function legacyEditBookmark($id = null, $url = "", $item = array(), $title = "", $is_public = false, $record_id = null, $description = "") {
		if ($id == null) {
			return $this->newBookmark($url, $item, false, $title, $is_public, $description);
		} else {
			return $this->editBookmark($id, $url, $item, $title, $is_public, $record_id, $description);
		}
	}

	/**
	  @NoAdminRequired
	 * 
	 * @param int $id
	 * @param bool $is_public Description
	 * @return \OCP\AppFramework\Http\TemplateResponse
	 */
	public function editBookmark($id = null, $url = "", $item = array(), $title = "", $is_public = false, $record_id = null, $description = "") {

		// Check if it is a valid URL
		$urlData = parse_url($url);
		if ($urlData === false || !isset($urlData['scheme']) || !isset($urlData['host'])) {

			return new JSONResponse(array(), Http::STATUS_BAD_REQUEST);
		}

		if ($record_id == null) {
			return new JSONResponse(array(), Http::STATUS_BAD_REQUEST);
		}

		$tags = isset($item['tags']) ? $item['tags'] : array();

		if (is_numeric($record_id)) {
			$id = Bookmarks::editBookmark($this->userId, $this->db, $record_id, $url, $title, $tags, $description, $is_public = false);
		}

		$bm = Bookmarks::findUniqueBookmark($id, $this->userId, $this->db);
		return new JSONResponse(array('item' => $bm, 'status' => 'success'));
	}

	/**
	  @NoAdminRequired
	 * 
	 * @param int $id
	 * @param bool $is_public Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
	 * @return \OCP\AppFramework\Http\JSONResponse
	 */
	public function legacyDeleteBookmark($id = -1) {
		return $this->deleteBookmark($id);
	}

	/**
	  @NoAdminRequired
	 * 
	 * @param int $id
	 * @param bool $is_public Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
	 * @return \OCP\AppFramework\Http\JSONResponse
	 */
	public function deleteBookmark($id = -1) {
		if ($id == -1) {
			return new JSONResponse(array(), Http::STATUS_BAD_REQUEST);
		}

		if (!Bookmarks::deleteUrl($this->userId, $this->db, $id)) {
			return new JSONResponse(array(), Http::STATUS_BAD_REQUEST);
		} else {
			return new JSONResponse(array('status' => 'success'), Http::STATUS_OK);
		}
	}

	/**
	  @NoAdminRequired
	 * 
	 * @param string $url
	 * @return \OCP\AppFramework\Http\JSONResponse
	 */
	public function clickBookmark($url = "") {

		// Check if it is a valid URL
		$urlData = parse_url($url);
		if ($urlData === false || !isset($urlData['scheme']) || !isset($urlData['host'])) {

			return new JSONResponse(array(), Http::STATUS_BAD_REQUEST);
		}

		$query = $this->db->prepareQuery('
	UPDATE `*PREFIX*bookmarks`
	SET `clickcount` = `clickcount` + 1
	WHERE `user_id` = ?
		AND `url` LIKE ?
	');

		$params = array($this->userId, htmlspecialchars_decode($url));
		$query->execute($params);

		return new JSONResponse(array('status' => 'success'), Http::STATUS_OK);
	}

	/**
	  @NoAdminRequired
	 * 
	 * @return \OCP\AppFramework\Http\JSONResponse
	 */
	public function importBookmark() {

		$l = new \OC_l10n('bookmarks');

		$full_input = $this->request->getUploadedFile("bm_import");

		if (empty($full_input)) {
			\OCP\Util::writeLog('bookmarks', "No file provided for import", \OCP\Util::WARN);
			$error = array();
			$error[] = $l->t('No file provided for import');
		} else {
			$error = array();
			$file = $full_input['tmp_name'];
			if ($full_input['type'] == 'text/html') {
				$error = Bookmarks::importFile($this->userId, $this->db, $file);
				if (empty($error)) {
					return new JSONResponse(array('status' => 'success'));
				}
			} else {
				$error[] = $l->t('Unsupported file type for import');
			}
		}

		return new JSONResponse(array('status' => 'error', 'data' => $error));
	}

	/**
	  @NoAdminRequired
	 * 
	 * @return \OCP\AppFramework\Http\JSONResponse
	 */
	public function exportBookmark() {

		$file = <<<EOT
<!DOCTYPE NETSCAPE-Bookmark-file-1>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=UTF-8">
<!-- This is an automatically generated file.
It will be read and overwritten.
Do Not Edit! -->
<TITLE>Bookmarks</TITLE>
<H1>Bookmarks</H1>
<DL><p>
EOT;
		$bookmarks = Bookmarks::findBookmarks($this->userId, $this->db, 0, 'id', array(), true, -1);
		foreach ($bookmarks as $bm) {
			$title = $bm['title'];
			if (trim($title) === '') {
				$url_parts = parse_url($bm['url']);
				$title = isset($url_parts['host']) ? OCA\Bookmarks\Controller\Lib\Helper::getDomainWithoutExt($url_parts['host']) : $bm['url'];
			}
			$file .= '<DT><A HREF="' . \OC_Util::sanitizeHTML($bm['url']) . '" TAGS="' . implode(',', \OC_Util::sanitizeHTML($bm['tags'])) . '">';
			$file .= htmlspecialchars($title, ENT_QUOTES, 'UTF-8') . '</A>';
			if ($bm['description'])
				$file .= '<DD>' . htmlspecialchars($bm['description'], ENT_QUOTES, 'UTF-8');
			$file .= "\n";
		}

		return new ExportResponse($file);
	}

}


Push — stable9 ( 06c556...cf9757 )

BookmarkController B

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

11 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

1		<?php
2
3		/**
4		* ownCloud - bookmarks
5		*
6		* This file is licensed under the Affero General Public License version 3 or
7		* later. See the COPYING file.
8		*
9		* @author Stefan Klemm <[email protected]>
10		* @copyright Stefan Klemm 2014
11		*/
12
13		namespace OCA\Bookmarks\Controller\Rest;
14
15		use \OCP\IRequest;
16		use \OCP\AppFramework\ApiController;
17		use \OCP\AppFramework\Http\JSONResponse;
18		use \OCP\AppFramework\Http;
19		use \OCP\IDb;
20		use \OCA\Bookmarks\Controller\Lib\Bookmarks;
21		use \OCA\Bookmarks\Controller\Lib\ExportResponse;
22
23		class BookmarkController extends ApiController {
24
25		private $userId;
26		private $db;
27
28	View Code Duplication	public function __construct($appName, IRequest $request, $userId, IDb $db) {
		0 ignored issues – show Duplication introduced 2015-12-06 07:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29		parent::__construct($appName, $request);
30		$this->userId = $userId;
31		$this->db = $db;
32		$this->request = $request;
33		}
34
35		/**
36		* @NoAdminRequired
37		*/
38		public function legacyGetBookmarks($type = "bookmark", $tag = '', $page = 0, $sort = "bookmarks_sorting_recent") {
39		return $this->getBookmarks($type, $tag, $page, $sort);
40		}
41
42		/**
43		* @NoAdminRequired
44		*/
45		public function getBookmarks($type = "bookmark", $tag = '', $page = 0, $sort = "bookmarks_sorting_recent") {
46
47		if ($type == 'rel_tags') {
48		$tags = Bookmarks::analyzeTagRequest($tag);
49		$qtags = Bookmarks::findTags($this->userId, $this->db, $tags);
50		return new JSONResponse(array('data' => $qtags, 'status' => 'success'));
51		} else { // type == bookmark
52		$filterTag = Bookmarks::analyzeTagRequest($tag);
53
54		$offset = $page * 10;
55
56		if ($sort == 'bookmarks_sorting_clicks') {
57		$sqlSortColumn = 'clickcount';
58		} else {
59		$sqlSortColumn = 'lastmodified';
60		}
61		$bookmarks = Bookmarks::findBookmarks($this->userId, $this->db, $offset, $sqlSortColumn, $filterTag, true);
62		return new JSONResponse(array('data' => $bookmarks, 'status' => 'success'));
63		}
64		}
65
66		/**
67		* @NoAdminRequired
68		*/
69		public function newBookmark($url = "", $item = array(), $from_own = 0, $title = "", $is_public = false, $description = "") {
70
71		if ($from_own == 0) {
72		// allow only http(s) and (s)ftp
73		$protocols = '/^(https?\|s?ftp)\:\/\//i';
74		if (preg_match($protocols, $url)) {
75		$datas = Bookmarks::getURLMetadata($url);
76		// if not (allowed) protocol is given, assume http and https (and fetch both)
77		} else {
78		// append https to url and fetch it
79		$url_https = 'https://' . $url;
80		$datas_https = Bookmarks::getURLMetadata($url_https);
81		// append http to url and fetch it
82		$url_http = 'http://' . $url;
83		$datas_http = Bookmarks::getURLMetadata($url_http);
84		}
85
86		if (isset($datas['title'])) { // prefer original url if working
87		$title = $datas['title'];
88		//url remains unchanged
89		} elseif (isset($datas_https['title'])) { // test if https works
90		$title = $datas_https['title'];
91		$url = $url_https;
		0 ignored issues – show Bug introduced 2015-12-06 07:12 UTC by Report Bug Copy Issue Report The variable `$url_https` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
92		} elseif (isset($datas_http['title'])) { // otherwise test http for results
93		$title = $datas_http['title'];
94		$url = $url_http;
		0 ignored issues – show Bug introduced 2015-12-06 07:12 UTC by Report Bug Copy Issue Report The variable `$url_http` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
95		}
96		}
97
98		// Check if it is a valid URL (after adding http(s) prefix)
99		$urlData = parse_url($url);
100	View Code Duplication	if ($urlData === false \|\| !isset($urlData['scheme']) \|\| !isset($urlData['host'])) {
		0 ignored issues – show Duplication introduced 2016-04-20 20:27 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
101		return new JSONResponse(array('status' => 'error'), Http::STATUS_BAD_REQUEST);
102		}
103
104		$tags = isset($item['tags']) ? $item['tags'] : array();
105
106		$id = Bookmarks::addBookmark($this->userId, $this->db, $url, $title, $tags, $description, $is_public);
107		$bm = Bookmarks::findUniqueBookmark($id, $this->userId, $this->db);
108		return new JSONResponse(array('item' => $bm, 'status' => 'success'));
109		}
110
111		/**
112		@NoAdminRequired
113		*
114		* @param int $id
115		* @param bool $is_public Description
116		* @return \OCP\AppFramework\Http\TemplateResponse
117		*/
118		//TODO id vs record_id?
119		public function legacyEditBookmark($id = null, $url = "", $item = array(), $title = "", $is_public = false, $record_id = null, $description = "") {
120		if ($id == null) {
121		return $this->newBookmark($url, $item, false, $title, $is_public, $description);
122		} else {
123		return $this->editBookmark($id, $url, $item, $title, $is_public, $record_id, $description);
124		}
125		}
126
127		/**
128		@NoAdminRequired
129		*
130		* @param int $id
131		* @param bool $is_public Description
132		* @return \OCP\AppFramework\Http\TemplateResponse
133		*/
134		public function editBookmark($id = null, $url = "", $item = array(), $title = "", $is_public = false, $record_id = null, $description = "") {
135
136		// Check if it is a valid URL
137		$urlData = parse_url($url);
138	View Code Duplication	if ($urlData === false \|\| !isset($urlData['scheme']) \|\| !isset($urlData['host'])) {
		0 ignored issues – show Duplication introduced 2016-04-20 20:27 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
139		return new JSONResponse(array(), Http::STATUS_BAD_REQUEST);
140		}
141
142		if ($record_id == null) {
143		return new JSONResponse(array(), Http::STATUS_BAD_REQUEST);
144		}
145
146		$tags = isset($item['tags']) ? $item['tags'] : array();
147
148		if (is_numeric($record_id)) {
149		$id = Bookmarks::editBookmark($this->userId, $this->db, $record_id, $url, $title, $tags, $description, $is_public = false);
150		}
151
152		$bm = Bookmarks::findUniqueBookmark($id, $this->userId, $this->db);
153		return new JSONResponse(array('item' => $bm, 'status' => 'success'));
154		}
155
156		/**
157		@NoAdminRequired
158		*
159		* @param int $id
160		* @param bool $is_public Description
		0 ignored issues – show Bug introduced 2015-12-06 07:12 UTC by Report Bug Copy Issue Report There is no parameter named `$is_public`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
161		* @return \OCP\AppFramework\Http\JSONResponse
162		*/
163		public function legacyDeleteBookmark($id = -1) {
164		return $this->deleteBookmark($id);
165		}
166
167		/**
168		@NoAdminRequired
169		*
170		* @param int $id
171		* @param bool $is_public Description
		0 ignored issues – show Bug introduced 2015-12-06 07:12 UTC by Report Bug Copy Issue Report There is no parameter named `$is_public`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
172		* @return \OCP\AppFramework\Http\JSONResponse
173		*/
174		public function deleteBookmark($id = -1) {
175		if ($id == -1) {
176		return new JSONResponse(array(), Http::STATUS_BAD_REQUEST);
177		}
178
179		if (!Bookmarks::deleteUrl($this->userId, $this->db, $id)) {
180		return new JSONResponse(array(), Http::STATUS_BAD_REQUEST);
181		} else {
182		return new JSONResponse(array('status' => 'success'), Http::STATUS_OK);
183		}
184		}
185
186		/**
187		@NoAdminRequired
188		*
189		* @param string $url
190		* @return \OCP\AppFramework\Http\JSONResponse
191		*/
192		public function clickBookmark($url = "") {
193
194		// Check if it is a valid URL
195		$urlData = parse_url($url);
196	View Code Duplication	if ($urlData === false \|\| !isset($urlData['scheme']) \|\| !isset($urlData['host'])) {
		0 ignored issues – show Duplication introduced 2016-04-20 20:27 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
197		return new JSONResponse(array(), Http::STATUS_BAD_REQUEST);
198		}
199
200		$query = $this->db->prepareQuery('
201		UPDATE `PREFIXbookmarks`
202		SET `clickcount` = `clickcount` + 1
203		WHERE `user_id` = ?
204		AND `url` LIKE ?
205		');
206
207		$params = array($this->userId, htmlspecialchars_decode($url));
208		$query->execute($params);
209
210		return new JSONResponse(array('status' => 'success'), Http::STATUS_OK);
211		}
212
213		/**
214		@NoAdminRequired
215		*
216		* @return \OCP\AppFramework\Http\JSONResponse
217		*/
218		public function importBookmark() {
219
220		$l = new \OC_l10n('bookmarks');
221
222		$full_input = $this->request->getUploadedFile("bm_import");
223
224		if (empty($full_input)) {
225		\OCP\Util::writeLog('bookmarks', "No file provided for import", \OCP\Util::WARN);
226		$error = array();
227		$error[] = $l->t('No file provided for import');
228		} else {
229		$error = array();
230		$file = $full_input['tmp_name'];
231		if ($full_input['type'] == 'text/html') {
232		$error = Bookmarks::importFile($this->userId, $this->db, $file);
233		if (empty($error)) {
234		return new JSONResponse(array('status' => 'success'));
235		}
236		} else {
237		$error[] = $l->t('Unsupported file type for import');
238		}
239		}
240
241		return new JSONResponse(array('status' => 'error', 'data' => $error));
242		}
243
244		/**
245		@NoAdminRequired
246		*
247		* @return \OCP\AppFramework\Http\JSONResponse
248		*/
249		public function exportBookmark() {
250
251		$file = <<<EOT
252		<!DOCTYPE NETSCAPE-Bookmark-file-1>
253		<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=UTF-8">
254		<!-- This is an automatically generated file.
255		It will be read and overwritten.
256		Do Not Edit! -->
257		<TITLE>Bookmarks</TITLE>
258		<H1>Bookmarks</H1>
259		<DL><p>
260		EOT;
261		$bookmarks = Bookmarks::findBookmarks($this->userId, $this->db, 0, 'id', array(), true, -1);
262		foreach ($bookmarks as $bm) {
263		$title = $bm['title'];
264		if (trim($title) === '') {
265		$url_parts = parse_url($bm['url']);
266		$title = isset($url_parts['host']) ? OCA\Bookmarks\Controller\Lib\Helper::getDomainWithoutExt($url_parts['host']) : $bm['url'];
267		}
268		$file .= '<DT><A HREF="' . \OC_Util::sanitizeHTML($bm['url']) . '" TAGS="' . implode(',', \OC_Util::sanitizeHTML($bm['tags'])) . '">';
269		$file .= htmlspecialchars($title, ENT_QUOTES, 'UTF-8') . '</A>';
270		if ($bm['description'])
271		$file .= '<DD>' . htmlspecialchars($bm['description'], ENT_QUOTES, 'UTF-8');
272		$file .= "\n";
273		}
274
275		return new ExportResponse($file);
276		}
277
278		}
279

owncloud / bookmarks

Push — stable9 ( 06c556...cf9757 )

BookmarkController B

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

11 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like