PublicController::returnAsJson() - Code Metrics - Inspection of "Merge pull request #287 from owncloud/fix-warning" - owncloud/bookmarks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 87680b...8a04a7 )

by Blizzz

created 2016-08-26 23:28 UTC

PublicController::returnAsJson() C

↳ Parent: PublicController

Complexity

Conditions	11
Paths	31

Size

Total Lines	46
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	97.1378

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
cc	11
eloc	25
c	2
b	1
f	0
nc	31
nop	6
dl	0
loc	46
ccs	3
cts	28
cp	0.1071
crap	97.1378
rs	5.2653

How to fix Complexity

<?php

namespace OCA\Bookmarks\Controller\Rest;

use \OCP\AppFramework\ApiController;
use \OCP\IRequest;
use \OCP\IDb;
use \OCP\AppFramework\Http\JSONResponse;
use \OC\User\Manager;
use OCA\Bookmarks\Controller\Lib\Bookmarks;
use OCP\Util;

class PublicController extends ApiController {

	private $db;
	private $userManager;

	public function __construct($appName, IRequest $request, IDb $db, Manager $userManager) {
		parent::__construct(
				$appName, $request);

		$this->db = $db;
		$this->userManager = $userManager;
	}

	/**
	 * @param string $user
	 * @param string $password
	 * @param array $tags
	 * @param string $conjunction
	 * @param array $select
	 * @param string $sortby
	 * @return JSONResponse
	 *
	 * @CORS
	 * @NoAdminRequired
	 * @NoCSRFRequired
	 * @PublicPage
	 */
	public function returnAsJson($user, $password = null, $tags = array(), $conjunction = "or", $select = null, $sortby = "") {

		if ($user == null || $this->userManager->userExists($user) == false) {
			return $this->newJsonErrorMessage("User could not be identified");
		}

		if (!is_array($tags)) {
			if(is_string($tags) && $tags !== '') {
				$tags = [ $tags ];
			} else {
				$tags = array();
			}
		}

		$public = true;

		if ($password != null) {

			$public = false;
		}


		if (!$public && !$this->userManager->checkPassword($user, $password)) {

			$msg = 'REST API accessed with wrong password';
			Util::writeLog('bookmarks', $msg, Util::WARN);

			return $this->newJsonErrorMessage("Wrong password for user " . $user);
		}

		$attributesToSelect = array('url', 'title');

		if ($select != null) {
			$attributesToSelect = array_merge($attributesToSelect, $select);
			$attributesToSelect = array_unique($attributesToSelect);
		}

		$output = Bookmarks::findBookmarks($user, $this->db, 0, $sortby, $tags, true, -1, $public, $attributesToSelect, $conjunction);

		if (count($output) == 0) {
			$output["status"] = 'error';
			$output["message"] = "No results from this query";
			return new JSONResponse($output);
		}

		return new JSONResponse($output);
	}

	/**
	 * @param string $message
	 * @return JSONResponse
	 */
	public function newJsonErrorMessage($message) {
		$output = array();
		$output["status"] = 'error';
		$output["message"] = $message;
		return new JSONResponse($output);
	}

}


1		<?php
2
3		namespace OCA\Bookmarks\Controller\Rest;
4
5		use \OCP\AppFramework\ApiController;
6		use \OCP\IRequest;
7		use \OCP\IDb;
8		use \OCP\AppFramework\Http\JSONResponse;
9		use \OC\User\Manager;
10		use OCA\Bookmarks\Controller\Lib\Bookmarks;
11		use OCP\Util;
12
13		class PublicController extends ApiController {
14
15		private $db;
16		private $userManager;
17
18	3	public function __construct($appName, IRequest $request, IDb $db, Manager $userManager) {
19	3	parent::__construct(
20	3	$appName, $request);
21
22	3	$this->db = $db;
23	3	$this->userManager = $userManager;
24	3	}
25
26		/**
27		* @param string $user
28		* @param string $password
29		* @param array $tags
30		* @param string $conjunction
31		* @param array $select
32		* @param string $sortby
33		* @return JSONResponse
34		*
35		* @CORS
36		* @NoAdminRequired
37		* @NoCSRFRequired
38		* @PublicPage
39		*/
40	3	public function returnAsJson($user, $password = null, $tags = array(), $conjunction = "or", $select = null, $sortby = "") {
41
42	3	if ($user == null \|\| $this->userManager->userExists($user) == false) {
43	3	return $this->newJsonErrorMessage("User could not be identified");
44		}
45
46		if (!is_array($tags)) {
47		if(is_string($tags) && $tags !== '') {
48		$tags = [ $tags ];
49		} else {
50		$tags = array();
51		}
52		}
53
54		$public = true;
55
56		if ($password != null) {
		0 ignored issues – show Bug introduced 2016-08-06 09:37 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$password` of type `string\|null` against `null`; this is ambiguous if the string can be empty. Consider using a strict comparison `!==` instead. Loading history...
57		$public = false;
58		}
59
60
61		if (!$public && !$this->userManager->checkPassword($user, $password)) {
62
63		$msg = 'REST API accessed with wrong password';
64		Util::writeLog('bookmarks', $msg, Util::WARN);
65
66		return $this->newJsonErrorMessage("Wrong password for user " . $user);
67		}
68
69		$attributesToSelect = array('url', 'title');
70
71		if ($select != null) {
72		$attributesToSelect = array_merge($attributesToSelect, $select);
73		$attributesToSelect = array_unique($attributesToSelect);
74		}
75
76		$output = Bookmarks::findBookmarks($user, $this->db, 0, $sortby, $tags, true, -1, $public, $attributesToSelect, $conjunction);
77
78		if (count($output) == 0) {
79		$output["status"] = 'error';
80		$output["message"] = "No results from this query";
81		return new JSONResponse($output);
82		}
83
84		return new JSONResponse($output);
85		}
86
87		/**
88		* @param string $message
89		* @return JSONResponse
90		*/
91	3	public function newJsonErrorMessage($message) {
92	3	$output = array();
93	3	$output["status"] = 'error';
94	3	$output["message"] = $message;
95	3	return new JSONResponse($output);
96		}
97
98		}
99

owncloud / bookmarks

Push — master ( 87680b...8a04a7 )

PublicController::returnAsJson() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like