Test_LibBookmarks_Bookmarks::testFindBookmarks() - Code Metrics - owncloud/bookmarks - Measure and Improve Code Quality continuously with Scrutinizer

Test_LibBookmarks_Bookmarks::testFindBookmarks() A
last analyzed 2016-09-25 18:58 UTC

↳ Parent: Test_LibBookmarks_Bookmarks

Complexity

Conditions	1
Paths	1

Size

Total Lines	15
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	14
nc	1
nop	0
dl	0
loc	15
rs	9.4285
c	0
b	0
f	0

<?php

OC_App::loadApp('bookmarks');

use \OCA\Bookmarks\Controller\Lib\Bookmarks;

class Test_LibBookmarks_Bookmarks extends PHPUnit_Framework_TestCase {

	private $userid;
	private $db;

	protected function setUp() {
		$this->userid = \OCP\User::getUser();
		$this->db = \OC::$server->getDb();
	}

	function testAddBookmark() {

		$this->cleanDB();
		$this->assertCount(0, Bookmarks::findBookmarks($this->userid, $this->db, 0, 'id', array(), true, -1));
		Bookmarks::addBookmark($this->userid, $this->db, 'http://owncloud.org', 'owncloud project', array('oc', 'cloud'), 'An Awesome project');
		$this->assertCount(1, Bookmarks::findBookmarks($this->userid, $this->db, 0, 'id', array(), true, -1));
		Bookmarks::addBookmark($this->userid, $this->db, 'http://de.wikipedia.org/Ü', 'Das Ü', array('encyclopedia', 'lang'), 'A terrific letter');
		$this->assertCount(2, Bookmarks::findBookmarks($this->userid, $this->db, 0, 'id', array(), true, -1));
	}

	function testFindBookmarks() {

		$this->cleanDB();
		Bookmarks::addBookmark($this->userid, $this->db, "http://www.google.de", "Google", array("one"), "PrivateNoTag", false);
		Bookmarks::addBookmark($this->userid, $this->db, "http://www.heise.de", "Heise", array("one", "two"), "PrivatTag", false);
		Bookmarks::addBookmark($this->userid, $this->db, "http://www.golem.de", "Golem", array("one"), "PublicNoTag", true);
		Bookmarks::addBookmark($this->userid, $this->db, "http://www.9gag.com", "9gag", array("two", "three"), "PublicTag", true);
		$outputPrivate = Bookmarks::findBookmarks($this->userid, $this->db, 0, "", array(), true, -1, false);
		$this->assertCount(4, $outputPrivate);
		$outputPrivateFiltered = Bookmarks::findBookmarks($this->userid, $this->db, 0, "", array("one"), true, -1, false);
		$this->assertCount(3, $outputPrivateFiltered);
		$outputPublic = Bookmarks::findBookmarks($this->userid, $this->db, 0, "", array(), true, -1, true);
		$this->assertCount(2, $outputPublic);
		$outputPublicFiltered = Bookmarks::findBookmarks($this->userid, $this->db, 0, "", array("two"), true, -1, true);
		$this->assertCount(1, $outputPublicFiltered);
	}

	function testFindBookmarksSelectAndOrFilteredTags() {

		$this->cleanDB();
		$secondUser = $this->userid . "andHisClone435";
		Bookmarks::addBookmark($this->userid, $this->db, "http://www.google.de", "Google", array("one"), "PrivateNoTag", false);
		Bookmarks::addBookmark($this->userid, $this->db, "http://www.heise.de", "Heise", array("one", "two"), "PrivatTag", false);
		Bookmarks::addBookmark($this->userid, $this->db, "http://www.golem.de", "Golem", array("four"), "PublicNoTag", true);
		Bookmarks::addBookmark($this->userid, $this->db, "http://www.9gag.com", "9gag", array("two", "three"), "PublicTag", true);
		Bookmarks::addBookmark($secondUser, $this->db, "http://www.google.de", "Google", array("one"), "PrivateNoTag", false);
		Bookmarks::addBookmark($secondUser, $this->db, "http://www.heise.de", "Heise", array("one", "two"), "PrivatTag", false);
		Bookmarks::addBookmark($secondUser, $this->db, "http://www.golem.de", "Golem", array("four"), "PublicNoTag", true);
		Bookmarks::addBookmark($secondUser, $this->db, "http://www.9gag.com", "9gag", array("two", "three"), "PublicTag", true);
		$resultSetOne = Bookmarks::findBookmarks($this->userid, $this->db, 0, 'lastmodified', array('one', 'three'), true, -1, false, array('url', 'title'), 'or');
		$this->assertEquals(3, count($resultSetOne));
		$resultOne = $resultSetOne[0];
		$this->assertFalse(isset($resultOne['lastmodified']));
		$this->assertFalse(isset($resultOne['tags']));
	}

	function testFindTags() {

		$this->cleanDB();
		$this->assertEquals(Bookmarks::findTags($this->userid, $this->db), array());
		Bookmarks::addBookmark($this->userid, $this->db, 'http://owncloud.org', 'Owncloud project', array('oc', 'cloud'), 'An Awesome project');
		$this->assertEquals(array(0 => array('tag' => 'cloud', 'nbr' => 1), 1 => array('tag' => 'oc', 'nbr' => 1)), Bookmarks::findTags($this->userid, $this->db));
	}

	function testFindUniqueBookmark() {

		$this->cleanDB();
		$id = Bookmarks::addBookmark($this->userid, $this->db, "http://www.heise.de", "Heise", array("one", "two"), "PrivatTag", false);
		$bookmark = Bookmarks::findUniqueBookmark($id, $this->userid, $this->db);
		$this->assertEquals($id, $bookmark['id']);
		$this->assertEquals("Heise", $bookmark['title']);
	}

	function testEditBookmark() {

		$this->cleanDB();
		$id = Bookmarks::addBookmark($this->userid, $this->db, "http://www.heise.de", "Heise", array("one", "two"), "PrivatTag", false);
		Bookmarks::editBookmark($this->userid, $this->db, $id, "http://www.google.de", "NewTitle", array("three"));
		$bookmark = Bookmarks::findUniqueBookmark($id, $this->userid, $this->db);
		$this->assertEquals("NewTitle", $bookmark['title']);
		$this->assertEquals("http://www.google.de", $bookmark['url']);
		$this->assertEquals(1, count($bookmark['tags']));
	}

	function testDeleteBookmark() {

		$this->cleanDB();
		Bookmarks::addBookmark($this->userid, $this->db, "http://www.google.de", "Google", array("one"), "PrivateNoTag", false);
		$id = Bookmarks::addBookmark($this->userid, $this->db, "http://www.heise.de", "Heise", array("one", "two"), "PrivatTag", false);
		$this->assertNotEquals(false, Bookmarks::bookmarkExists("http://www.google.de", $this->userid, $this->db));
		$this->assertNotEquals(false, Bookmarks::bookmarkExists("http://www.heise.de", $this->userid, $this->db));
		Bookmarks::deleteUrl($this->userid, $this->db, $id);
		$this->assertFalse(Bookmarks::bookmarkExists("http://www.heise.de", $this->userid, $this->db));
	}

	function testGetURLMetadata() {


		$config = $this->getMockBuilder('\OCP\IConfig')
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
						->disableOriginalConstructor()->getMock();
		$amazonResponse = $this->getMock('OCP\Http\Client\IResponse');
		$amazonResponse->expects($this->once())
			->method('getBody')
			->will($this->returnValue(file_get_contents(__DIR__ . '/res/amazonHtml.file')));
		$amazonResponse->expects($this->once())
			->method('getHeader')
			->with('Content-Type')
			->will($this->returnValue(''));

		$golemResponse = $this->getMock('OCP\Http\Client\IResponse');
		$golemResponse->expects($this->once())
			->method('getBody')
			->will($this->returnValue(file_get_contents(__DIR__ . '/res/golemHtml.file')));
		$golemResponse->expects($this->once())
			->method('getHeader')
			->with('Content-Type')
			->will($this->returnValue('text/html; charset=UTF-8'));

		$clientMock = $this->getMock('OCP\Http\Client\IClient');
		$clientMock->expects($this->exactly(2))
			->method('get')
			->will($this->returnCallback(function ($page) use($amazonResponse, $golemResponse) {
				if($page === 'amazonHtml') {
					return $amazonResponse;
				} else if($page === 'golemHtml') {
					return $golemResponse;
				}
			}));

		$clientServiceMock = $this->getMock('OCP\Http\Client\IClientService');
		$clientServiceMock->expects($this->any())
			->method('newClient')
			->will($this->returnValue($clientMock));

		$this->registerHttpService($clientServiceMock);

		$metadataAmazon = Bookmarks::getURLMetadata('amazonHtml');
		$this->assertTrue($metadataAmazon['url'] == 'amazonHtml');
		$this->assertTrue(strpos($metadataAmazon['title'], 'ü') !== false);

		$metadataGolem = Bookmarks::getURLMetadata('golemHtml');
		$this->assertTrue($metadataGolem['url'] == 'golemHtml');
		$this->assertTrue(strpos($metadataGolem['title'], 'f&uuml;r') == false);

	}

	protected function tearDown() {
		$this->cleanDB();
	}

	function cleanDB() {

		$query1 = OC_DB::prepare('DELETE FROM *PREFIX*bookmarks');
		$query1->execute();
		$query2 = OC_DB::prepare('DELETE FROM *PREFIX*bookmarks_tags');
		$query2->execute();
	}

	/**
	 * Register an http service mock for testing purposes.
	 *
	 * @param \OCP\Http\Client\IClientService $service
	 */
	private function registerHttpService($service) {
		\OC::$server->registerService('HttpClientService', function () use ($service) {
			return $service;
		});
	}

}


1			<?php
2
3			OC_App::loadApp('bookmarks');
4
5			use \OCA\Bookmarks\Controller\Lib\Bookmarks;
6
7			class Test_LibBookmarks_Bookmarks extends PHPUnit_Framework_TestCase {
8
9			private $userid;
10			private $db;
11
12			protected function setUp() {
13			$this->userid = \OCP\User::getUser();
14			$this->db = \OC::$server->getDb();
15			}
16
17			function testAddBookmark() {
			0 ignored issues – show Best Practice introduced 2015-12-06 07:12 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
18			$this->cleanDB();
19			$this->assertCount(0, Bookmarks::findBookmarks($this->userid, $this->db, 0, 'id', array(), true, -1));
20			Bookmarks::addBookmark($this->userid, $this->db, 'http://owncloud.org', 'owncloud project', array('oc', 'cloud'), 'An Awesome project');
21			$this->assertCount(1, Bookmarks::findBookmarks($this->userid, $this->db, 0, 'id', array(), true, -1));
22			Bookmarks::addBookmark($this->userid, $this->db, 'http://de.wikipedia.org/Ü', 'Das Ü', array('encyclopedia', 'lang'), 'A terrific letter');
23			$this->assertCount(2, Bookmarks::findBookmarks($this->userid, $this->db, 0, 'id', array(), true, -1));
24			}
25
26			function testFindBookmarks() {
			0 ignored issues – show Best Practice introduced 2015-12-06 07:12 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
27			$this->cleanDB();
28			Bookmarks::addBookmark($this->userid, $this->db, "http://www.google.de", "Google", array("one"), "PrivateNoTag", false);
29			Bookmarks::addBookmark($this->userid, $this->db, "http://www.heise.de", "Heise", array("one", "two"), "PrivatTag", false);
30			Bookmarks::addBookmark($this->userid, $this->db, "http://www.golem.de", "Golem", array("one"), "PublicNoTag", true);
31			Bookmarks::addBookmark($this->userid, $this->db, "http://www.9gag.com", "9gag", array("two", "three"), "PublicTag", true);
32			$outputPrivate = Bookmarks::findBookmarks($this->userid, $this->db, 0, "", array(), true, -1, false);
33			$this->assertCount(4, $outputPrivate);
34			$outputPrivateFiltered = Bookmarks::findBookmarks($this->userid, $this->db, 0, "", array("one"), true, -1, false);
35			$this->assertCount(3, $outputPrivateFiltered);
36			$outputPublic = Bookmarks::findBookmarks($this->userid, $this->db, 0, "", array(), true, -1, true);
37			$this->assertCount(2, $outputPublic);
38			$outputPublicFiltered = Bookmarks::findBookmarks($this->userid, $this->db, 0, "", array("two"), true, -1, true);
39			$this->assertCount(1, $outputPublicFiltered);
40			}
41
42			function testFindBookmarksSelectAndOrFilteredTags() {
			0 ignored issues – show Best Practice introduced 2015-12-06 07:12 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
43			$this->cleanDB();
44			$secondUser = $this->userid . "andHisClone435";
45			Bookmarks::addBookmark($this->userid, $this->db, "http://www.google.de", "Google", array("one"), "PrivateNoTag", false);
46			Bookmarks::addBookmark($this->userid, $this->db, "http://www.heise.de", "Heise", array("one", "two"), "PrivatTag", false);
47			Bookmarks::addBookmark($this->userid, $this->db, "http://www.golem.de", "Golem", array("four"), "PublicNoTag", true);
48			Bookmarks::addBookmark($this->userid, $this->db, "http://www.9gag.com", "9gag", array("two", "three"), "PublicTag", true);
49			Bookmarks::addBookmark($secondUser, $this->db, "http://www.google.de", "Google", array("one"), "PrivateNoTag", false);
50			Bookmarks::addBookmark($secondUser, $this->db, "http://www.heise.de", "Heise", array("one", "two"), "PrivatTag", false);
51			Bookmarks::addBookmark($secondUser, $this->db, "http://www.golem.de", "Golem", array("four"), "PublicNoTag", true);
52			Bookmarks::addBookmark($secondUser, $this->db, "http://www.9gag.com", "9gag", array("two", "three"), "PublicTag", true);
53			$resultSetOne = Bookmarks::findBookmarks($this->userid, $this->db, 0, 'lastmodified', array('one', 'three'), true, -1, false, array('url', 'title'), 'or');
54			$this->assertEquals(3, count($resultSetOne));
55			$resultOne = $resultSetOne[0];
56			$this->assertFalse(isset($resultOne['lastmodified']));
57			$this->assertFalse(isset($resultOne['tags']));
58			}
59
60			function testFindTags() {
			0 ignored issues – show Best Practice introduced 2015-12-06 07:12 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
61			$this->cleanDB();
62			$this->assertEquals(Bookmarks::findTags($this->userid, $this->db), array());
63			Bookmarks::addBookmark($this->userid, $this->db, 'http://owncloud.org', 'Owncloud project', array('oc', 'cloud'), 'An Awesome project');
64			$this->assertEquals(array(0 => array('tag' => 'cloud', 'nbr' => 1), 1 => array('tag' => 'oc', 'nbr' => 1)), Bookmarks::findTags($this->userid, $this->db));
65			}
66
67			function testFindUniqueBookmark() {
			0 ignored issues – show Best Practice introduced 2015-12-06 07:12 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
68			$this->cleanDB();
69			$id = Bookmarks::addBookmark($this->userid, $this->db, "http://www.heise.de", "Heise", array("one", "two"), "PrivatTag", false);
70			$bookmark = Bookmarks::findUniqueBookmark($id, $this->userid, $this->db);
71			$this->assertEquals($id, $bookmark['id']);
72			$this->assertEquals("Heise", $bookmark['title']);
73			}
74
75			function testEditBookmark() {
			0 ignored issues – show Best Practice introduced 2015-12-06 07:12 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
76			$this->cleanDB();
77			$id = Bookmarks::addBookmark($this->userid, $this->db, "http://www.heise.de", "Heise", array("one", "two"), "PrivatTag", false);
78			Bookmarks::editBookmark($this->userid, $this->db, $id, "http://www.google.de", "NewTitle", array("three"));
79			$bookmark = Bookmarks::findUniqueBookmark($id, $this->userid, $this->db);
80			$this->assertEquals("NewTitle", $bookmark['title']);
81			$this->assertEquals("http://www.google.de", $bookmark['url']);
82			$this->assertEquals(1, count($bookmark['tags']));
83			}
84
85			function testDeleteBookmark() {
			0 ignored issues – show Best Practice introduced 2015-12-06 07:12 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
86			$this->cleanDB();
87			Bookmarks::addBookmark($this->userid, $this->db, "http://www.google.de", "Google", array("one"), "PrivateNoTag", false);
88			$id = Bookmarks::addBookmark($this->userid, $this->db, "http://www.heise.de", "Heise", array("one", "two"), "PrivatTag", false);
89			$this->assertNotEquals(false, Bookmarks::bookmarkExists("http://www.google.de", $this->userid, $this->db));
90			$this->assertNotEquals(false, Bookmarks::bookmarkExists("http://www.heise.de", $this->userid, $this->db));
91			Bookmarks::deleteUrl($this->userid, $this->db, $id);
92			$this->assertFalse(Bookmarks::bookmarkExists("http://www.heise.de", $this->userid, $this->db));
93			}
94
95			function testGetURLMetadata() {
			0 ignored issues – show Best Practice introduced 2015-12-06 07:12 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
96
97			$config = $this->getMockBuilder('\OCP\IConfig')
			0 ignored issues – show Unused Code introduced 2016-04-24 20:13 UTC by Report Bug Copy Issue Report `$config` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
98			->disableOriginalConstructor()->getMock();
99			$amazonResponse = $this->getMock('OCP\Http\Client\IResponse');
100			$amazonResponse->expects($this->once())
101			->method('getBody')
102			->will($this->returnValue(file_get_contents(__DIR__ . '/res/amazonHtml.file')));
103			$amazonResponse->expects($this->once())
104			->method('getHeader')
105			->with('Content-Type')
106			->will($this->returnValue(''));
107
108			$golemResponse = $this->getMock('OCP\Http\Client\IResponse');
109			$golemResponse->expects($this->once())
110			->method('getBody')
111			->will($this->returnValue(file_get_contents(__DIR__ . '/res/golemHtml.file')));
112			$golemResponse->expects($this->once())
113			->method('getHeader')
114			->with('Content-Type')
115			->will($this->returnValue('text/html; charset=UTF-8'));
116
117			$clientMock = $this->getMock('OCP\Http\Client\IClient');
118			$clientMock->expects($this->exactly(2))
119			->method('get')
120			->will($this->returnCallback(function ($page) use($amazonResponse, $golemResponse) {
121			if($page === 'amazonHtml') {
122			return $amazonResponse;
123			} else if($page === 'golemHtml') {
124			return $golemResponse;
125			}
126			}));
127
128			$clientServiceMock = $this->getMock('OCP\Http\Client\IClientService');
129			$clientServiceMock->expects($this->any())
130			->method('newClient')
131			->will($this->returnValue($clientMock));
132
133			$this->registerHttpService($clientServiceMock);
134
135			$metadataAmazon = Bookmarks::getURLMetadata('amazonHtml');
136			$this->assertTrue($metadataAmazon['url'] == 'amazonHtml');
137			$this->assertTrue(strpos($metadataAmazon['title'], 'ü') !== false);
138
139			$metadataGolem = Bookmarks::getURLMetadata('golemHtml');
140			$this->assertTrue($metadataGolem['url'] == 'golemHtml');
141			$this->assertTrue(strpos($metadataGolem['title'], 'für') == false);
			0 ignored issues – show Bug Best Practice introduced 2015-12-06 07:12 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `strpos($metadataGolem['title'], 'für')` of type `integer` to the boolean `false`. If you are specifically checking for 0, consider using something more explicit like `=== 0` instead. Loading history...
142			}
143
144			protected function tearDown() {
145			$this->cleanDB();
146			}
147
148			function cleanDB() {
			0 ignored issues – show Best Practice introduced 2015-12-06 07:12 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
149			$query1 = OC_DB::prepare('DELETE FROM PREFIXbookmarks');
150			$query1->execute();
151			$query2 = OC_DB::prepare('DELETE FROM PREFIXbookmarks_tags');
152			$query2->execute();
153			}
154
155			/**
156			* Register an http service mock for testing purposes.
157			*
158			* @param \OCP\Http\Client\IClientService $service
159			*/
160			private function registerHttpService($service) {
161			\OC::$server->registerService('HttpClientService', function () use ($service) {
162			return $service;
163			});
164			}
165
166			}
167

owncloud / bookmarks

Test_LibBookmarks_Bookmarks::testFindBookmarks() A last analyzed 2016-09-25 18:58 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Test_LibBookmarks_Bookmarks::testFindBookmarks() A
last analyzed 2016-09-25 18:58 UTC