Test_PublicController_Bookmarks

Complexity

Total Complexity

5

Size/Duplication

Total Lines	50
Duplicated Lines	24 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	7	1
A	testPublicQueryNoUser()	6	6	1
A	testPublicQueryWrongUser()	6	6	1
A	testPublicQuery()	0	11	1
A	cleanDB()	0	6	1

<?php

OC_App::loadApp('bookmarks');

use \OCA\Bookmarks\Controller\Rest\PublicController;
use OCA\Bookmarks\Controller\Lib\Bookmarks;

class Test_PublicController_Bookmarks extends PHPUnit_Framework_TestCase {

	private $userid;
	private $request;
	private $db;
	private $userManager;
	private $publicController;

	protected function setUp() {
		$this->userid = "testuser";
		$this->request = \OC::$server->getRequest();
		$this->db = \OC::$server->getDb();
		$this->userManager = \OC::$server->getUserManager();
		$this->publicController = new PublicController("bookmarks", $this->request, $this->db, $this->userManager);
	}

	function testPublicQueryNoUser() {

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

		$output = $this->publicController->returnAsJson(null, "apassword", null);
		$data = $output->getData();
		$status = $data['status'];
		$this->assertEquals($status, 'error');
	}

	function testPublicQueryWrongUser() {

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

		$output = $this->publicController->returnAsJson("cqc43dr4rx3x4xatr4", "apassword", null);
		$data = $output->getData();
		$status = $data['status'];
		$this->assertEquals($status, 'error');
	}

	function testPublicQuery() {

It is generally recommended to explicitly declare the visibility for methods.

		Bookmarks::addBookmark($this->userid, $this->db, "http://www.golem.de", "Golem", array("four"), "PublicNoTag", true);
		Bookmarks::addBookmark($this->userid, $this->db, "http://www.9gag.com", "9gag", array("two", "three"), "PublicTag", true);

		$output = $this->publicController->returnAsJson($this->userid);
		$data = $output->getData();
		$this->assertEquals(2, count($data));
		
		$this->cleanDB();
	}

	function cleanDB() {

It is generally recommended to explicitly declare the visibility for methods.

		$query1 = OC_DB::prepare('DELETE FROM *PREFIX*bookmarks');
		$query1->execute();
		$query2 = OC_DB::prepare('DELETE FROM *PREFIX*bookmarks_tags');
		$query2->execute();
	}

}