Application - Code Metrics - Inspection of "Allow OCA.Activity.Plugins to help rendering activ..." - owncloud/activity - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#518)

by Joas

created 2016-05-03 09:55 UTC

Application A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	222
Duplicated Lines	14.86 %

Coupling/Cohesion

Components	0
Dependencies	15

Test Coverage

Coverage

100%

Importance

Changes	12
Bugs	0	Features	3

Metric	Value
wmc	3
c	12
b	0
f	3
lcom	0
cbo	15
dl	33
loc	222
ccs	120
cts	120
cp	1
rs	9.1666

1 Method

Rating	Name	Duplication	Size	Complexity
B	__construct()	33	220	3

How to fix Duplicated Code

<?php
/**
 * @author Joas Schilling <[email protected]>
 *
 * @copyright Copyright (c) 2016, ownCloud, Inc.
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */

namespace OCA\Activity\AppInfo;

use OC\Files\View;
use OCA\Activity\Consumer;
use OCA\Activity\Controller\Activities;
use OCA\Activity\Controller\EndPoint;
use OCA\Activity\Controller\Feed;
use OCA\Activity\Controller\OCSEndPoint;
use OCA\Activity\Controller\Settings;
use OCA\Activity\Data;
use OCA\Activity\DataHelper;
use OCA\Activity\GroupHelper;
use OCA\Activity\FilesHooks;
use OCA\Activity\MailQueueHandler;
use OCA\Activity\Navigation;
use OCA\Activity\Parameter\Factory;
use OCA\Activity\UserSettings;
use OCA\Activity\ViewInfoCache;
use OCP\AppFramework\App;
use OCP\IContainer;

class Application extends App {
	public function __construct (array $urlParams = array()) {
		parent::__construct('activity', $urlParams);
		$container = $this->getContainer();

		/**
		 * Activity Services
		 */
		$container->registerService('ActivityData', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');
			return new Data(
				$server->getActivityManager(),
				$server->getDatabaseConnection(),
				$server->getUserSession()
			);
		});

		$container->registerService('ActivityL10N', function(IContainer $c) {
			return $c->query('ServerContainer')->getL10N('activity');
		});


		$container->registerService('Consumer', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new Consumer(
				$c->query('ActivityData'),
				$c->query('UserSettings'),
				$server->getL10NFactory()
			);
		});

		$container->registerService('DataHelper', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');
			return new DataHelper(
				$server->getActivityManager(),
				new Factory(
					$server->getActivityManager(),
					$server->getUserManager(),
					$server->getURLGenerator(),
					$server->getContactsManager(),
					$c->query('OCA\Activity\ViewInfoCache'),
					$c->query('ActivityL10N'),
					$c->query('CurrentUID')
				),
				$server->getL10NFactory(),
				$c->query('ActivityL10N')
			);
		});

		$container->registerService('GroupHelper', function(IContainer $c) {
			return new GroupHelper(
				$c->query('ServerContainer')->getActivityManager(),
				$c->query('DataHelper'),
				true
			);
		});

		$container->registerService('GroupHelperSingleEntries', function(IContainer $c) {
			return new GroupHelper(
				$c->query('ServerContainer')->getActivityManager(),
				$c->query('DataHelper'),
				false
			);
		});

		$container->registerService('Hooks', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new FilesHooks(
				$server->getActivityManager(),
				$c->query('ActivityData'),
				$c->query('UserSettings'),
				$server->getGroupManager(),
				new View(''),
				$server->getDatabaseConnection(),
				$server->getURLGenerator(),
				$c->query('CurrentUID')
			);
		});

		$container->registerService('MailQueueHandler', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new MailQueueHandler(
				$server->getDateTimeFormatter(),
				$server->getDatabaseConnection(),
				$c->query('DataHelper'),
				$server->getMailer(),
				$server->getURLGenerator(),
				$server->getUserManager(),
				$server->getActivityManager()
			);
		});

		$container->registerService('Navigation', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');
			$rssToken = ($c->query('CurrentUID') !== '') ? $server->getConfig()->getUserValue($c->query('CurrentUID'), 'activity', 'rsstoken') : '';

			return new Navigation(
				$c->query('ActivityL10N'),
				$server->getActivityManager(),
				$server->getURLGenerator(),
				$c->query('CurrentUID'),
				$rssToken
			);
		});

		$container->registerService('UserSettings', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');
			return new UserSettings(
				$server->getActivityManager(),
				$server->getConfig(),
				$c->query('ActivityData')
			);
		});

		$container->registerService('OCA\Activity\ViewInfoCache', function() {
			return new ViewInfoCache(
				new View('')
			);
		});

		/**
		 * Core Services
		 */
		$container->registerService('CurrentUID', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			$user = $server->getUserSession()->getUser();
			return ($user) ? $user->getUID() : '';
		});

		/**
		 * Controller
		 */
		$container->registerService('SettingsController', function(IContainer $c) {

			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new Settings(
				$c->query('AppName'),
				$server->getRequest(),
				$server->getConfig(),
				$server->getSecureRandom()->getMediumStrengthGenerator(),
				$server->getURLGenerator(),
				$c->query('ActivityData'),
				$c->query('UserSettings'),
				$c->query('ActivityL10N'),
				$c->query('CurrentUID')
			);
		});

		$container->registerService('OCA\Activity\Controller\OCSEndPoint', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new OCSEndPoint(
				$c->query('ActivityData'),
				$c->query('GroupHelper'),
				$c->query('UserSettings'),
				$server->getRequest(),
				$server->getURLGenerator(),
				$server->getUserSession(),
				$server->getPreviewManager(),
				$server->getMimeTypeDetector(),
				new View(''),
				$c->query('OCA\Activity\ViewInfoCache')
			);
		});

		$container->registerService('EndPointController', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new EndPoint(
				$c->query('AppName'),
				$server->getRequest(),
				$c->query('OCA\Activity\Controller\OCSEndPoint')
			);
		});

		$container->registerService('ActivitiesController', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new Activities(
				$c->query('AppName'),
				$server->getRequest(),
				$server->getConfig(),
				$c->query('ActivityData'),
				$c->query('Navigation')
			);
		});

		$container->registerService('FeedController', function(IContainer $c) {

			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new Feed(
				$c->query('AppName'),
				$server->getRequest(),
				$c->query('ActivityData'),
				$c->query('GroupHelperSingleEntries'),
				$c->query('UserSettings'),
				$server->getURLGenerator(),
				$server->getActivityManager(),
				$server->getL10NFactory(),
				$server->getConfig(),
				$c->query('CurrentUID')
			);
		});
	}
}


1			<?php
2			/**
3			* @author Joas Schilling <[email protected]>
4			*
5			* @copyright Copyright (c) 2016, ownCloud, Inc.
6			* @license AGPL-3.0
7			*
8			* This code is free software: you can redistribute it and/or modify
9			* it under the terms of the GNU Affero General Public License, version 3,
10			* as published by the Free Software Foundation.
11			*
12			* This program is distributed in the hope that it will be useful,
13			* but WITHOUT ANY WARRANTY; without even the implied warranty of
14			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15			* GNU Affero General Public License for more details.
16			*
17			* You should have received a copy of the GNU Affero General Public License, version 3,
18			* along with this program. If not, see <http://www.gnu.org/licenses/>
19			*
20			*/
21
22			namespace OCA\Activity\AppInfo;
23
24			use OC\Files\View;
25			use OCA\Activity\Consumer;
26			use OCA\Activity\Controller\Activities;
27			use OCA\Activity\Controller\EndPoint;
28			use OCA\Activity\Controller\Feed;
29			use OCA\Activity\Controller\OCSEndPoint;
30			use OCA\Activity\Controller\Settings;
31			use OCA\Activity\Data;
32			use OCA\Activity\DataHelper;
33			use OCA\Activity\GroupHelper;
34			use OCA\Activity\FilesHooks;
35			use OCA\Activity\MailQueueHandler;
36			use OCA\Activity\Navigation;
37			use OCA\Activity\Parameter\Factory;
38			use OCA\Activity\UserSettings;
39			use OCA\Activity\ViewInfoCache;
40			use OCP\AppFramework\App;
41			use OCP\IContainer;
42
43			class Application extends App {
44	26		public function __construct (array $urlParams = array()) {
45	26		parent::__construct('activity', $urlParams);
46	26		$container = $this->getContainer();
47
48			/**
49			* Activity Services
50			*/
51			$container->registerService('ActivityData', function(IContainer $c) {
52			/** @var \OC\Server $server */
53	17		$server = $c->query('ServerContainer');
54	17		return new Data(
55	17		$server->getActivityManager(),
56	17		$server->getDatabaseConnection(),
57	17		$server->getUserSession()
58			);
59	26		});
60
61			$container->registerService('ActivityL10N', function(IContainer $c) {
62	16		return $c->query('ServerContainer')->getL10N('activity');
63	26		});
64
65
66			$container->registerService('Consumer', function(IContainer $c) {
67			/** @var \OC\Server $server */
68	2		$server = $c->query('ServerContainer');
69
70	2		return new Consumer(
71	2		$c->query('ActivityData'),
72	2		$c->query('UserSettings'),
73	2		$server->getL10NFactory()
74			);
75	26		});
76
77			$container->registerService('DataHelper', function(IContainer $c) {
78			/** @var \OC\Server $server */
79	10		$server = $c->query('ServerContainer');
80	10		return new DataHelper(
81	10		$server->getActivityManager(),
82	10		new Factory(
83	10		$server->getActivityManager(),
84	10		$server->getUserManager(),
85	10		$server->getURLGenerator(),
86	10		$server->getContactsManager(),
87	10		$c->query('OCA\Activity\ViewInfoCache'),
88	10		$c->query('ActivityL10N'),
89	10		$c->query('CurrentUID')
90			),
91	10		$server->getL10NFactory(),
92	10		$c->query('ActivityL10N')
93			);
94	26		});
95
96			$container->registerService('GroupHelper', function(IContainer $c) {
97	6		return new GroupHelper(
98	6		$c->query('ServerContainer')->getActivityManager(),
99	6		$c->query('DataHelper'),
100	6		true
101			);
102	26		});
103
104			$container->registerService('GroupHelperSingleEntries', function(IContainer $c) {
105	1		return new GroupHelper(
106	1		$c->query('ServerContainer')->getActivityManager(),
107	1		$c->query('DataHelper'),
108	1		false
109			);
110	26		});
111
112			$container->registerService('Hooks', function(IContainer $c) {
113			/** @var \OC\Server $server */
114	1		$server = $c->query('ServerContainer');
115
116	1		return new FilesHooks(
117	1		$server->getActivityManager(),
118	1		$c->query('ActivityData'),
119	1		$c->query('UserSettings'),
120	1		$server->getGroupManager(),
121	1		new View(''),
122	1		$server->getDatabaseConnection(),
123	1		$server->getURLGenerator(),
124	1		$c->query('CurrentUID')
125			);
126	26		});
127
128			$container->registerService('MailQueueHandler', function(IContainer $c) {
129			/** @var \OC\Server $server */
130	2		$server = $c->query('ServerContainer');
131
132	2		return new MailQueueHandler(
133	2		$server->getDateTimeFormatter(),
134	2		$server->getDatabaseConnection(),
135	2		$c->query('DataHelper'),
136	2		$server->getMailer(),
137	2		$server->getURLGenerator(),
138	2		$server->getUserManager(),
139	2		$server->getActivityManager()
140			);
141	26		});
142
143			$container->registerService('Navigation', function(IContainer $c) {
144			/** @var \OC\Server $server */
145	2		$server = $c->query('ServerContainer');
146	2		$rssToken = ($c->query('CurrentUID') !== '') ? $server->getConfig()->getUserValue($c->query('CurrentUID'), 'activity', 'rsstoken') : '';
147
148	2		return new Navigation(
149	2		$c->query('ActivityL10N'),
150	2		$server->getActivityManager(),
151	2		$server->getURLGenerator(),
152	2		$c->query('CurrentUID'),
153			$rssToken
154			);
155	26		});
156
157			$container->registerService('UserSettings', function(IContainer $c) {
158			/** @var \OC\Server $server */
159	12		$server = $c->query('ServerContainer');
160	12		return new UserSettings(
161	12		$server->getActivityManager(),
162	12		$server->getConfig(),
163	12		$c->query('ActivityData')
164			);
165	26		});
166
167			$container->registerService('OCA\Activity\ViewInfoCache', function() {
168	11		return new ViewInfoCache(
169	11		new View('')
170			);
171	26		});
172
173			/**
174			* Core Services
175			*/
176			$container->registerService('CurrentUID', function(IContainer $c) {
177			/** @var \OC\Server $server */
178	15		$server = $c->query('ServerContainer');
179
180	15		$user = $server->getUserSession()->getUser();
181	15		return ($user) ? $user->getUID() : '';
182	26		});
183
184			/**
185			* Controller
186			*/
187		View Code Duplication	$container->registerService('SettingsController', function(IContainer $c) {
			0 ignored issues – show Duplication introduced 2015-11-21 07:27 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
188			/** @var \OC\Server $server */
189	2		$server = $c->query('ServerContainer');
190
191	2		return new Settings(
192	2		$c->query('AppName'),
193	2		$server->getRequest(),
194	2		$server->getConfig(),
195	2		$server->getSecureRandom()->getMediumStrengthGenerator(),
196	2		$server->getURLGenerator(),
197	2		$c->query('ActivityData'),
198	2		$c->query('UserSettings'),
199	2		$c->query('ActivityL10N'),
200	2		$c->query('CurrentUID')
201			);
202	26		});
203
204			$container->registerService('OCA\Activity\Controller\OCSEndPoint', function(IContainer $c) {
205			/** @var \OC\Server $server */
206			$server = $c->query('ServerContainer');
207
208			return new OCSEndPoint(
209			$c->query('ActivityData'),
210			$c->query('GroupHelper'),
211			$c->query('UserSettings'),
212			$server->getRequest(),
213			$server->getURLGenerator(),
214			$server->getUserSession(),
215			$server->getPreviewManager(),
216			$server->getMimeTypeDetector(),
217			new View(''),
218			$c->query('OCA\Activity\ViewInfoCache')
219			);
220	26		});
221
222			$container->registerService('EndPointController', function(IContainer $c) {
223			/** @var \OC\Server $server */
224			$server = $c->query('ServerContainer');
225
226			return new EndPoint(
227			$c->query('AppName'),
228			$server->getRequest(),
229			$c->query('OCA\Activity\Controller\OCSEndPoint')
230			);
231	26		});
232
233			$container->registerService('ActivitiesController', function(IContainer $c) {
234			/** @var \OC\Server $server */
235	1		$server = $c->query('ServerContainer');
236
237	1		return new Activities(
238	1		$c->query('AppName'),
239	1		$server->getRequest(),
240	1		$server->getConfig(),
241	1		$c->query('ActivityData'),
242	1		$c->query('Navigation')
243			);
244	26		});
245
246	26	View Code Duplication	$container->registerService('FeedController', function(IContainer $c) {
			0 ignored issues – show Duplication introduced 2015-11-21 07:27 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
247			/** @var \OC\Server $server */
248	1		$server = $c->query('ServerContainer');
249
250	1		return new Feed(
251	1		$c->query('AppName'),
252	1		$server->getRequest(),
253	1		$c->query('ActivityData'),
254	1		$c->query('GroupHelperSingleEntries'),
255	1		$c->query('UserSettings'),
256	1		$server->getURLGenerator(),
257	1		$server->getActivityManager(),
258	1		$server->getL10NFactory(),
259	1		$server->getConfig(),
260	1		$c->query('CurrentUID')
261			);
262	26		});
263	26		}
264			}
265

owncloud / activity

Pull Request — master (#518)

Application A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like