Completed
Pull Request — master (#608)
by Sujith
124:08 queued 120:08
created

Application   B

Complexity

Total Complexity 6

Size/Duplication

Total Lines 265
Duplicated Lines 20 %

Coupling/Cohesion

Components 0
Dependencies 16

Test Coverage

Coverage 76.57%

Importance

Changes 0
Metric Value
wmc 6
lcom 0
cbo 16
dl 53
loc 265
ccs 134
cts 175
cp 0.7657
rs 8.4614
c 0
b 0
f 0

4 Methods

Rating   Name   Duplication   Size   Complexity  
B __construct() 53 223 3
A registerActivityConsumer() 0 9 1
A registerHooksAndEvents() 0 9 1
A registerFilesActivity() 0 9 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
/**
3
 * @author Joas Schilling <[email protected]>
4
 *
5
 * @copyright Copyright (c) 2016, ownCloud, Inc.
6
 * @license AGPL-3.0
7
 *
8
 * This code is free software: you can redistribute it and/or modify
9
 * it under the terms of the GNU Affero General Public License, version 3,
10
 * as published by the Free Software Foundation.
11
 *
12
 * This program is distributed in the hope that it will be useful,
13
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15
 * GNU Affero General Public License for more details.
16
 *
17
 * You should have received a copy of the GNU Affero General Public License, version 3,
18
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
19
 *
20
 */
21
22
namespace OCA\Activity\AppInfo;
23
24
use OC\Files\View;
25
use OCA\Activity\Consumer;
26
use OCA\Activity\Controller\Activities;
27
use OCA\Activity\Controller\EndPoint;
28
use OCA\Activity\Controller\Feed;
29
use OCA\Activity\Controller\OCSEndPoint;
30
use OCA\Activity\Controller\Settings;
31
use OCA\Activity\Data;
32
use OCA\Activity\DataHelper;
33
use OCA\Activity\GroupHelper;
34
use OCA\Activity\FilesHooks;
35
use OCA\Activity\Hooks;
36
use OCA\Activity\MailQueueHandler;
37
use OCA\Activity\Navigation;
38
use OCA\Activity\Parameter\Factory;
39
use OCA\Activity\UserSettings;
40
use OCA\Activity\ViewInfoCache;
41
use OCP\AppFramework\App;
42
use OCP\AppFramework\IAppContainer;
43
use OCP\IContainer;
44
use OCP\Util;
45
46
class Application extends App {
47 30
	public function __construct (array $urlParams = array()) {
48 30
		parent::__construct('activity', $urlParams);
49 30
		$container = $this->getContainer();
50
51
		/**
52
		 * Activity Services
53
		 */
54
		$container->registerService('ActivityData', function(IContainer $c) {
55
			/** @var \OC\Server $server */
56 22
			$server = $c->query('ServerContainer');
57 22
			return new Data(
58 22
				$server->getActivityManager(),
59 22
				$server->getDatabaseConnection(),
60 22
				$server->getUserSession()
61 22
			);
62 30
		});
63
64
		$container->registerService('Consumer', function(IContainer $c) {
65
			/** @var \OC\Server $server */
66 2
			$server = $c->query('ServerContainer');
67
68 2
			return new Consumer(
69 2
				$c->query('ActivityData'),
70 2
				$c->query('UserSettings'),
71 2
				$server->getL10NFactory()
72 2
			);
73 30
		});
74
75 View Code Duplication
		$container->registerService('DataHelper', function(IContainer $c) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
76
			/** @var \OC\Server $server */
77 10
			$server = $c->query('ServerContainer');
78 10
			return new DataHelper(
79 10
				$server->getActivityManager(),
80 10
				new Factory(
81 10
					$server->getActivityManager(),
82 10
					$server->getUserManager(),
83 10
					$server->getURLGenerator(),
84 10
					$server->getContactsManager(),
85 10
					$c->query('OCA\Activity\ViewInfoCache'),
86 10
					$c->query('OCP\IL10N'),
87 10
					$server->getGroupManager(),
88 10
					$c->query('CurrentUID')
89 10
				),
90 10
				$server->getL10NFactory(),
91 10
				$c->query('OCP\IL10N')
92 10
			);
93 30
		});
94
95
		$container->registerService('GroupHelper', function(IContainer $c) {
96 6
			return new GroupHelper(
97 6
				$c->query('ServerContainer')->getActivityManager(),
98 6
				$c->query('DataHelper'),
99
				true
100 6
			);
101 30
		});
102
103
		$container->registerService('GroupHelperSingleEntries', function(IContainer $c) {
104 1
			return new GroupHelper(
105 1
				$c->query('ServerContainer')->getActivityManager(),
106 1
				$c->query('DataHelper'),
107
				false
108 1
			);
109 30
		});
110
111
		$container->registerService('Hooks', function(IContainer $c) {
112
			/** @var \OC\Server $server */
113 1
			$server = $c->query('ServerContainer');
114
115 1
			return new FilesHooks(
116 1
				$server->getActivityManager(),
117 1
				$c->query('ActivityData'),
118 1
				$c->query('UserSettings'),
119 1
				$server->getGroupManager(),
120 1
				new View(''),
121 1
				$server->getDatabaseConnection(),
122 1
				$server->getURLGenerator(),
123 1
				$c->query('CurrentUID')
124 1
			);
125 30
		});
126
127
		$container->registerService('MailQueueHandler', function(IContainer $c) {
128
			/** @var \OC\Server $server */
129 2
			$server = $c->query('ServerContainer');
130
131 2
			return new MailQueueHandler(
132 2
				$server->getDateTimeFormatter(),
133 2
				$server->getDatabaseConnection(),
134 2
				$c->query('DataHelper'),
135 2
				$server->getMailer(),
136 2
				$server->getURLGenerator(),
137 2
				$server->getUserManager(),
138 2
				$server->getActivityManager()
139 2
			);
140 30
		});
141
142
		$container->registerService('Navigation', function(IContainer $c) {
143
			/** @var \OC\Server $server */
144 30
			$server = $c->query('ServerContainer');
145 2
			$rssToken = ($c->query('CurrentUID') !== '') ? $server->getConfig()->getUserValue($c->query('CurrentUID'), 'activity', 'rsstoken') : '';
146
147 2
			return new Navigation(
148 2
				$c->query('OCP\IL10N'),
149 2
				$server->getActivityManager(),
150 2
				$server->getURLGenerator(),
151 2
				$c->query('CurrentUID'),
152
				$rssToken
153 2
			);
154 30
		});
155
156
		$container->registerService('UserSettings', function(IContainer $c) {
157
			/** @var \OC\Server $server */
158 11
			$server = $c->query('ServerContainer');
159 11
			return new UserSettings(
160 11
				$server->getActivityManager(),
161 11
				$server->getConfig(),
162 11
				$c->query('ActivityData')
163 11
			);
164 30
		});
165
166
		$container->registerService('OCA\Activity\ViewInfoCache', function() {
167 11
			return new ViewInfoCache(
168 11
				new View('')
169 11
			);
170 30
		});
171
172
		/**
173
		 * Core Services
174
		 */
175
		$container->registerService('CurrentUID', function(IContainer $c) {
176
			/** @var \OC\Server $server */
177 13
			$server = $c->query('ServerContainer');
178
179 13
			$user = $server->getUserSession()->getUser();
180 13
			return ($user) ? $user->getUID() : '';
181 30
		});
182
		$container->registerService('CurrentUser', function(IContainer $c) {
183
			/** @var \OC\Server $server */
184 1
			$server = $c->query('ServerContainer');
185
186 1
			$user = $server->getUserSession()->getUser();
187 1
			return $user;
188 30
		});
189
190
		/**
191
		 * Controller
192
		 */
193
		$container->registerService('SettingsController', function(IAppContainer $c) {
194
			/** @var \OC\Server $server */
195 1
			$server = $c->query('ServerContainer');
196
197 1
			return new Settings(
198 1
				$c->getAppName(),
199 1
				$server->getRequest(),
200 1
				$server->getConfig(),
201 1
				$server->getSecureRandom(),
202 1
				$server->getURLGenerator(),
203 1
				$c->query('ActivityData'),
204 1
				$c->query('UserSettings'),
205 1
				$c->query('OCP\IL10N'),
206 1
				$c->query('CurrentUser')
207 1
			);
208 30
		});
209
210 View Code Duplication
		$container->registerService('OCA\Activity\Controller\OCSEndPoint', function(IAppContainer $c) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
211
			/** @var \OC\Server $server */
212
			$server = $c->query('ServerContainer');
213
214
			return new OCSEndPoint(
215
				$c->query('ActivityData'),
216
				$c->query('GroupHelper'),
217
				$c->query('UserSettings'),
218
				$server->getRequest(),
219
				$server->getURLGenerator(),
220
				$server->getUserSession(),
221
				$server->getPreviewManager(),
222
				$server->getMimeTypeDetector(),
223
				new View(''),
224
				$c->query('OCA\Activity\ViewInfoCache')
225
			);
226 30
		});
227
228
		$container->registerService('EndPointController', function(IAppContainer $c) {
229
			/** @var \OC\Server $server */
230
			$server = $c->query('ServerContainer');
231
232
			return new EndPoint(
233
				$c->getAppName(),
234
				$server->getRequest(),
235
				$c->query('OCA\Activity\Controller\OCSEndPoint')
236
			);
237 30
		});
238
239
		$container->registerService('ActivitiesController', function(IAppContainer $c) {
240
			/** @var \OC\Server $server */
241 1
			$server = $c->query('ServerContainer');
242
243 1
			return new Activities(
244 1
				$c->getAppName(),
245 1
				$server->getRequest(),
246 1
				$server->getConfig(),
247 1
				$c->query('ActivityData'),
248 1
				$c->query('Navigation')
249 1
			);
250 30
		});
251
252 View Code Duplication
		$container->registerService('FeedController', function(IAppContainer $c) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
253
			/** @var \OC\Server $server */
254 1
			$server = $c->query('ServerContainer');
255
256 1
			return new Feed(
257 1
				$c->getAppName(),
258 1
				$server->getRequest(),
259 1
				$c->query('ActivityData'),
260 1
				$c->query('GroupHelperSingleEntries'),
261 1
				$c->query('UserSettings'),
262 1
				$server->getURLGenerator(),
263 1
				$server->getActivityManager(),
264 1
				$server->getL10NFactory(),
265 1
				$server->getConfig(),
266 1
				$c->query('CurrentUID')
267 1
			);
268 30
		});
269 30
	}
270
271
	/**
272
	 * Registers the consumer to the Activity Manager
273
	 */
274
	public function registerActivityConsumer() {
275
		$c = $this->getContainer();
276
		/** @var \OCP\IServerContainer $server */
277
		$server = $c->getServer();
278
279
		$server->getActivityManager()->registerConsumer(function() use ($c) {
280
			return $c->query('Consumer');
281
		});
282
	}
283
284
	/**
285
	 * Register the hooks and events
286
	 */
287
	public function registerHooksAndEvents() {
288
		$eventDispatcher = $this->getContainer()->getServer()->getEventDispatcher();
289
		$eventDispatcher->addListener('OCA\Files::loadAdditionalScripts', ['OCA\Activity\FilesHooksStatic', 'onLoadFilesAppScripts']);
290
291
		$activityHook = new Hooks();
292
		$eventDispatcher->addListener('user.afterdelete', [$activityHook, 'deleteUser']);
293
294
		$this->registerFilesActivity();
295
	}
296
297
	/**
298
	 * Register the hooks for filesystem operations
299
	 */
300
	public function registerFilesActivity() {
301
		// All other events from other apps have to be send via the Consumer
302
		Util::connectHook('OC_Filesystem', 'post_create', 'OCA\Activity\FilesHooksStatic', 'fileCreate');
303
		Util::connectHook('OC_Filesystem', 'post_update', 'OCA\Activity\FilesHooksStatic', 'fileUpdate');
304
		Util::connectHook('OC_Filesystem', 'delete', 'OCA\Activity\FilesHooksStatic', 'fileDelete');
305
		Util::connectHook('\OCA\Files_Trashbin\Trashbin', 'post_restore', 'OCA\Activity\FilesHooksStatic', 'fileRestore');
306
		Util::connectHook('OCP\Share', 'post_shared', 'OCA\Activity\FilesHooksStatic', 'share');
307
		Util::connectHook('OCP\Share', 'pre_unshare', 'OCA\Activity\FilesHooksStatic', 'unShare');
308
	}
309
310
}
311