Application::__construct() - Code Metrics - Inspection of "Merge pull request #525 from janklostermann/patch-..." - owncloud/activity - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bf92ba...e6e329 )

by Joas

created 2016-06-07 09:00 UTC

Application::__construct() B

↳ Parent: Application

Complexity

Conditions	3
Paths	1

Size

Total Lines	215
Code Lines	134

Duplication

Lines	50
Ratio	23.26 %

Code Coverage

Tests	117
CRAP Score	3

Importance

Changes	12
Bugs	0	Features	1

Metric	Value
c	12
b	0
f	1
dl	50
loc	215
ccs	117
cts	117
cp	1
rs	8.2857
cc	3
eloc	134
nc	1
nop	1
crap	3

How to fix Long Method

<?php
/**
 * @author Joas Schilling <[email protected]>
 *
 * @copyright Copyright (c) 2016, ownCloud, Inc.
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */

namespace OCA\Activity\AppInfo;

use OC\Files\View;
use OCA\Activity\Consumer;
use OCA\Activity\Controller\Activities;
use OCA\Activity\Controller\EndPoint;
use OCA\Activity\Controller\Feed;
use OCA\Activity\Controller\OCSEndPoint;
use OCA\Activity\Controller\Settings;
use OCA\Activity\Data;
use OCA\Activity\DataHelper;
use OCA\Activity\GroupHelper;
use OCA\Activity\FilesHooks;
use OCA\Activity\MailQueueHandler;
use OCA\Activity\Navigation;
use OCA\Activity\Parameter\Factory;
use OCA\Activity\UserSettings;
use OCA\Activity\ViewInfoCache;
use OCP\AppFramework\App;
use OCP\AppFramework\IAppContainer;
use OCP\IContainer;
use OCP\Util;

class Application extends App {
	public function __construct (array $urlParams = array()) {
		parent::__construct('activity', $urlParams);
		$container = $this->getContainer();

		/**
		 * Activity Services
		 */
		$container->registerService('ActivityData', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');
			return new Data(
				$server->getActivityManager(),
				$server->getDatabaseConnection(),
				$server->getUserSession()
			);
		});

		$container->registerService('Consumer', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new Consumer(
				$c->query('ActivityData'),
				$c->query('UserSettings'),
				$server->getL10NFactory()
			);
		});

		$container->registerService('DataHelper', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');
			return new DataHelper(
				$server->getActivityManager(),
				new Factory(
					$server->getActivityManager(),
					$server->getUserManager(),
					$server->getURLGenerator(),
					$server->getContactsManager(),
					$c->query('OCA\Activity\ViewInfoCache'),
					$c->query('OCP\IL10N'),
					$c->query('CurrentUID')
				),
				$server->getL10NFactory(),
				$c->query('OCP\IL10N')
			);
		});

		$container->registerService('GroupHelper', function(IContainer $c) {
			return new GroupHelper(
				$c->query('ServerContainer')->getActivityManager(),
				$c->query('DataHelper'),
				true
			);
		});

		$container->registerService('GroupHelperSingleEntries', function(IContainer $c) {
			return new GroupHelper(
				$c->query('ServerContainer')->getActivityManager(),
				$c->query('DataHelper'),
				false
			);
		});

		$container->registerService('Hooks', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new FilesHooks(
				$server->getActivityManager(),
				$c->query('ActivityData'),
				$c->query('UserSettings'),
				$server->getGroupManager(),
				new View(''),
				$server->getDatabaseConnection(),
				$server->getURLGenerator(),
				$c->query('CurrentUID')
			);
		});

		$container->registerService('MailQueueHandler', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new MailQueueHandler(
				$server->getDateTimeFormatter(),
				$server->getDatabaseConnection(),
				$c->query('DataHelper'),
				$server->getMailer(),
				$server->getURLGenerator(),
				$server->getUserManager(),
				$server->getActivityManager()
			);
		});

		$container->registerService('Navigation', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');
			$rssToken = ($c->query('CurrentUID') !== '') ? $server->getConfig()->getUserValue($c->query('CurrentUID'), 'activity', 'rsstoken') : '';

			return new Navigation(
				$c->query('OCP\IL10N'),
				$server->getActivityManager(),
				$server->getURLGenerator(),
				$c->query('CurrentUID'),
				$rssToken
			);
		});

		$container->registerService('UserSettings', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');
			return new UserSettings(
				$server->getActivityManager(),
				$server->getConfig(),
				$c->query('ActivityData')
			);
		});

		$container->registerService('OCA\Activity\ViewInfoCache', function() {
			return new ViewInfoCache(
				new View('')
			);
		});

		/**
		 * Core Services
		 */
		$container->registerService('CurrentUID', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			$user = $server->getUserSession()->getUser();
			return ($user) ? $user->getUID() : '';
		});

		/**
		 * Controller
		 */
		$container->registerService('SettingsController', function(IAppContainer $c) {

			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new Settings(
				$c->getAppName(),
				$server->getRequest(),
				$server->getConfig(),
				$server->getSecureRandom()->getMediumStrengthGenerator(),
				$server->getURLGenerator(),
				$c->query('ActivityData'),
				$c->query('UserSettings'),
				$c->query('OCP\IL10N'),
				$c->query('CurrentUID')
			);
		});

		$container->registerService('OCA\Activity\Controller\OCSEndPoint', function(IAppContainer $c) {

			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new OCSEndPoint(
				$c->query('ActivityData'),
				$c->query('GroupHelper'),
				$c->query('UserSettings'),
				$server->getRequest(),
				$server->getURLGenerator(),
				$server->getUserSession(),
				$server->getPreviewManager(),
				$server->getMimeTypeDetector(),
				new View(''),
				$c->query('OCA\Activity\ViewInfoCache')
			);
		});

		$container->registerService('EndPointController', function(IAppContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new EndPoint(
				$c->getAppName(),
				$server->getRequest(),
				$c->query('OCA\Activity\Controller\OCSEndPoint')
			);
		});

		$container->registerService('ActivitiesController', function(IAppContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new Activities(
				$c->getAppName(),
				$server->getRequest(),
				$server->getConfig(),
				$c->query('ActivityData'),
				$c->query('Navigation')
			);
		});

		$container->registerService('FeedController', function(IAppContainer $c) {

			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new Feed(
				$c->getAppName(),
				$server->getRequest(),
				$c->query('ActivityData'),
				$c->query('GroupHelperSingleEntries'),
				$c->query('UserSettings'),
				$server->getURLGenerator(),
				$server->getActivityManager(),
				$server->getL10NFactory(),
				$server->getConfig(),
				$c->query('CurrentUID')
			);
		});
	}

	/**
	 * Register the navigation entry
	 */
	public function registerNavigationEntry() {
		$c = $this->getContainer();
		/** @var \OCP\IServerContainer $server */
		$server = $c->getServer();

		$navigationEntry = function () use ($c, $server) {
			return [
				'id' => $c->getAppName(),
				'order' => 1,
				'name' => $c->query('OCP\IL10N')->t('Activity'),
				'href' => $server->getURLGenerator()->linkToRoute('activity.Activities.showList'),
				'icon' => $server->getURLGenerator()->imagePath($c->getAppName(), 'activity.svg'),
			];
		};
		$server->getNavigationManager()->add($navigationEntry);
	}

	/**
	 * Registers the consumer to the Activity Manager
	 */
	public function registerActivityConsumer() {
		$c = $this->getContainer();
		/** @var \OCP\IServerContainer $server */
		$server = $c->getServer();

		$server->getActivityManager()->registerConsumer(function() use ($c) {
			return $c->query('Consumer');
		});
	}

	/**
	 * Register the hooks and events
	 */
	public function registerHooksAndEvents() {
		$eventDispatcher = $this->getContainer()->getServer()->getEventDispatcher();
		$eventDispatcher->addListener('OCA\Files::loadAdditionalScripts', ['OCA\Activity\FilesHooksStatic', 'onLoadFilesAppScripts']);

		Util::connectHook('OC_User', 'post_deleteUser', 'OCA\Activity\Hooks', 'deleteUser');

		$this->registerFilesActivity();
	}

	/**
	 * Register the hooks for filesystem operations
	 */
	public function registerFilesActivity() {
		// All other events from other apps have to be send via the Consumer
		Util::connectHook('OC_Filesystem', 'post_create', 'OCA\Activity\FilesHooksStatic', 'fileCreate');
		Util::connectHook('OC_Filesystem', 'post_update', 'OCA\Activity\FilesHooksStatic', 'fileUpdate');
		Util::connectHook('OC_Filesystem', 'delete', 'OCA\Activity\FilesHooksStatic', 'fileDelete');
		Util::connectHook('\OCA\Files_Trashbin\Trashbin', 'post_restore', 'OCA\Activity\FilesHooksStatic', 'fileRestore');
		Util::connectHook('OCP\Share', 'post_shared', 'OCA\Activity\FilesHooksStatic', 'share');
		Util::connectHook('OCP\Share', 'pre_unshare', 'OCA\Activity\FilesHooksStatic', 'unShare');
	}

	/**
	 * Register personal settings for notifications and emails
	 */
	public function registerPersonalPage() {
		\OCP\App::registerPersonal($this->getContainer()->getAppName(), 'personal');
	}
}


1			<?php
2			/**
3			* @author Joas Schilling <[email protected]>
4			*
5			* @copyright Copyright (c) 2016, ownCloud, Inc.
6			* @license AGPL-3.0
7			*
8			* This code is free software: you can redistribute it and/or modify
9			* it under the terms of the GNU Affero General Public License, version 3,
10			* as published by the Free Software Foundation.
11			*
12			* This program is distributed in the hope that it will be useful,
13			* but WITHOUT ANY WARRANTY; without even the implied warranty of
14			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15			* GNU Affero General Public License for more details.
16			*
17			* You should have received a copy of the GNU Affero General Public License, version 3,
18			* along with this program. If not, see <http://www.gnu.org/licenses/>
19			*
20			*/
21
22			namespace OCA\Activity\AppInfo;
23
24			use OC\Files\View;
25			use OCA\Activity\Consumer;
26			use OCA\Activity\Controller\Activities;
27			use OCA\Activity\Controller\EndPoint;
28			use OCA\Activity\Controller\Feed;
29			use OCA\Activity\Controller\OCSEndPoint;
30			use OCA\Activity\Controller\Settings;
31			use OCA\Activity\Data;
32			use OCA\Activity\DataHelper;
33			use OCA\Activity\GroupHelper;
34			use OCA\Activity\FilesHooks;
35			use OCA\Activity\MailQueueHandler;
36			use OCA\Activity\Navigation;
37			use OCA\Activity\Parameter\Factory;
38			use OCA\Activity\UserSettings;
39			use OCA\Activity\ViewInfoCache;
40			use OCP\AppFramework\App;
41			use OCP\AppFramework\IAppContainer;
42			use OCP\IContainer;
43			use OCP\Util;
44
45			class Application extends App {
46	26		public function __construct (array $urlParams = array()) {
47	26		parent::__construct('activity', $urlParams);
48	26		$container = $this->getContainer();
49
50			/**
51			* Activity Services
52			*/
53			$container->registerService('ActivityData', function(IContainer $c) {
54			/** @var \OC\Server $server */
55	17		$server = $c->query('ServerContainer');
56	17		return new Data(
57	17		$server->getActivityManager(),
58	17		$server->getDatabaseConnection(),
59	17		$server->getUserSession()
60			);
61	26		});
62
63			$container->registerService('Consumer', function(IContainer $c) {
64			/** @var \OC\Server $server */
65	2		$server = $c->query('ServerContainer');
66
67	2		return new Consumer(
68	2		$c->query('ActivityData'),
69	2		$c->query('UserSettings'),
70	2		$server->getL10NFactory()
71			);
72	26		});
73
74			$container->registerService('DataHelper', function(IContainer $c) {
75			/** @var \OC\Server $server */
76	10		$server = $c->query('ServerContainer');
77	10		return new DataHelper(
78	10		$server->getActivityManager(),
79	10		new Factory(
80	10		$server->getActivityManager(),
81	10		$server->getUserManager(),
82	10		$server->getURLGenerator(),
83	10		$server->getContactsManager(),
84	10		$c->query('OCA\Activity\ViewInfoCache'),
85	10		$c->query('OCP\IL10N'),
86	10		$c->query('CurrentUID')
87			),
88	10		$server->getL10NFactory(),
89	10		$c->query('OCP\IL10N')
90			);
91	26		});
92
93			$container->registerService('GroupHelper', function(IContainer $c) {
94	6		return new GroupHelper(
95	6		$c->query('ServerContainer')->getActivityManager(),
96	6		$c->query('DataHelper'),
97	6		true
98			);
99	26		});
100
101			$container->registerService('GroupHelperSingleEntries', function(IContainer $c) {
102	1		return new GroupHelper(
103	1		$c->query('ServerContainer')->getActivityManager(),
104	1		$c->query('DataHelper'),
105	1		false
106			);
107	26		});
108
109			$container->registerService('Hooks', function(IContainer $c) {
110			/** @var \OC\Server $server */
111	1		$server = $c->query('ServerContainer');
112
113	1		return new FilesHooks(
114	1		$server->getActivityManager(),
115	1		$c->query('ActivityData'),
116	1		$c->query('UserSettings'),
117	1		$server->getGroupManager(),
118	1		new View(''),
119	1		$server->getDatabaseConnection(),
120	1		$server->getURLGenerator(),
121	1		$c->query('CurrentUID')
122			);
123	26		});
124
125			$container->registerService('MailQueueHandler', function(IContainer $c) {
126			/** @var \OC\Server $server */
127	2		$server = $c->query('ServerContainer');
128
129	2		return new MailQueueHandler(
130	2		$server->getDateTimeFormatter(),
131	2		$server->getDatabaseConnection(),
132	2		$c->query('DataHelper'),
133	2		$server->getMailer(),
134	2		$server->getURLGenerator(),
135	2		$server->getUserManager(),
136	2		$server->getActivityManager()
137			);
138	26		});
139
140			$container->registerService('Navigation', function(IContainer $c) {
141			/** @var \OC\Server $server */
142	2		$server = $c->query('ServerContainer');
143	2		$rssToken = ($c->query('CurrentUID') !== '') ? $server->getConfig()->getUserValue($c->query('CurrentUID'), 'activity', 'rsstoken') : '';
144
145	2		return new Navigation(
146	2		$c->query('OCP\IL10N'),
147	2		$server->getActivityManager(),
148	2		$server->getURLGenerator(),
149	2		$c->query('CurrentUID'),
150			$rssToken
151			);
152	26		});
153
154			$container->registerService('UserSettings', function(IContainer $c) {
155			/** @var \OC\Server $server */
156	12		$server = $c->query('ServerContainer');
157	12		return new UserSettings(
158	12		$server->getActivityManager(),
159	12		$server->getConfig(),
160	12		$c->query('ActivityData')
161			);
162	26		});
163
164			$container->registerService('OCA\Activity\ViewInfoCache', function() {
165	11		return new ViewInfoCache(
166	11		new View('')
167			);
168	26		});
169
170			/**
171			* Core Services
172			*/
173			$container->registerService('CurrentUID', function(IContainer $c) {
174			/** @var \OC\Server $server */
175	15		$server = $c->query('ServerContainer');
176
177	15		$user = $server->getUserSession()->getUser();
178	15		return ($user) ? $user->getUID() : '';
179	26		});
180
181			/**
182			* Controller
183			*/
184		View Code Duplication	$container->registerService('SettingsController', function(IAppContainer $c) {
			0 ignored issues – show Duplication introduced 2015-11-21 07:27 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
185			/** @var \OC\Server $server */
186	2		$server = $c->query('ServerContainer');
187
188	2		return new Settings(
189	2		$c->getAppName(),
190	2		$server->getRequest(),
191	2		$server->getConfig(),
192	2		$server->getSecureRandom()->getMediumStrengthGenerator(),
193	2		$server->getURLGenerator(),
194	2		$c->query('ActivityData'),
195	2		$c->query('UserSettings'),
196	2		$c->query('OCP\IL10N'),
197	2		$c->query('CurrentUID')
198			);
199	26		});
200
201		View Code Duplication	$container->registerService('OCA\Activity\Controller\OCSEndPoint', function(IAppContainer $c) {
			0 ignored issues – show Duplication introduced 2016-03-01 21:55 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
202			/** @var \OC\Server $server */
203			$server = $c->query('ServerContainer');
204
205			return new OCSEndPoint(
206			$c->query('ActivityData'),
207			$c->query('GroupHelper'),
208			$c->query('UserSettings'),
209			$server->getRequest(),
210			$server->getURLGenerator(),
211			$server->getUserSession(),
212			$server->getPreviewManager(),
213			$server->getMimeTypeDetector(),
214			new View(''),
215			$c->query('OCA\Activity\ViewInfoCache')
216			);
217	26		});
218
219			$container->registerService('EndPointController', function(IAppContainer $c) {
220			/** @var \OC\Server $server */
221			$server = $c->query('ServerContainer');
222
223			return new EndPoint(
224			$c->getAppName(),
225			$server->getRequest(),
226			$c->query('OCA\Activity\Controller\OCSEndPoint')
227			);
228	26		});
229
230			$container->registerService('ActivitiesController', function(IAppContainer $c) {
231			/** @var \OC\Server $server */
232	1		$server = $c->query('ServerContainer');
233
234	1		return new Activities(
235	1		$c->getAppName(),
236	1		$server->getRequest(),
237	1		$server->getConfig(),
238	1		$c->query('ActivityData'),
239	1		$c->query('Navigation')
240			);
241	26		});
242
243		View Code Duplication	$container->registerService('FeedController', function(IAppContainer $c) {
			0 ignored issues – show Duplication introduced 2015-11-21 07:27 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
244			/** @var \OC\Server $server */
245	1		$server = $c->query('ServerContainer');
246
247	1		return new Feed(
248	1		$c->getAppName(),
249	1		$server->getRequest(),
250	1		$c->query('ActivityData'),
251	1		$c->query('GroupHelperSingleEntries'),
252	1		$c->query('UserSettings'),
253	1		$server->getURLGenerator(),
254	1		$server->getActivityManager(),
255	1		$server->getL10NFactory(),
256	1		$server->getConfig(),
257	1		$c->query('CurrentUID')
258			);
259	26		});
260	26		}
261
262			/**
263			* Register the navigation entry
264			*/
265	1		public function registerNavigationEntry() {
266	1		$c = $this->getContainer();
267			/** @var \OCP\IServerContainer $server */
268	1		$server = $c->getServer();
269
270			$navigationEntry = function () use ($c, $server) {
271			return [
272	1		'id' => $c->getAppName(),
273	1		'order' => 1,
274	1		'name' => $c->query('OCP\IL10N')->t('Activity'),
275	1		'href' => $server->getURLGenerator()->linkToRoute('activity.Activities.showList'),
276	1		'icon' => $server->getURLGenerator()->imagePath($c->getAppName(), 'activity.svg'),
277			];
278	1		};
279	1		$server->getNavigationManager()->add($navigationEntry);
280	1		}
281
282			/**
283			* Registers the consumer to the Activity Manager
284			*/
285	1		public function registerActivityConsumer() {
286	1		$c = $this->getContainer();
287			/** @var \OCP\IServerContainer $server */
288	1		$server = $c->getServer();
289
290	1		$server->getActivityManager()->registerConsumer(function() use ($c) {
291			return $c->query('Consumer');
292	1		});
293	1		}
294
295			/**
296			* Register the hooks and events
297			*/
298	1		public function registerHooksAndEvents() {
299	1		$eventDispatcher = $this->getContainer()->getServer()->getEventDispatcher();
300	1		$eventDispatcher->addListener('OCA\Files::loadAdditionalScripts', ['OCA\Activity\FilesHooksStatic', 'onLoadFilesAppScripts']);
301
302	1		Util::connectHook('OC_User', 'post_deleteUser', 'OCA\Activity\Hooks', 'deleteUser');
303
304	1		$this->registerFilesActivity();
305	1		}
306
307			/**
308			* Register the hooks for filesystem operations
309			*/
310	1		public function registerFilesActivity() {
311			// All other events from other apps have to be send via the Consumer
312	1		Util::connectHook('OC_Filesystem', 'post_create', 'OCA\Activity\FilesHooksStatic', 'fileCreate');
313	1		Util::connectHook('OC_Filesystem', 'post_update', 'OCA\Activity\FilesHooksStatic', 'fileUpdate');
314	1		Util::connectHook('OC_Filesystem', 'delete', 'OCA\Activity\FilesHooksStatic', 'fileDelete');
315	1		Util::connectHook('\OCA\Files_Trashbin\Trashbin', 'post_restore', 'OCA\Activity\FilesHooksStatic', 'fileRestore');
316	1		Util::connectHook('OCP\Share', 'post_shared', 'OCA\Activity\FilesHooksStatic', 'share');
317	1		Util::connectHook('OCP\Share', 'pre_unshare', 'OCA\Activity\FilesHooksStatic', 'unShare');
318	1		}
319
320			/**
321			* Register personal settings for notifications and emails
322			*/
323	1		public function registerPersonalPage() {
324	1		\OCP\App::registerPersonal($this->getContainer()->getAppName(), 'personal');
325	1		}
326			}
327

owncloud / activity

Push — master ( bf92ba...e6e329 )

Application::__construct() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like