Application::__construct() - Code Metrics - Inspection of "Catch mail exceptions and still remove sent emails..." - owncloud/activity - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#574)

by Tom

created 2017-06-29 15:09 UTC

Application::__construct() B

↳ Parent: Application

Complexity

Conditions	3
Paths	1

Size

Total Lines	222
Code Lines	138

Duplication

Lines	34
Ratio	15.32 %

Code Coverage

Tests	133
CRAP Score	3.0175

Importance

Changes

Metric	Value
dl	34
loc	222
ccs	133
cts	152
cp	0.875
rs	8.2857
c	0
b	0
f	0
cc	3
eloc	138
nc	1
nop	1
crap	3.0175

How to fix Long Method

<?php
/**
 * @author Joas Schilling <[email protected]>
 *
 * @copyright Copyright (c) 2016, ownCloud, Inc.
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */

namespace OCA\Activity\AppInfo;

use OC\Files\View;
use OCA\Activity\Consumer;
use OCA\Activity\Controller\Activities;
use OCA\Activity\Controller\EndPoint;
use OCA\Activity\Controller\Feed;
use OCA\Activity\Controller\OCSEndPoint;
use OCA\Activity\Controller\Settings;
use OCA\Activity\Data;
use OCA\Activity\DataHelper;
use OCA\Activity\GroupHelper;
use OCA\Activity\FilesHooks;
use OCA\Activity\MailQueueHandler;
use OCA\Activity\Navigation;
use OCA\Activity\Parameter\Factory;
use OCA\Activity\UserSettings;
use OCA\Activity\ViewInfoCache;
use OCP\AppFramework\App;
use OCP\AppFramework\IAppContainer;
use OCP\IContainer;
use OCP\Util;

class Application extends App {
	public function __construct (array $urlParams = array()) {
		parent::__construct('activity', $urlParams);
		$container = $this->getContainer();

		/**
		 * Activity Services
		 */
		$container->registerService('ActivityData', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');
			return new Data(
				$server->getActivityManager(),
				$server->getDatabaseConnection(),
				$server->getUserSession()
			);
		});

		$container->registerService('Consumer', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new Consumer(
				$c->query('ActivityData'),
				$c->query('UserSettings'),
				$server->getL10NFactory()
			);
		});

		$container->registerService('DataHelper', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');
			return new DataHelper(
				$server->getActivityManager(),
				new Factory(
					$server->getActivityManager(),
					$server->getUserManager(),
					$server->getURLGenerator(),
					$server->getContactsManager(),
					$c->query('OCA\Activity\ViewInfoCache'),
					$c->query('OCP\IL10N'),
					$c->query('CurrentUID')
				),
				$server->getL10NFactory(),
				$c->query('OCP\IL10N')
			);
		});

		$container->registerService('GroupHelper', function(IContainer $c) {
			return new GroupHelper(
				$c->query('ServerContainer')->getActivityManager(),
				$c->query('DataHelper'),
				true
			);
		});

		$container->registerService('GroupHelperSingleEntries', function(IContainer $c) {
			return new GroupHelper(
				$c->query('ServerContainer')->getActivityManager(),
				$c->query('DataHelper'),
				false
			);
		});

		$container->registerService('Hooks', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new FilesHooks(
				$server->getActivityManager(),
				$c->query('ActivityData'),
				$c->query('UserSettings'),
				$server->getGroupManager(),
				new View(''),
				$server->getDatabaseConnection(),
				$server->getURLGenerator(),
				$c->query('CurrentUID')
			);
		});

		$container->registerService('MailQueueHandler', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new MailQueueHandler(
				$server->getDateTimeFormatter(),
				$server->getDatabaseConnection(),
				$c->query('DataHelper'),
				$server->getMailer(),
				$server->getURLGenerator(),
				$server->getUserManager(),
				$server->getActivityManager()
			);
		});

		$container->registerService('Navigation', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');
			$rssToken = ($c->query('CurrentUID') !== '') ? $server->getConfig()->getUserValue($c->query('CurrentUID'), 'activity', 'rsstoken') : '';

			return new Navigation(
				$c->query('OCP\IL10N'),
				$server->getActivityManager(),
				$server->getURLGenerator(),
				$c->query('CurrentUID'),
				$rssToken
			);
		});

		$container->registerService('UserSettings', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');
			return new UserSettings(
				$server->getActivityManager(),
				$server->getConfig(),
				$c->query('ActivityData')
			);
		});

		$container->registerService('OCA\Activity\ViewInfoCache', function() {
			return new ViewInfoCache(
				new View('')
			);
		});

		/**
		 * Core Services
		 */
		$container->registerService('CurrentUID', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			$user = $server->getUserSession()->getUser();
			return ($user) ? $user->getUID() : '';
		});
		$container->registerService('CurrentUser', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			$user = $server->getUserSession()->getUser();
			return $user;
		});

		/**
		 * Controller
		 */
		$container->registerService('SettingsController', function(IAppContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new Settings(
				$c->getAppName(),
				$server->getRequest(),
				$server->getConfig(),
				$server->getSecureRandom(),
				$server->getURLGenerator(),
				$c->query('ActivityData'),
				$c->query('UserSettings'),
				$c->query('OCP\IL10N'),
				$c->query('CurrentUser')
			);
		});

		$container->registerService('OCA\Activity\Controller\OCSEndPoint', function(IAppContainer $c) {

			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new OCSEndPoint(
				$c->query('ActivityData'),
				$c->query('GroupHelper'),
				$c->query('UserSettings'),
				$server->getRequest(),
				$server->getURLGenerator(),
				$server->getUserSession(),
				$server->getPreviewManager(),
				$server->getMimeTypeDetector(),
				new View(''),
				$c->query('OCA\Activity\ViewInfoCache')
			);
		});

		$container->registerService('EndPointController', function(IAppContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new EndPoint(
				$c->getAppName(),
				$server->getRequest(),
				$c->query('OCA\Activity\Controller\OCSEndPoint')
			);
		});

		$container->registerService('ActivitiesController', function(IAppContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new Activities(
				$c->getAppName(),
				$server->getRequest(),
				$server->getConfig(),
				$c->query('ActivityData'),
				$c->query('Navigation')
			);
		});

		$container->registerService('FeedController', function(IAppContainer $c) {

			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new Feed(
				$c->getAppName(),
				$server->getRequest(),
				$c->query('ActivityData'),
				$c->query('GroupHelperSingleEntries'),
				$c->query('UserSettings'),
				$server->getURLGenerator(),
				$server->getActivityManager(),
				$server->getL10NFactory(),
				$server->getConfig(),
				$c->query('CurrentUID')
			);
		});
	}

	/**
	 * Registers the consumer to the Activity Manager
	 */
	public function registerActivityConsumer() {
		$c = $this->getContainer();
		/** @var \OCP\IServerContainer $server */
		$server = $c->getServer();

		$server->getActivityManager()->registerConsumer(function() use ($c) {
			return $c->query('Consumer');
		});
	}

	/**
	 * Register the hooks and events
	 */
	public function registerHooksAndEvents() {
		$eventDispatcher = $this->getContainer()->getServer()->getEventDispatcher();
		$eventDispatcher->addListener('OCA\Files::loadAdditionalScripts', ['OCA\Activity\FilesHooksStatic', 'onLoadFilesAppScripts']);

		Util::connectHook('OC_User', 'post_deleteUser', 'OCA\Activity\Hooks', 'deleteUser');

		$this->registerFilesActivity();
	}

	/**
	 * Register the hooks for filesystem operations
	 */
	public function registerFilesActivity() {
		// All other events from other apps have to be send via the Consumer
		Util::connectHook('OC_Filesystem', 'post_create', 'OCA\Activity\FilesHooksStatic', 'fileCreate');
		Util::connectHook('OC_Filesystem', 'post_update', 'OCA\Activity\FilesHooksStatic', 'fileUpdate');
		Util::connectHook('OC_Filesystem', 'delete', 'OCA\Activity\FilesHooksStatic', 'fileDelete');
		Util::connectHook('\OCA\Files_Trashbin\Trashbin', 'post_restore', 'OCA\Activity\FilesHooksStatic', 'fileRestore');
		Util::connectHook('OCP\Share', 'post_shared', 'OCA\Activity\FilesHooksStatic', 'share');
		Util::connectHook('OCP\Share', 'pre_unshare', 'OCA\Activity\FilesHooksStatic', 'unShare');
	}

}


1			<?php
2			/**
3			* @author Joas Schilling <[email protected]>
4			*
5			* @copyright Copyright (c) 2016, ownCloud, Inc.
6			* @license AGPL-3.0
7			*
8			* This code is free software: you can redistribute it and/or modify
9			* it under the terms of the GNU Affero General Public License, version 3,
10			* as published by the Free Software Foundation.
11			*
12			* This program is distributed in the hope that it will be useful,
13			* but WITHOUT ANY WARRANTY; without even the implied warranty of
14			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15			* GNU Affero General Public License for more details.
16			*
17			* You should have received a copy of the GNU Affero General Public License, version 3,
18			* along with this program. If not, see <http://www.gnu.org/licenses/>
19			*
20			*/
21
22			namespace OCA\Activity\AppInfo;
23
24			use OC\Files\View;
25			use OCA\Activity\Consumer;
26			use OCA\Activity\Controller\Activities;
27			use OCA\Activity\Controller\EndPoint;
28			use OCA\Activity\Controller\Feed;
29			use OCA\Activity\Controller\OCSEndPoint;
30			use OCA\Activity\Controller\Settings;
31			use OCA\Activity\Data;
32			use OCA\Activity\DataHelper;
33			use OCA\Activity\GroupHelper;
34			use OCA\Activity\FilesHooks;
35			use OCA\Activity\MailQueueHandler;
36			use OCA\Activity\Navigation;
37			use OCA\Activity\Parameter\Factory;
38			use OCA\Activity\UserSettings;
39			use OCA\Activity\ViewInfoCache;
40			use OCP\AppFramework\App;
41			use OCP\AppFramework\IAppContainer;
42			use OCP\IContainer;
43			use OCP\Util;
44
45			class Application extends App {
46	24		public function __construct (array $urlParams = array()) {
47	24		parent::__construct('activity', $urlParams);
48	24		$container = $this->getContainer();
49
50			/**
51			* Activity Services
52			*/
53			$container->registerService('ActivityData', function(IContainer $c) {
54			/** @var \OC\Server $server */
55	16		$server = $c->query('ServerContainer');
56	16		return new Data(
57	16		$server->getActivityManager(),
58	16		$server->getDatabaseConnection(),
59	16		$server->getUserSession()
60	16		);
61	24		});
62
63			$container->registerService('Consumer', function(IContainer $c) {
64			/** @var \OC\Server $server */
65	2		$server = $c->query('ServerContainer');
66
67	2		return new Consumer(
68	2		$c->query('ActivityData'),
69	2		$c->query('UserSettings'),
70	2		$server->getL10NFactory()
71	2		);
72	24		});
73
74			$container->registerService('DataHelper', function(IContainer $c) {
75			/** @var \OC\Server $server */
76	10		$server = $c->query('ServerContainer');
77	10		return new DataHelper(
78	10		$server->getActivityManager(),
79	10		new Factory(
80	10		$server->getActivityManager(),
81	10		$server->getUserManager(),
82	10		$server->getURLGenerator(),
83	10		$server->getContactsManager(),
84	10		$c->query('OCA\Activity\ViewInfoCache'),
85	10		$c->query('OCP\IL10N'),
86	10		$c->query('CurrentUID')
87	10		),
88	10		$server->getL10NFactory(),
89	10		$c->query('OCP\IL10N')
90	10		);
91	24		});
92
93			$container->registerService('GroupHelper', function(IContainer $c) {
94	6		return new GroupHelper(
95	6		$c->query('ServerContainer')->getActivityManager(),
96	6		$c->query('DataHelper'),
97			true
98	6		);
99	24		});
100
101			$container->registerService('GroupHelperSingleEntries', function(IContainer $c) {
102	1		return new GroupHelper(
103	1		$c->query('ServerContainer')->getActivityManager(),
104	1		$c->query('DataHelper'),
105			false
106	1		);
107	24		});
108
109			$container->registerService('Hooks', function(IContainer $c) {
110			/** @var \OC\Server $server */
111	1		$server = $c->query('ServerContainer');
112
113	1		return new FilesHooks(
114	1		$server->getActivityManager(),
115	1		$c->query('ActivityData'),
116	1		$c->query('UserSettings'),
117	1		$server->getGroupManager(),
118	1		new View(''),
119	1		$server->getDatabaseConnection(),
120	1		$server->getURLGenerator(),
121	1		$c->query('CurrentUID')
122	1		);
123	24		});
124
125			$container->registerService('MailQueueHandler', function(IContainer $c) {
126			/** @var \OC\Server $server */
127	2		$server = $c->query('ServerContainer');
128
129	2		return new MailQueueHandler(
130	2		$server->getDateTimeFormatter(),
131	2		$server->getDatabaseConnection(),
132	2		$c->query('DataHelper'),
133	2		$server->getMailer(),
134	2		$server->getURLGenerator(),
135	2		$server->getUserManager(),
136	2		$server->getActivityManager()
137	2		);
138	24		});
139
140			$container->registerService('Navigation', function(IContainer $c) {
141			/** @var \OC\Server $server */
142	2		$server = $c->query('ServerContainer');
143	2		$rssToken = ($c->query('CurrentUID') !== '') ? $server->getConfig()->getUserValue($c->query('CurrentUID'), 'activity', 'rsstoken') : '';
144
145	2		return new Navigation(
146	2		$c->query('OCP\IL10N'),
147	2		$server->getActivityManager(),
148	2		$server->getURLGenerator(),
149	2		$c->query('CurrentUID'),
150			$rssToken
151	2		);
152	24		});
153
154			$container->registerService('UserSettings', function(IContainer $c) {
155			/** @var \OC\Server $server */
156	11		$server = $c->query('ServerContainer');
157	11		return new UserSettings(
158	11		$server->getActivityManager(),
159	11		$server->getConfig(),
160	11		$c->query('ActivityData')
161	11		);
162	24		});
163
164			$container->registerService('OCA\Activity\ViewInfoCache', function() {
165	11		return new ViewInfoCache(
166	11		new View('')
167	11		);
168	24		});
169
170			/**
171			* Core Services
172			*/
173			$container->registerService('CurrentUID', function(IContainer $c) {
174			/** @var \OC\Server $server */
175	13		$server = $c->query('ServerContainer');
176
177	13		$user = $server->getUserSession()->getUser();
178	13		return ($user) ? $user->getUID() : '';
179	24		});
180			$container->registerService('CurrentUser', function(IContainer $c) {
181			/** @var \OC\Server $server */
182	1		$server = $c->query('ServerContainer');
183
184	1		$user = $server->getUserSession()->getUser();
185	1		return $user;
186	24		});
187
188			/**
189			* Controller
190			*/
191			$container->registerService('SettingsController', function(IAppContainer $c) {
192			/** @var \OC\Server $server */
193	1		$server = $c->query('ServerContainer');
194
195	1		return new Settings(
196	1		$c->getAppName(),
197	1		$server->getRequest(),
198	1		$server->getConfig(),
199	1		$server->getSecureRandom(),
200	1		$server->getURLGenerator(),
201	1		$c->query('ActivityData'),
202	1		$c->query('UserSettings'),
203	1		$c->query('OCP\IL10N'),
204	1		$c->query('CurrentUser')
205	1		);
206	24		});
207
208		View Code Duplication	$container->registerService('OCA\Activity\Controller\OCSEndPoint', function(IAppContainer $c) {
			0 ignored issues – show Duplication introduced 2016-03-01 21:55 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
209			/** @var \OC\Server $server */
210			$server = $c->query('ServerContainer');
211
212			return new OCSEndPoint(
213			$c->query('ActivityData'),
214			$c->query('GroupHelper'),
215			$c->query('UserSettings'),
216			$server->getRequest(),
217			$server->getURLGenerator(),
218			$server->getUserSession(),
219			$server->getPreviewManager(),
220			$server->getMimeTypeDetector(),
221			new View(''),
222			$c->query('OCA\Activity\ViewInfoCache')
223			);
224	24		});
225
226			$container->registerService('EndPointController', function(IAppContainer $c) {
227			/** @var \OC\Server $server */
228			$server = $c->query('ServerContainer');
229
230			return new EndPoint(
231			$c->getAppName(),
232			$server->getRequest(),
233			$c->query('OCA\Activity\Controller\OCSEndPoint')
234			);
235	24		});
236
237			$container->registerService('ActivitiesController', function(IAppContainer $c) {
238			/** @var \OC\Server $server */
239	1		$server = $c->query('ServerContainer');
240
241	1		return new Activities(
242	1		$c->getAppName(),
243	1		$server->getRequest(),
244	1		$server->getConfig(),
245	1		$c->query('ActivityData'),
246	1		$c->query('Navigation')
247	1		);
248	24		});
249
250		View Code Duplication	$container->registerService('FeedController', function(IAppContainer $c) {
			0 ignored issues – show Duplication introduced 2015-11-21 07:27 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
251			/** @var \OC\Server $server */
252	1		$server = $c->query('ServerContainer');
253
254	1		return new Feed(
255	1		$c->getAppName(),
256	1		$server->getRequest(),
257	1		$c->query('ActivityData'),
258	1		$c->query('GroupHelperSingleEntries'),
259	1		$c->query('UserSettings'),
260	1		$server->getURLGenerator(),
261	1		$server->getActivityManager(),
262	1		$server->getL10NFactory(),
263	1		$server->getConfig(),
264	1		$c->query('CurrentUID')
265	1		);
266	24		});
267	24		}
268
269			/**
270			* Registers the consumer to the Activity Manager
271			*/
272			public function registerActivityConsumer() {
273			$c = $this->getContainer();
274			/** @var \OCP\IServerContainer $server */
275			$server = $c->getServer();
276
277			$server->getActivityManager()->registerConsumer(function() use ($c) {
278			return $c->query('Consumer');
279			});
280			}
281
282			/**
283			* Register the hooks and events
284			*/
285			public function registerHooksAndEvents() {
286			$eventDispatcher = $this->getContainer()->getServer()->getEventDispatcher();
287			$eventDispatcher->addListener('OCA\Files::loadAdditionalScripts', ['OCA\Activity\FilesHooksStatic', 'onLoadFilesAppScripts']);
288
289			Util::connectHook('OC_User', 'post_deleteUser', 'OCA\Activity\Hooks', 'deleteUser');
290
291			$this->registerFilesActivity();
292			}
293
294			/**
295			* Register the hooks for filesystem operations
296			*/
297			public function registerFilesActivity() {
298			// All other events from other apps have to be send via the Consumer
299			Util::connectHook('OC_Filesystem', 'post_create', 'OCA\Activity\FilesHooksStatic', 'fileCreate');
300			Util::connectHook('OC_Filesystem', 'post_update', 'OCA\Activity\FilesHooksStatic', 'fileUpdate');
301			Util::connectHook('OC_Filesystem', 'delete', 'OCA\Activity\FilesHooksStatic', 'fileDelete');
302			Util::connectHook('\OCA\Files_Trashbin\Trashbin', 'post_restore', 'OCA\Activity\FilesHooksStatic', 'fileRestore');
303			Util::connectHook('OCP\Share', 'post_shared', 'OCA\Activity\FilesHooksStatic', 'share');
304			Util::connectHook('OCP\Share', 'pre_unshare', 'OCA\Activity\FilesHooksStatic', 'unShare');
305			}
306
307			}
308

owncloud / activity

Pull Request — master (#574)

Application::__construct() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like