Application::__construct() - Code Metrics - Inspection of "Merge pull request #490 from owncloud/core-23212-e..." - owncloud/activity - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — stable9 ( 3c64b7...7d6fa4 )

by Joas

created 2016-03-18 09:24 UTC

Application::__construct() B

↳ Parent: Application

Complexity

Conditions	3
Paths	1

Size

Total Lines	216
Code Lines	134

Duplication

Lines	50
Ratio	23.15 %

Code Coverage

Tests	118
CRAP Score	3

Importance

Changes	12
Bugs	0	Features	4

Metric	Value
c	12
b	0
f	4
dl	50
loc	216
ccs	118
cts	118
cp	1
rs	8.2857
cc	3
eloc	134
nc	1
nop	1
crap	3

How to fix Long Method

<?php
/**
 * @author Joas Schilling <[email protected]>
 *
 * @copyright Copyright (c) 2016, ownCloud, Inc.
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */

namespace OCA\Activity\AppInfo;

use OC\Files\View;
use OCA\Activity\Consumer;
use OCA\Activity\Controller\Activities;
use OCA\Activity\Controller\EndPoint;
use OCA\Activity\Controller\Feed;
use OCA\Activity\Controller\OCSEndPoint;
use OCA\Activity\Controller\Settings;
use OCA\Activity\Data;
use OCA\Activity\DataHelper;
use OCA\Activity\GroupHelper;
use OCA\Activity\FilesHooks;
use OCA\Activity\MailQueueHandler;
use OCA\Activity\Navigation;
use OCA\Activity\Parameter\Factory;
use OCA\Activity\UserSettings;
use OCA\Activity\ViewInfoCache;
use OCP\AppFramework\App;
use OCP\IContainer;

class Application extends App {
	public function __construct (array $urlParams = array()) {
		parent::__construct('activity', $urlParams);
		$container = $this->getContainer();

		/**
		 * Activity Services
		 */
		$container->registerService('ActivityData', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');
			return new Data(
				$server->getActivityManager(),
				$server->getDatabaseConnection(),
				$server->getUserSession()
			);
		});

		$container->registerService('ActivityL10N', function(IContainer $c) {
			return $c->query('ServerContainer')->getL10N('activity');
		});


		$container->registerService('Consumer', function(IContainer $c) {
			return new Consumer(
				$c->query('ActivityData'),
				$c->query('UserSettings')
			);
		});

		$container->registerService('DataHelper', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');
			return new DataHelper(
				$server->getActivityManager(),
				new Factory(
					$server->getActivityManager(),
					$server->getUserManager(),
					$server->getURLGenerator(),
					$server->getContactsManager(),
					$c->query('OCA\Activity\ViewInfoCache'),
					$c->query('ActivityL10N'),
					$c->query('CurrentUID')
				),
				$server->getL10NFactory(),
				$c->query('ActivityL10N')
			);
		});

		$container->registerService('GroupHelper', function(IContainer $c) {
			return new GroupHelper(
				$c->query('ServerContainer')->getActivityManager(),
				$c->query('DataHelper'),
				true
			);
		});

		$container->registerService('GroupHelperSingleEntries', function(IContainer $c) {
			return new GroupHelper(
				$c->query('ServerContainer')->getActivityManager(),
				$c->query('DataHelper'),
				false
			);
		});

		$container->registerService('Hooks', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new FilesHooks(
				$server->getActivityManager(),
				$c->query('ActivityData'),
				$c->query('UserSettings'),
				$server->getGroupManager(),
				new View(''),
				$server->getDatabaseConnection(),
				$c->query('CurrentUID')
			);
		});

		$container->registerService('MailQueueHandler', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new MailQueueHandler(
				$server->getDateTimeFormatter(),
				$server->getDatabaseConnection(),
				$c->query('DataHelper'),
				$server->getMailer(),
				$server->getURLGenerator(),
				$server->getUserManager(),
				$server->getActivityManager()
			);
		});

		$container->registerService('Navigation', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');
			$rssToken = ($c->query('CurrentUID') !== '') ? $server->getConfig()->getUserValue($c->query('CurrentUID'), 'activity', 'rsstoken') : '';

			return new Navigation(
				$c->query('ActivityL10N'),
				$server->getActivityManager(),
				$server->getURLGenerator(),
				$c->query('UserSettings'),
				$c->query('CurrentUID'),
				$rssToken
			);
		});

		$container->registerService('UserSettings', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');
			return new UserSettings(
				$server->getActivityManager(),
				$server->getConfig(),
				$c->query('ActivityData')
			);
		});

		$container->registerService('OCA\Activity\ViewInfoCache', function() {
			return new ViewInfoCache(
				new View('')
			);
		});

		/**
		 * Core Services
		 */
		$container->registerService('CurrentUID', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			$user = $server->getUserSession()->getUser();
			return ($user) ? $user->getUID() : '';
		});

		/**
		 * Controller
		 */
		$container->registerService('SettingsController', function(IContainer $c) {

			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new Settings(
				$c->query('AppName'),
				$server->getRequest(),
				$server->getConfig(),
				$server->getSecureRandom()->getMediumStrengthGenerator(),
				$server->getURLGenerator(),
				$c->query('ActivityData'),
				$c->query('UserSettings'),
				$c->query('ActivityL10N'),
				$c->query('CurrentUID')
			);
		});

		$container->registerService('OCA\Activity\Controller\OCSEndPoint', function(IContainer $c) {

			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new OCSEndPoint(
				$c->query('ActivityData'),
				$c->query('GroupHelper'),
				$c->query('UserSettings'),
				$server->getRequest(),
				$server->getURLGenerator(),
				$server->getUserSession(),
				$server->getPreviewManager(),
				$server->getMimeTypeDetector(),
				new View(''),
				$c->query('OCA\Activity\ViewInfoCache')
			);
		});

		$container->registerService('EndPointController', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new EndPoint(
				$c->query('AppName'),
				$server->getRequest(),
				$c->query('OCA\Activity\Controller\OCSEndPoint')
			);
		});

		$container->registerService('ActivitiesController', function(IContainer $c) {
			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new Activities(
				$c->query('AppName'),
				$server->getRequest(),
				$server->getConfig(),
				$c->query('ActivityData'),
				$c->query('Navigation')
			);
		});

		$container->registerService('FeedController', function(IContainer $c) {

			/** @var \OC\Server $server */
			$server = $c->query('ServerContainer');

			return new Feed(
				$c->query('AppName'),
				$server->getRequest(),
				$c->query('ActivityData'),
				$c->query('GroupHelperSingleEntries'),
				$c->query('UserSettings'),
				$server->getURLGenerator(),
				$server->getActivityManager(),
				$server->getL10NFactory(),
				$server->getConfig(),
				$c->query('CurrentUID')
			);
		});
	}
}


1			<?php
2			/**
3			* @author Joas Schilling <[email protected]>
4			*
5			* @copyright Copyright (c) 2016, ownCloud, Inc.
6			* @license AGPL-3.0
7			*
8			* This code is free software: you can redistribute it and/or modify
9			* it under the terms of the GNU Affero General Public License, version 3,
10			* as published by the Free Software Foundation.
11			*
12			* This program is distributed in the hope that it will be useful,
13			* but WITHOUT ANY WARRANTY; without even the implied warranty of
14			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15			* GNU Affero General Public License for more details.
16			*
17			* You should have received a copy of the GNU Affero General Public License, version 3,
18			* along with this program. If not, see <http://www.gnu.org/licenses/>
19			*
20			*/
21
22			namespace OCA\Activity\AppInfo;
23
24			use OC\Files\View;
25			use OCA\Activity\Consumer;
26			use OCA\Activity\Controller\Activities;
27			use OCA\Activity\Controller\EndPoint;
28			use OCA\Activity\Controller\Feed;
29			use OCA\Activity\Controller\OCSEndPoint;
30			use OCA\Activity\Controller\Settings;
31			use OCA\Activity\Data;
32			use OCA\Activity\DataHelper;
33			use OCA\Activity\GroupHelper;
34			use OCA\Activity\FilesHooks;
35			use OCA\Activity\MailQueueHandler;
36			use OCA\Activity\Navigation;
37			use OCA\Activity\Parameter\Factory;
38			use OCA\Activity\UserSettings;
39			use OCA\Activity\ViewInfoCache;
40			use OCP\AppFramework\App;
41			use OCP\IContainer;
42
43			class Application extends App {
44	26		public function __construct (array $urlParams = array()) {
45	26		parent::__construct('activity', $urlParams);
46	26		$container = $this->getContainer();
47
48			/**
49			* Activity Services
50			*/
51			$container->registerService('ActivityData', function(IContainer $c) {
52			/** @var \OC\Server $server */
53	18		$server = $c->query('ServerContainer');
54	18		return new Data(
55	18		$server->getActivityManager(),
56	18		$server->getDatabaseConnection(),
57	18		$server->getUserSession()
58			);
59	26		});
60
61			$container->registerService('ActivityL10N', function(IContainer $c) {
62	16		return $c->query('ServerContainer')->getL10N('activity');
63	26		});
64
65
66			$container->registerService('Consumer', function(IContainer $c) {
67	2		return new Consumer(
68	2		$c->query('ActivityData'),
69	2		$c->query('UserSettings')
70			);
71	26		});
72
73			$container->registerService('DataHelper', function(IContainer $c) {
74			/** @var \OC\Server $server */
75	10		$server = $c->query('ServerContainer');
76	10		return new DataHelper(
77	10		$server->getActivityManager(),
78	10		new Factory(
79	10		$server->getActivityManager(),
80	10		$server->getUserManager(),
81	10		$server->getURLGenerator(),
82	10		$server->getContactsManager(),
83	10		$c->query('OCA\Activity\ViewInfoCache'),
84	10		$c->query('ActivityL10N'),
85	10		$c->query('CurrentUID')
86			),
87	10		$server->getL10NFactory(),
88	10		$c->query('ActivityL10N')
89			);
90	26		});
91
92			$container->registerService('GroupHelper', function(IContainer $c) {
93	6		return new GroupHelper(
94	6		$c->query('ServerContainer')->getActivityManager(),
95	6		$c->query('DataHelper'),
96	6		true
97			);
98	26		});
99
100			$container->registerService('GroupHelperSingleEntries', function(IContainer $c) {
101	1		return new GroupHelper(
102	1		$c->query('ServerContainer')->getActivityManager(),
103	1		$c->query('DataHelper'),
104	1		false
105			);
106	26		});
107
108			$container->registerService('Hooks', function(IContainer $c) {
109			/** @var \OC\Server $server */
110	1		$server = $c->query('ServerContainer');
111
112	1		return new FilesHooks(
113	1		$server->getActivityManager(),
114	1		$c->query('ActivityData'),
115	1		$c->query('UserSettings'),
116	1		$server->getGroupManager(),
117	1		new View(''),
118	1		$server->getDatabaseConnection(),
119	1		$c->query('CurrentUID')
120			);
121	26		});
122
123			$container->registerService('MailQueueHandler', function(IContainer $c) {
124			/** @var \OC\Server $server */
125	2		$server = $c->query('ServerContainer');
126
127	2		return new MailQueueHandler(
128	2		$server->getDateTimeFormatter(),
129	2		$server->getDatabaseConnection(),
130	2		$c->query('DataHelper'),
131	2		$server->getMailer(),
132	2		$server->getURLGenerator(),
133	2		$server->getUserManager(),
134	2		$server->getActivityManager()
135			);
136	26		});
137
138			$container->registerService('Navigation', function(IContainer $c) {
139			/** @var \OC\Server $server */
140	2		$server = $c->query('ServerContainer');
141	2		$rssToken = ($c->query('CurrentUID') !== '') ? $server->getConfig()->getUserValue($c->query('CurrentUID'), 'activity', 'rsstoken') : '';
142
143	2		return new Navigation(
144	2		$c->query('ActivityL10N'),
145	2		$server->getActivityManager(),
146	2		$server->getURLGenerator(),
147	2		$c->query('UserSettings'),
148	2		$c->query('CurrentUID'),
149			$rssToken
150			);
151	26		});
152
153			$container->registerService('UserSettings', function(IContainer $c) {
154			/** @var \OC\Server $server */
155	14		$server = $c->query('ServerContainer');
156	14		return new UserSettings(
157	14		$server->getActivityManager(),
158	14		$server->getConfig(),
159	14		$c->query('ActivityData')
160			);
161	26		});
162
163			$container->registerService('OCA\Activity\ViewInfoCache', function() {
164	11		return new ViewInfoCache(
165	11		new View('')
166			);
167	26		});
168
169			/**
170			* Core Services
171			*/
172			$container->registerService('CurrentUID', function(IContainer $c) {
173			/** @var \OC\Server $server */
174	15		$server = $c->query('ServerContainer');
175
176	15		$user = $server->getUserSession()->getUser();
177	15		return ($user) ? $user->getUID() : '';
178	26		});
179
180			/**
181			* Controller
182			*/
183		View Code Duplication	$container->registerService('SettingsController', function(IContainer $c) {
			0 ignored issues – show Duplication introduced 2015-11-21 07:27 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
184			/** @var \OC\Server $server */
185	2		$server = $c->query('ServerContainer');
186
187	2		return new Settings(
188	2		$c->query('AppName'),
189	2		$server->getRequest(),
190	2		$server->getConfig(),
191	2		$server->getSecureRandom()->getMediumStrengthGenerator(),
192	2		$server->getURLGenerator(),
193	2		$c->query('ActivityData'),
194	2		$c->query('UserSettings'),
195	2		$c->query('ActivityL10N'),
196	2		$c->query('CurrentUID')
197			);
198	26		});
199
200		View Code Duplication	$container->registerService('OCA\Activity\Controller\OCSEndPoint', function(IContainer $c) {
			0 ignored issues – show Duplication introduced 2016-03-01 21:55 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
201			/** @var \OC\Server $server */
202			$server = $c->query('ServerContainer');
203
204			return new OCSEndPoint(
205			$c->query('ActivityData'),
206			$c->query('GroupHelper'),
207			$c->query('UserSettings'),
208			$server->getRequest(),
209			$server->getURLGenerator(),
210			$server->getUserSession(),
211			$server->getPreviewManager(),
212			$server->getMimeTypeDetector(),
213			new View(''),
214			$c->query('OCA\Activity\ViewInfoCache')
215			);
216	26		});
217
218			$container->registerService('EndPointController', function(IContainer $c) {
219			/** @var \OC\Server $server */
220			$server = $c->query('ServerContainer');
221
222			return new EndPoint(
223			$c->query('AppName'),
224			$server->getRequest(),
225			$c->query('OCA\Activity\Controller\OCSEndPoint')
226			);
227	26		});
228
229			$container->registerService('ActivitiesController', function(IContainer $c) {
230			/** @var \OC\Server $server */
231	1		$server = $c->query('ServerContainer');
232
233	1		return new Activities(
234	1		$c->query('AppName'),
235	1		$server->getRequest(),
236	1		$server->getConfig(),
237	1		$c->query('ActivityData'),
238	1		$c->query('Navigation')
239			);
240	26		});
241
242	26	View Code Duplication	$container->registerService('FeedController', function(IContainer $c) {
			0 ignored issues – show Duplication introduced 2015-11-21 07:27 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
243			/** @var \OC\Server $server */
244	1		$server = $c->query('ServerContainer');
245
246	1		return new Feed(
247	1		$c->query('AppName'),
248	1		$server->getRequest(),
249	1		$c->query('ActivityData'),
250	1		$c->query('GroupHelperSingleEntries'),
251	1		$c->query('UserSettings'),
252	1		$server->getURLGenerator(),
253	1		$server->getActivityManager(),
254	1		$server->getL10NFactory(),
255	1		$server->getConfig(),
256	1		$c->query('CurrentUID')
257			);
258	26		});
259	26		}
260			}
261

owncloud / activity

Push — stable9 ( 3c64b7...7d6fa4 )

Application::__construct() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like