OwenIt\Auditing\Drivers\Database::audit()

Complexity

Conditions	4
Paths	3

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	6

Importance

Changes	5
Bugs	0	Features	2

<?php
    public function audit(Auditable $model): Audit
    {
        $implementation = Config::get('audit.implementation', \OwenIt\Auditing\Models\Audit::class);

        // If we want to avoid storing Audits with empty old_values & new_values, return null here.
        if (!Config::get('audit.empty_values')) {
            $attributeGetter = $model->resolveAttributeGetter($model->getAuditEvent());

The method resolveAttributeGetter() does not exist on OwenIt\Auditing\Contracts\Auditable. Since it exists in all sub-types, consider adding an abstract or default implementation to OwenIt\Auditing\Contracts\Auditable.

            list($old, $new) = $model->$attributeGetter();
            if (empty($old) && empty($new)) {
                return null;

The expression return null returns the type null which is incompatible with the type-hinted return OwenIt\Auditing\Contracts\Audit.

            }
        }

        return call_user_func([$implementation, 'create'], $model->toAudit());
    }