OwenIt\Auditing\Resolvers\IpAddressResolver::resolve()

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

<?php
    public static function resolve(Auditable $auditable): string
    {
        return $auditable->preloadedResolverData['ip_address'] ?? Request::ip();

The expression return $auditable->preloadedResolverData['ip_address'] ?? Illuminate\Support\Facades\Request::ip() could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

Accessing preloadedResolverData on the interface OwenIt\Auditing\Contracts\Auditable suggest that you code against a concrete implementation. How about adding an instanceof check?

    }