OwenIt\Auditing\Resolvers\UserAgentResolver

Complexity

Total Complexity

1

Size/Duplication

Total Lines	5
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	resolve()	0	3	1

<?php

namespace OwenIt\Auditing\Resolvers;

use Illuminate\Support\Facades\Request;
use OwenIt\Auditing\Contracts\Auditable;
use OwenIt\Auditing\Contracts\Resolver;

class UserAgentResolver implements Resolver
{
    public static function resolve(Auditable $auditable): string
    {
        return $auditable->preloadedResolverData['user_agent'] ?? Request::header('User-Agent');

Accessing preloadedResolverData on the interface OwenIt\Auditing\Contracts\Auditable suggest that you code against a concrete implementation. How about adding an instanceof check?

The expression return $auditable->preloadedResolverData['user_agent'] ?? Illuminate\Support\Facades\Request::header('User-Agent') could return the type array|null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }
}