ArrayShortDefinition::pass() - Code Metrics - Inspection of "Allow analyzers to be configured" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#139)

by Kévin

created 2016-10-11 08:22 UTC

ArrayShortDefinition::pass() A

↳ Parent: ArrayShortDefinition

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	8
nc	2
nop	2
dl	0
loc	14
ccs	4
cts	4
cp	1
crap	2
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * @author Patsura Dmitry https://github.com/ovr <[email protected]>
 */

namespace PHPSA\Analyzer\Pass\Expression;

use PhpParser\Node\Expr;
use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;
use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
use PHPSA\Context;

class ArrayShortDefinition implements AnalyzerPassInterface
{
    use DefaultMetadataPassTrait {
        DefaultMetadataPassTrait::getMetadata as defaultMetadata;
    }

    const DESCRIPTION = 'Short syntax can be used in array literals.';

    /**
     * @param Expr\Array_ $expr
     * @param Context $context
     * @return bool
     */
    public function pass(Expr\Array_ $expr, Context $context)
    {
        if ($expr->getAttribute('kind') == Expr\Array_::KIND_LONG) {
            $context->notice(
                'array.short-syntax',
                'Please use [] (short syntax) for array definition.',
                $expr
            );

            return true;
        }

        return false;
    }

    /**
     * @return array
     */
    public function getRegister()
    {
        return [
            Expr\Array_::class
        ];
    }

    /**
     * {@inheritdoc}
     */
    public static function getMetadata()
    {
        $metadata = self::defaultMetadata();
        $metadata->setRequiredPhpVersion('5.4');

        return $metadata;
    }
}


1		<?php
2		/**
3		* @author Patsura Dmitry https://github.com/ovr <[email protected]>
4		*/
5
6		namespace PHPSA\Analyzer\Pass\Expression;
7
8		use PhpParser\Node\Expr;
9		use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;
10		use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
11		use PHPSA\Context;
12
13		class ArrayShortDefinition implements AnalyzerPassInterface
14		{
15		use DefaultMetadataPassTrait {
16		DefaultMetadataPassTrait::getMetadata as defaultMetadata;
17		}
18
19		const DESCRIPTION = 'Short syntax can be used in array literals.';
20	40
21		/**
22	40	* @param Expr\Array_ $expr
23	2	* @param Context $context
24	2	* @return bool
25	2	*/
26		public function pass(Expr\Array_ $expr, Context $context)
27	2	{
28		if ($expr->getAttribute('kind') == Expr\Array_::KIND_LONG) {
29	2	$context->notice(
30		'array.short-syntax',
31		'Please use [] (short syntax) for array definition.',
32	39	$expr
33		);
34
35		return true;
36		}
37
38	1	return false;
39		}
40
41		/**
42	1	* @return array
43		*/
44		public function getRegister()
45		{
46		return [
47		Expr\Array_::class
48		];
49		}
50
51		/**
52		* {@inheritdoc}
53		*/
54		public static function getMetadata()
55		{
56		$metadata = self::defaultMetadata();
57		$metadata->setRequiredPhpVersion('5.4');
58
59		return $metadata;
60		}
61		}
62

ovr / phpsa

Pull Request — master (#139)

ArrayShortDefinition::pass() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like