OldConstructor::pass() - Code Metrics - Inspection of "make analyzers more consistent" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3708b9...fb0aff )

by Enrico

created 2016-10-08 19:07 UTC

OldConstructor::pass() A

↳ Parent: OldConstructor

Complexity

Conditions	4
Paths	3

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	4

Importance

Changes

Metric	Value
cc	4
eloc	10
nc	3
nop	2
dl	0
loc	16
ccs	11
cts	11
cp	1
crap	4
rs	9.2
c	0
b	0
f	0

<?php

namespace PHPSA\Analyzer\Pass\Statement;

use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\Node\Stmt\Class_;
use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
use PHPSA\Context;

class OldConstructor implements AnalyzerPassInterface
{

    /**
     * @param Class_ $classStmt
     * @param Context $context
     * @return bool
     */
    public function pass(Class_ $classStmt, Context $context)
    {
        foreach ($classStmt->stmts as $statement) {
            if (!($statement instanceof ClassMethod) || $statement->name !== $classStmt->name) {
                continue;
            }
            $context->notice(
                'deprecated.constructor',
                sprintf('Class %s uses a PHP4 constructor.', $classStmt->name),
                $classStmt
            );
            return true;
        }

        return false;
    }

    /**
     * @return array
     */
    public function getRegister()
    {
        return [
            Class_::class
        ];
    }
}


1		<?php
2
3		namespace PHPSA\Analyzer\Pass\Statement;
4
5		use PhpParser\Node\Stmt\ClassMethod;
6		use PhpParser\Node\Stmt\Class_;
7		use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
8		use PHPSA\Context;
9
10		class OldConstructor implements AnalyzerPassInterface
11		{
12
13		/**
14		* @param Class_ $classStmt
15		* @param Context $context
16		* @return bool
17		*/
18	34	public function pass(Class_ $classStmt, Context $context)
19		{
20	34	foreach ($classStmt->stmts as $statement) {
21	34	if (!($statement instanceof ClassMethod) \|\| $statement->name !== $classStmt->name) {
22	34	continue;
23		}
24	1	$context->notice(
25	1	'deprecated.constructor',
26	1	sprintf('Class %s uses a PHP4 constructor.', $classStmt->name),
27		$classStmt
28	1	);
29	1	return true;
30	34	}
31
32	34	return false;
33		}
34
35		/**
36		* @return array
37		*/
38	1	public function getRegister()
39		{
40		return [
41		Class_::class
42	1	];
43		}
44		}
45

ovr / phpsa

Push — master ( 3708b9...fb0aff )

OldConstructor::pass() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like