DoTest::testDoConditionCreatesVar() - Code Metrics - Inspection of "Compiler support more Nodes" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#149)

by Enrico

created 2016-09-29 15:38 UTC

DoTest::testDoConditionCreatesVar() A

↳ Parent: DoTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	19
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	10
nc	1
nop	0
dl	0
loc	19
rs	9.4285
c	0
b	0
f	0

<?php

namespace Tests\PHPSA\Compiler\Statement;

use PhpParser\Node;
use PHPSA\Variable;

class DoTest extends \Tests\PHPSA\TestCase
{
    /**
     * Tests do {} while ($stmtTest = 2) creates the variable
     */
    public function testDoConditionCreatesVar()
    {
        $context = $this->getContext();

        $statement = new Node\Stmt\Do_(
            new Node\Expr\Assign(
                new Node\Expr\Variable(
                    new Node\Name("stmtTest")
                ),
                $this->newScalarExpr(2)
            )
        );
        
        \PHPSA\nodeVisitorFactory($statement, $context);

        $variable = $context->getSymbol("stmtTest");

        parent::assertTrue($variable instanceof Variable);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Tests do { $stmtTest = 2; } while (1 == 1) creates the variable
     */
    public function testDoStatementCreatesVar()
    {
        $context = $this->getContext();

        $statement = new Node\Stmt\Do_(
            new Node\Expr\BinaryOp\Equal($this->newScalarExpr(1), $this->newScalarExpr(1)),
            ["stmts" =>
                new Node\Expr\Assign(
                    new Node\Expr\Variable(
                        new Node\Name("stmtTest")
                    ),
                    $this->newScalarExpr(2)
                )]
        );
        
        \PHPSA\nodeVisitorFactory($statement, $context);

        $variable = $context->getSymbol("stmtTest");

        parent::assertTrue($variable instanceof Variable);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }
}


1			<?php
2
3			namespace Tests\PHPSA\Compiler\Statement;
4
5			use PhpParser\Node;
6			use PHPSA\Variable;
7
8			class DoTest extends \Tests\PHPSA\TestCase
9			{
10			/**
11			* Tests do {} while ($stmtTest = 2) creates the variable
12			*/
13			public function testDoConditionCreatesVar()
14			{
15			$context = $this->getContext();
16
17			$statement = new Node\Stmt\Do_(
18			new Node\Expr\Assign(
19			new Node\Expr\Variable(
20			new Node\Name("stmtTest")
21			),
22			$this->newScalarExpr(2)
23			)
24			);
25
26			\PHPSA\nodeVisitorFactory($statement, $context);
27
28			$variable = $context->getSymbol("stmtTest");
29
30			parent::assertTrue($variable instanceof Variable);
			0 ignored issues – show Comprehensibility Bug introduced 2016-09-29 15:42 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`assertTrue()` instead of `testDoConditionCreatesVar()`). Are you sure this is correct? If so, you might want to change this to `$this->assertTrue()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
31			}
32
33			/**
34			* Tests do { $stmtTest = 2; } while (1 == 1) creates the variable
35			*/
36			public function testDoStatementCreatesVar()
37			{
38			$context = $this->getContext();
39
40			$statement = new Node\Stmt\Do_(
41			new Node\Expr\BinaryOp\Equal($this->newScalarExpr(1), $this->newScalarExpr(1)),
42			["stmts" =>
43			new Node\Expr\Assign(
44			new Node\Expr\Variable(
45			new Node\Name("stmtTest")
46			),
47			$this->newScalarExpr(2)
48			)]
49			);
50
51			\PHPSA\nodeVisitorFactory($statement, $context);
52
53			$variable = $context->getSymbol("stmtTest");
54
55			parent::assertTrue($variable instanceof Variable);
			0 ignored issues – show Comprehensibility Bug introduced 2016-09-29 15:42 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`assertTrue()` instead of `testDoStatementCreatesVar()`). Are you sure this is correct? If so, you might want to change this to `$this->assertTrue()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
56			}
57			}
58

ovr / phpsa

Pull Request — master (#149)

DoTest::testDoConditionCreatesVar() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like