PHPSA\Compiler\Expression\ArrayDimFetch

Complexity

Total Complexity

12

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	1

1 Method

Rating	Name	Duplication	Size	Complexity
C	compile()	0	41	12

<?php

namespace PHPSA\Compiler\Expression;

use PHPSA\CompiledExpression;
use PHPSA\Context;

class ArrayDimFetch extends AbstractExpressionCompiler
{
    protected $name = 'PhpParser\Node\Expr\ArrayDimFetch';

    /**
     * $array[1], $array[$var], $array["string"], "string"[1]
     *
     * @param \PhpParser\Node\Expr\ArrayDimFetch $expr
     * @param Context $context
     * @return CompiledExpression
     */
    protected function compile($expr, Context $context)
    {
        $compiler = $context->getExpressionCompiler();
        $var = $compiler->compile($expr->var);
        $dim = $compiler->compile($expr->dim);

It seems like $expr->dim can be null; however, compile() does not accept null, maybe add an additional type check?

        if ($var->getType() === CompiledExpression::UNIMPLEMENTED
         || $dim->getType() === CompiledExpression::UNIMPLEMENTED
        ) {
            return new CompiledExpression(CompiledExpression::UNIMPLEMENTED);
        }

        if (!$var->isTypeKnown() || !$dim->isTypeKnown()
         || !$var->isCorrectValue() || !$dim->isCorrectValue()
        ) {
            return new CompiledExpression();
        }

        switch ($var->getType()) {
            case CompiledExpression::STRING:
            case CompiledExpression::ARR:
                if ($dim->isArray()) {
                    $context->notice(
                        'language_error',
                        'Illegal offset type',
                        $expr
                    );
                    return new CompiledExpression();
                }
                break;
            default:
                break;
        }

        if ($var->isArray() && $var->isCorrectValue()) {
            $resultArray = $var->getValue();
            return CompiledExpression::fromZvalValue($resultArray[$dim->getValue()]);
        }

        return new CompiledExpression();
    }
}