MethodCannotReturn::pass() - Code Metrics - Inspection of "[Analyzer] Helper\ResolveExpressionTrait implement..." - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d82f0a...49e44e )

by Дмитрий

created 2016-05-27 14:15 UTC

MethodCannotReturn::pass() B

↳ Parent: MethodCannotReturn

Complexity

Conditions	6
Paths	3

Size

Total Lines	26
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	17.6982

Importance

Changes	3
Bugs	0	Features	2

Metric	Value
cc	6
eloc	14
c	3
b	0
f	2
nc	3
nop	2
dl	0
loc	26
ccs	5
cts	16
cp	0.3125
crap	17.6982
rs	8.439

<?php
/**
 * @author Patsura Dmitry https://github.com/ovr <[email protected]>
 */

namespace PHPSA\Analyzer\Pass\Statement;

use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\Node\Stmt\Return_;
use PHPSA\Analyzer\Helper\ResolveExpressionTrait;
use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
use PHPSA\Analyzer\Pass\ConfigurablePassInterface;
use PHPSA\Context;
use Symfony\Component\Config\Definition\Builder\TreeBuilder;

class MethodCannotReturn implements ConfigurablePassInterface, AnalyzerPassInterface
{
    use ResolveExpressionTrait;

    /**
     * @param ClassMethod $methodStmt
     * @param Context $context
     * @return bool
     */
    public function pass(ClassMethod $methodStmt, Context $context)
    {
        if (count($methodStmt->stmts) == 0) {
            return false;
        }

        $result = false;

        if ($methodStmt->name == '__construct' || $methodStmt->name == '__destruct') {
            foreach ($this->findReturnStatement($methodStmt->stmts) as $returnStmt) {
                if (!$returnStmt->expr) {
                    continue;
                }

                $context->notice(
                    'return.construct',
                    sprintf('Method %s cannot return a value.', $methodStmt->name),
                    $returnStmt
                );

                $result = true;
            }
        }

        return $result;
    }

    /**
     * @return TreeBuilder
     */
    public function getConfiguration()
    {
        $treeBuilder = new TreeBuilder();
        $treeBuilder->root('method_cannot_return')
            ->canBeDisabled()
        ;

        return $treeBuilder;
    }

    /**
     * @return array
     */
    public function getRegister()
    {
        return [
            \PhpParser\Node\Stmt\ClassMethod::class
        ];
    }
}


1		<?php
2		/**
3		* @author Patsura Dmitry https://github.com/ovr <[email protected]>
4		*/
5
6		namespace PHPSA\Analyzer\Pass\Statement;
7
8		use PhpParser\Node\Stmt\ClassMethod;
9		use PhpParser\Node\Stmt\Return_;
10		use PHPSA\Analyzer\Helper\ResolveExpressionTrait;
11		use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
12		use PHPSA\Analyzer\Pass\ConfigurablePassInterface;
13		use PHPSA\Context;
14		use Symfony\Component\Config\Definition\Builder\TreeBuilder;
15
16		class MethodCannotReturn implements ConfigurablePassInterface, AnalyzerPassInterface
17		{
18		use ResolveExpressionTrait;
19
20		/**
21		* @param ClassMethod $methodStmt
22		* @param Context $context
23		* @return bool
24		*/
25	6	public function pass(ClassMethod $methodStmt, Context $context)
26		{
27	6	if (count($methodStmt->stmts) == 0) {
28		return false;
29		}
30
31	6	$result = false;
32
33	6	if ($methodStmt->name == '__construct' \|\| $methodStmt->name == '__destruct') {
34		foreach ($this->findReturnStatement($methodStmt->stmts) as $returnStmt) {
35		if (!$returnStmt->expr) {
36		continue;
37		}
38
39		$context->notice(
40		'return.construct',
41		sprintf('Method %s cannot return a value.', $methodStmt->name),
42		$returnStmt
43		);
44
45		$result = true;
46		}
47		}
48
49	6	return $result;
50		}
51
52		/**
53		* @return TreeBuilder
54		*/
55		public function getConfiguration()
56		{
57		$treeBuilder = new TreeBuilder();
58		$treeBuilder->root('method_cannot_return')
59		->canBeDisabled()
60		;
61
62		return $treeBuilder;
63		}
64
65		/**
66		* @return array
67		*/
68	1	public function getRegister()
69		{
70		return [
71		\PhpParser\Node\Stmt\ClassMethod::class
72	1	];
73		}
74		}
75

ovr / phpsa

Push — master ( d82f0a...49e44e )

MethodCannotReturn::pass() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like