Div::compile() - Code Metrics - Inspection of "Compiler operators" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#122)

by Enrico

created 2016-09-13 12:49 UTC

Div::compile() B

↳ Parent: Div

Complexity

Conditions	7
Paths	13

Size

Total Lines	21
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	56

Importance

Changes

Metric	Value
cc	7
eloc	15
c	0
b	0
f	0
nc	13
nop	2
dl	0
loc	21
ccs	0
cts	16
cp	0
crap	56
rs	7.551

<?php

namespace PHPSA\Compiler\Expression\AssignOp;

use PHPSA\CompiledExpression;
use PHPSA\Compiler\Expression;
use PHPSA\Compiler\Expression\AbstractExpressionCompiler;
use PHPSA\Context;

class Div extends AbstractExpressionCompiler
{
    protected $name = 'PhpParser\Node\Expr\AssignOp\Div';

    /**
     * {left-expr} /= {right-expr}
     *
     * @param \PhpParser\Node\Expr\AssignOp\Div $expr
     * @param Context $context
     * @return CompiledExpression
     */
    protected function compile($expr, Context $context)
    {
        $left = $context->getExpressionCompiler()->compile($expr->var);
        $expExpression = $context->getExpressionCompiler()->compile($expr->expr);

        switch ($left->getType()) {
            case CompiledExpression::INTEGER:
            case CompiledExpression::DOUBLE:
            case CompiledExpression::NUMBER:
                switch ($expExpression->getType()) {
                    case CompiledExpression::INTEGER:
                    case CompiledExpression::DOUBLE:
                    case CompiledExpression::NUMBER:
                        return CompiledExpression::fromZvalValue($left->getValue() / $expExpression->getValue());
                        break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
                }
                break;
        }
        
        return new CompiledExpression(CompiledExpression::UNKNOWN);
    }
}


1			<?php
2
3			namespace PHPSA\Compiler\Expression\AssignOp;
4
5			use PHPSA\CompiledExpression;
6			use PHPSA\Compiler\Expression;
7			use PHPSA\Compiler\Expression\AbstractExpressionCompiler;
8			use PHPSA\Context;
9
10			class Div extends AbstractExpressionCompiler
11			{
12			protected $name = 'PhpParser\Node\Expr\AssignOp\Div';
13
14			/**
15			* {left-expr} /= {right-expr}
16			*
17			* @param \PhpParser\Node\Expr\AssignOp\Div $expr
18			* @param Context $context
19			* @return CompiledExpression
20			*/
21			protected function compile($expr, Context $context)
22			{
23			$left = $context->getExpressionCompiler()->compile($expr->var);
24			$expExpression = $context->getExpressionCompiler()->compile($expr->expr);
25
26			switch ($left->getType()) {
27			case CompiledExpression::INTEGER:
28			case CompiledExpression::DOUBLE:
29			case CompiledExpression::NUMBER:
30			switch ($expExpression->getType()) {
31			case CompiledExpression::INTEGER:
32			case CompiledExpression::DOUBLE:
33			case CompiledExpression::NUMBER:
34			return CompiledExpression::fromZvalValue($left->getValue() / $expExpression->getValue());
35			break;
			0 ignored issues – show Unused Code introduced 2016-09-13 12:43 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
36			}
37			break;
38			}
39
40			return new CompiledExpression(CompiledExpression::UNKNOWN);
41			}
42			}
43

ovr / phpsa

Pull Request — master (#122)

Div::compile() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like