Issues in ErrorSuppressTest.php - Fixed Issues - Inspection of "Merge pull request #325 from ddmler/uniform-assert..." - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d6a494...e1144e )

by Дмитрий

created 2017-02-20 13:01 UTC

PHPSA/Compiler/Expression/ErrorSuppressTest.php (3 issues)

Labels

Severity

Minor 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Tests\PHPSA\Expression;

use PhpParser\Node;
use PHPSA\CompiledExpression;
use PHPSA\Compiler\Expression;

class ErrorSuppressTest extends \Tests\PHPSA\TestCase
{
    public function testErrorSuppressSuccess()
    {
        $baseExpression = new Node\Expr\ErrorSuppress(new Node\Expr\Print_(
            $this->newScalarExpr("test")
        ));
        $compiledExpression = $this->compileExpression($baseExpression);

        parent::assertInstanceOfCompiledExpression($compiledExpression);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        parent::assertSame(CompiledExpression::INTEGER, $compiledExpression->getType());
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        parent::assertSame(1, $compiledExpression->getValue());
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }
}


1			<?php
2
3			namespace Tests\PHPSA\Expression;
4
5			use PhpParser\Node;
6			use PHPSA\CompiledExpression;
7			use PHPSA\Compiler\Expression;
8
9			class ErrorSuppressTest extends \Tests\PHPSA\TestCase
10			{
11			public function testErrorSuppressSuccess()
12			{
13			$baseExpression = new Node\Expr\ErrorSuppress(new Node\Expr\Print_(
14			$this->newScalarExpr("test")
15			));
16			$compiledExpression = $this->compileExpression($baseExpression);
17
18			parent::assertInstanceOfCompiledExpression($compiledExpression);
			0 ignored issues – show Comprehensibility Bug introduced 2016-09-27 18:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you call parent on a different method (`assertInstanceOfCompiledExpression()` instead of `testErrorSuppressSuccess()`). Are you sure this is correct? If so, you might want to change this to `$this->assertInstanceOfCompiledExpression()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
19			parent::assertSame(CompiledExpression::INTEGER, $compiledExpression->getType());
			0 ignored issues – show Comprehensibility Bug introduced 2016-09-27 18:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you call parent on a different method (`assertSame()` instead of `testErrorSuppressSuccess()`). Are you sure this is correct? If so, you might want to change this to `$this->assertSame()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
20			parent::assertSame(1, $compiledExpression->getValue());
			0 ignored issues – show Comprehensibility Bug introduced 2016-09-27 18:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you call parent on a different method (`assertSame()` instead of `testErrorSuppressSuccess()`). Are you sure this is correct? If so, you might want to change this to `$this->assertSame()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
21			}
22			}
23

ovr / phpsa

Push — master ( d6a494...e1144e )

PHPSA/Compiler/Expression/ErrorSuppressTest.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like