PropertyDefinitionDefaultValue::pass() - Code Metrics - Inspection of "Fixed False positives [return.construct] Return in..." - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#287)

by algo13

created 2016-12-28 06:18 UTC

PropertyDefinitionDefaultValue::pass() A

↳ Parent: PropertyDefinitionDefaultValue

Complexity

Conditions	3
Paths	3

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	3.0067

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	10
nc	3
nop	2
dl	0
loc	15
ccs	10
cts	11
cp	0.9091
crap	3.0067
rs	9.4285
c	1
b	0
f	0

<?php

namespace PHPSA\Analyzer\Pass\Statement;

use PhpParser\Node\Stmt;
use PhpParser\Node;
use PhpParser\Node\Expr;
use PhpParser\Node\Stmt\PropertyProperty;
use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;
use PHPSA\Analyzer\Pass;
use PHPSA\Context;
use PHPSA\CompiledExpression;

class PropertyDefinitionDefaultValue implements Pass\AnalyzerPassInterface
{
    use DefaultMetadataPassTrait;

    const DESCRIPTION = 'Checks if any Property Definition is done with a default null value (not needed). For example: `$a = null`';

    /**
     * @param $stmt
     * @param Context $context
     * @return bool
     */
    public function pass($stmt, Context $context)
    {
        if ($stmt->default instanceof Node\Expr) {
            $compiled = $context->getExpressionCompiler()->compile($stmt->default);
            if ($compiled->getType() == CompiledExpression::NULL) {
                $context->notice(
                    'property_definition_default_value',
                    'null is default and is not needed.',
                    $stmt
                );
                return true;
            }
        }
        return false;
    }

    /**
     * @return array
     */
    public function getRegister()
    {
        return [
            PropertyProperty::class,
        ];
    }
}


1		<?php
2
3		namespace PHPSA\Analyzer\Pass\Statement;
4
5		use PhpParser\Node\Stmt;
6		use PhpParser\Node;
7		use PhpParser\Node\Expr;
8		use PhpParser\Node\Stmt\PropertyProperty;
9		use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;
10		use PHPSA\Analyzer\Pass;
11		use PHPSA\Context;
12		use PHPSA\CompiledExpression;
13
14		class PropertyDefinitionDefaultValue implements Pass\AnalyzerPassInterface
15		{
16		use DefaultMetadataPassTrait;
17
18		const DESCRIPTION = 'Checks if any Property Definition is done with a default null value (not needed). For example: `$a = null`';
19
20		/**
21		* @param $stmt
22		* @param Context $context
23		* @return bool
24		*/
25	1	public function pass($stmt, Context $context)
26		{
27	1	if ($stmt->default instanceof Node\Expr) {
28	1	$compiled = $context->getExpressionCompiler()->compile($stmt->default);
29	1	if ($compiled->getType() == CompiledExpression::NULL) {
30	1	$context->notice(
31	1	'property_definition_default_value',
32	1	'null is default and is not needed.',
33		$stmt
34	1	);
35	1	return true;
36		}
37		}
38	1	return false;
39		}
40
41		/**
42		* @return array
43		*/
44	1	public function getRegister()
45		{
46		return [
47	1	PropertyProperty::class,
48	1	];
49		}
50		}
51

ovr / phpsa

Pull Request — master (#287)

PropertyDefinitionDefaultValue::pass() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like