Conditions | 9 |
Paths | 21 |
Total Lines | 23 |
Code Lines | 17 |
Lines | 0 |
Ratio | 0 % |
Tests | 18 |
CRAP Score | 9 |
Changes | 0 |
1 | <?php |
||
21 | 18 | protected function compile($expr, Context $context) |
|
22 | { |
||
23 | 18 | $left = $context->getExpressionCompiler()->compile($expr->var); |
|
24 | 18 | $expExpression = $context->getExpressionCompiler()->compile($expr->expr); |
|
25 | |||
26 | 18 | switch ($left->getType()) { |
|
27 | 18 | case CompiledExpression::INTEGER: |
|
28 | 18 | case CompiledExpression::DOUBLE: |
|
29 | 18 | case CompiledExpression::NUMBER: |
|
30 | 18 | case CompiledExpression::BOOLEAN: |
|
31 | 17 | switch ($expExpression->getType()) { |
|
32 | 17 | case CompiledExpression::INTEGER: |
|
33 | 17 | case CompiledExpression::DOUBLE: |
|
34 | 17 | case CompiledExpression::NUMBER: |
|
35 | 17 | case CompiledExpression::BOOLEAN: |
|
36 | 16 | return CompiledExpression::fromZvalValue($left->getValue() / $expExpression->getValue()); |
|
37 | break; |
||
|
|||
38 | 1 | } |
|
39 | 1 | break; |
|
40 | 2 | } |
|
41 | |||
42 | 2 | return new CompiledExpression(CompiledExpression::UNKNOWN); |
|
43 | } |
||
44 | } |
||
45 |
The break statement is not necessary if it is preceded for example by a return statement:
If you would like to keep this construct to be consistent with other case statements, you can safely mark this issue as a false-positive.