PHPSA\Analyzer\Pass\Statement\AssignmentInCondition

Complexity

Total Complexity

9

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Test Coverage

Coverage

84.85%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	pass()	0	22	5
A	getConfiguration()	0	8	1
A	getRegister()	0	7	1
A	checkElseIfStatement()	0	11	2

<?php
/**
 * @author Kévin Gomez https://github.com/K-Phoen <contact@kevingomez.fr>
 */

namespace PHPSA\Analyzer\Pass\Statement;

use PhpParser\Node\Expr\Assign;
use PhpParser\Node\Stmt;
use PhpParser\Node\Stmt\ElseIf_;
use PhpParser\Node\Stmt\If_;
use PHPSA\Analyzer\Pass;
use PHPSA\Context;
use Symfony\Component\Config\Definition\Builder\TreeBuilder;

class AssignmentInCondition implements Pass\ConfigurablePassInterface, Pass\AnalyzerPassInterface
{
    /**
     * @param $stmt
     * @param Context $context
     * @return bool
     */
    public function pass($stmt, Context $context)
    {
        $result = false;

        if ($stmt instanceof If_) {
            if ($stmt->cond instanceof Assign) {
                $context->notice(
                    'assignment_in_condition',
                    'An assignment statement has been made instead of conditional statement',
                    $stmt
                );
                $result = true;
            }

            $elseifStmts = $stmt->elseifs;
            foreach ($elseifStmts as $elseif) {
                $result = $this->checkElseIfStatement($elseif, $context) || $result;
            }
        }

        return $result;
    }

    /**
     * @return TreeBuilder
     */
    public function getConfiguration()
    {
        $treeBuilder = new TreeBuilder();
        $treeBuilder->root('assignment_in_condition')
            ->canBeDisabled();

        return $treeBuilder;
    }

    /**
     * @return array
     */
    public function getRegister()
    {
        return [
            If_::class,
            ElseIf_::class,
        ];
    }

    /**
     * @param ElseIf_ $elseif
     * @param Context $context
     * @return bool
     */
    private function checkElseIfStatement(ElseIf_ $elseif, Context $context)
    {
        if ($elseif->cond instanceof Assign) {
            $context->notice(
                'assignment_in_condition',
                'An assignment statement has been made instead of conditional statement',
                $elseif
            );
            return true;
        }
    }
}