AssignmentInCondition::pass() - Code Metrics - Inspection of "Add compiler events for case, elseif, else" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#194)

by Enrico

created 2016-10-06 12:39 UTC

AssignmentInCondition::pass() A

↳ Parent: AssignmentInCondition

Complexity

Conditions	4
Paths	4

Size

Total Lines	19
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	11
c	1
b	0
f	0
nc	4
nop	2
dl	0
loc	19
ccs	12
cts	12
cp	1
crap	4
rs	9.2

<?php
/**
 * @author Kévin Gomez https://github.com/K-Phoen <[email protected]>
 */

namespace PHPSA\Analyzer\Pass\Statement;

use PhpParser\Node\Expr;
use PhpParser\Node\Expr\Assign;
use PhpParser\Node\Stmt;
use PhpParser\Node\Stmt\Do_;
use PhpParser\Node\Stmt\ElseIf_;
use PhpParser\Node\Stmt\If_;
use PhpParser\Node\Stmt\Case_;
use PhpParser\Node\Stmt\While_;
use PhpParser\Node\Stmt\For_;
use PHPSA\Analyzer\Pass;
use PHPSA\Context;
use Symfony\Component\Config\Definition\Builder\TreeBuilder;

class AssignmentInCondition implements Pass\ConfigurablePassInterface, Pass\AnalyzerPassInterface
{
    /**
     * @param $stmt
     * @param Context $context
     * @return bool
     */
    public function pass($stmt, Context $context)
    {
        $condition = $stmt->cond;

        if ($stmt instanceof For_ && count($stmt->cond) > 0) { // For is the only one that has an array as condition
            $condition = $condition[0];
        }

        if ($condition instanceof Assign) {
            $context->notice(
                'assignment_in_condition',
                'An assignment statement has been made instead of conditional statement',
                $stmt
            );
            return true;
        }

        return false;
    }

    /**
     * @return TreeBuilder
     */
    public function getConfiguration()
    {
        $treeBuilder = new TreeBuilder();
        $treeBuilder->root('assignment_in_condition')
            ->canBeDisabled();

        return $treeBuilder;
    }

    /**
     * @return array
     */
    public function getRegister()
    {
        return [
            If_::class,
            ElseIf_::class,
            For_::class,
            While_::class,
            Do_::class,
            Case_::class,
        ];
    }
}


1		<?php
2		/**
3		* @author Kévin Gomez https://github.com/K-Phoen <[email protected]>
4		*/
5
6		namespace PHPSA\Analyzer\Pass\Statement;
7
8		use PhpParser\Node\Expr;
9		use PhpParser\Node\Expr\Assign;
10		use PhpParser\Node\Stmt;
11		use PhpParser\Node\Stmt\Do_;
12		use PhpParser\Node\Stmt\ElseIf_;
13		use PhpParser\Node\Stmt\If_;
14		use PhpParser\Node\Stmt\Case_;
15		use PhpParser\Node\Stmt\While_;
16		use PhpParser\Node\Stmt\For_;
17		use PHPSA\Analyzer\Pass;
18		use PHPSA\Context;
19		use Symfony\Component\Config\Definition\Builder\TreeBuilder;
20
21		class AssignmentInCondition implements Pass\ConfigurablePassInterface, Pass\AnalyzerPassInterface
22		{
23		/**
24		* @param $stmt
25		* @param Context $context
26		* @return bool
27		*/
28	14	public function pass($stmt, Context $context)
29		{
30	14	$condition = $stmt->cond;
31
32	14	if ($stmt instanceof For_ && count($stmt->cond) > 0) { // For is the only one that has an array as condition
33	2	$condition = $condition[0];
34	2	}
35
36	14	if ($condition instanceof Assign) {
37	5	$context->notice(
38	5	'assignment_in_condition',
39	5	'An assignment statement has been made instead of conditional statement',
40		$stmt
41	5	);
42	5	return true;
43		}
44
45	10	return false;
46		}
47
48		/**
49		* @return TreeBuilder
50		*/
51		public function getConfiguration()
52		{
53		$treeBuilder = new TreeBuilder();
54		$treeBuilder->root('assignment_in_condition')
55		->canBeDisabled();
56
57		return $treeBuilder;
58		}
59
60		/**
61		* @return array
62		*/
63	1	public function getRegister()
64		{
65		return [
66	1	If_::class,
67	1	ElseIf_::class,
68	1	For_::class,
69	1	While_::class,
70	1	Do_::class,
71	1	Case_::class,
72	1	];
73		}
74		}
75

ovr / phpsa

Pull Request — master (#194)

AssignmentInCondition::pass() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like