Completed
Pull Request — master (#354)
by Strahinja
04:13
created

CompileCommand::execute()   D

Complexity

Conditions 17
Paths 24

Size

Total Lines 103
Code Lines 54

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 0
CRAP Score 306

Importance

Changes 0
Metric Value
cc 17
eloc 54
nc 24
nop 2
dl 0
loc 103
ccs 0
cts 55
cp 0
crap 306
rs 4.8361
c 0
b 0
f 0

How to fix   Long Method    Complexity   

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

1
<?php
2
3
namespace PHPSA\Command;
4
5
use PhpParser\ParserFactory;
6
use PHPSA\Application;
7
use PHPSA\Compiler;
8
use PHPSA\Context;
9
use PHPSA\Definition\FileParser;
10
use RecursiveDirectoryIterator;
11
use RecursiveIteratorIterator;
12
use SplFileInfo;
13
use FilesystemIterator;
14
use Symfony\Component\Console\Input\InputArgument;
15
use Symfony\Component\Console\Input\InputInterface;
16
use Symfony\Component\Console\Input\InputOption;
17
use Symfony\Component\Console\Output\OutputInterface;
18
use Webiny\Component\EventManager\EventManager;
19
20
/**
21
 * Command to run compiler on files (no analyzer)
22
 */
23
class CompileCommand extends AbstractCommand
24
{
25
    /**
26
     * {@inheritdoc}
27
     */
28 54
    protected function configure()
29
    {
30
        $this
31 54
            ->setName('compile')
32 54
            ->setDescription('Runs compiler on all files in path')
33 54
            ->addOption('config-file', null, InputOption::VALUE_REQUIRED, 'Path to the configuration file.')
34 54
            ->addArgument('path', InputArgument::OPTIONAL, 'Path to check file or directory', '.');
35 54
    }
36
37
    /**
38
     * {@inheritdoc}
39
     */
40
    protected function execute(InputInterface $input, OutputInterface $output)
0 ignored issues
show
Complexity introduced by
This operation has 3030 execution paths which exceeds the configured maximum of 200.

A high number of execution paths generally suggests many nested conditional statements and make the code less readible. This can usually be fixed by splitting the method into several smaller methods.

You can also find more information in the “Code” section of your repository.

Loading history...
41
    {
42
        $output->writeln('');
43
44
        if (extension_loaded('xdebug')) {
45
            /**
46
             * This will disable only showing stack traces on error conditions.
47
             */
48
            if (function_exists('xdebug_disable')) {
49
                xdebug_disable();
50
            }
51
52
            $output->writeln('<error>It is highly recommended to disable the XDebug extension before invoking this command.</error>');
53
        }
54
55
        /** @var Application $application */
56
        $application = $this->getApplication();
57
        $application->compiler = new Compiler();
58
59
        $configFile = $input->getOption('config-file') ?: '.phpsa.yml';
60
        $configDir = realpath($input->getArgument('path'));
61
        $application->configuration = $this->loadConfiguration($configFile, $configDir);
62
63
        $parser = $this->createParser($application);
0 ignored issues
show
Documentation introduced by
$application is of type object<PHPSA\Application>, but the function expects a string.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
64
65
        $output->writeln('Used config file: ' . $application->configuration->getPath());
66
67
        $em = EventManager::getInstance();
0 ignored issues
show
Comprehensibility introduced by
Avoid variables with short names like $em. Configured minimum length is 3.

Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum.

Loading history...
68
        $context = new Context($output, $application, $em);
69
70
        $fileParser = new FileParser(
71
            $parser,
72
            $application->compiler
73
        );
74
75
        $path = $input->getArgument('path');
76
        if (is_dir($path)) {
77
            $directoryIterator = new RecursiveIteratorIterator(
78
                new RecursiveDirectoryIterator($path, FilesystemIterator::SKIP_DOTS)
79
            );
80
            $output->writeln('Scanning directory <info>' . $path . '</info>');
81
82
            $count = 0;
83
84
            /** @var SplFileInfo $file */
85
            foreach ($directoryIterator as $file) {
86
                $skip = 0;
87
                foreach ($ignore as $item) {
0 ignored issues
show
Bug introduced by
The variable $ignore does not exist. Did you forget to declare it?

This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug.

Loading history...
88
                    $item = preg_replace('#/+#', '/', ($path . $item));
89
90
                    if (preg_match("#$item#", $file->getPathname())) {
91
                        $skip = 1;
92
                        break;
93
                    }
94
                }
95
96
                if ($file->getExtension() !== 'php' || $skip) {
97
                    continue;
98
                }
99
100
                $context->debug($file->getPathname());
101
                $count++;
102
            }
103
104
            $output->writeln("Found <info>{$count} files</info>");
105
106
            if ($count > 100) {
107
                $output->writeln('<comment>Caution: You are trying to scan a lot of files; this might be slow. For bigger libraries, consider setting up a dedicated platform or using ci.lowl.io.</comment>');
108
            }
109
110
            $output->writeln('');
111
112
            /** @var SplFileInfo $file */
113
            foreach ($directoryIterator as $file) {
114
                $skip = 0;
115
                foreach ($ignore as $item) {
116
                    $item = preg_replace('#/+#', '/', ($path . $item));
117
118
                    if (preg_match("#$item#", $file->getPathname())) {
119
                        $skip = 1;
120
                        break;
121
                    }
122
                }
123
124
                if ($file->getExtension() !== 'php' || $skip) {
125
                    continue;
126
                }
127
128
                $fileParser->parserFile($file->getPathname(), $context);
129
            }
130
        } elseif (is_file($path)) {
131
            $fileParser->parserFile($path, $context);
132
        }
133
134
135
        /**
136
         * Step 2 Recursive check ...
137
         */
138
        $application->compiler->compile($context);
139
140
        $output->writeln('');
141
        $output->writeln('Memory usage: ' . $this->getMemoryUsage(false) . ' (peak: ' . $this->getMemoryUsage(true) . ') MB');
142
    }
143
}
144