PHPSA\Compiler\Expression\StaticCall

Complexity

Total Complexity

9

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	7

Test Coverage

Coverage

51.52%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	compile()	0	39	6
A	parseArgs()	0	12	3

<?php
/**
 * PHP Smart Analysis project 2015-2016
 *
 * @author Patsura Dmitry https://github.com/ovr <talk@dmtry.me>
 */

namespace PHPSA\Compiler\Expression;

use PHPSA\CompiledExpression;
use PHPSA\Context;
use PHPSA\Definition\ClassDefinition;

class StaticCall extends AbstractExpressionCompiler
{
    protected $name = 'PhpParser\Node\Expr\StaticCall';

    /**
     * {expr}::{expr}();
     *
     * @param \PhpParser\Node\Expr\StaticCall $expr
     * @param Context $context
     * @return CompiledExpression
     */
    protected function compile($expr, Context $context)
    {
        $expressionCompiler = $context->getExpressionCompiler();
        $leftCE = $expressionCompiler->compile($expr->class);

        $this->parseArgs($expr->args, $context);

        if ($leftCE->isObject()) {
            /** @var ClassDefinition|null $classDefinition */
            $classDefinition = $leftCE->getValue();
            if ($classDefinition instanceof ClassDefinition) {
                $name = $expr->name;
                
                if (!$classDefinition->hasMethod($name, true)) {

It seems like $name defined by $expr->name on line 36 can also be of type object<PhpParser\Node\Expr>; however, PHPSA\Definition\ClassDefinition::hasMethod() does only seem to accept string, maybe add an additional type check?

                    $context->notice(
                        'language_error',
                        sprintf('Static method %s() does not exist in %s scope', $name, $expr->class),
                        $expr
                    );

                    return new CompiledExpression();
                }

                $method = $classDefinition->getMethod($name, true);
                if ($expr->class->toString() !== 'parent' && !$method->isStatic()) {

The method toString does only exist in PhpParser\Node\Name, but not in PhpParser\Node\Expr.

                    $context->notice(
                        'language_error',
                        sprintf('Method %s() is not static but was called in a static way', $name),
                        $expr
                    );
                }
            }

            return new CompiledExpression();
        }

        $context->debug('Unknown static function call', $expr);
        return new CompiledExpression();
    }


    /**
     * @param \PhpParser\Node\Arg[] $arguments
     * @param Context $context
     * @return CompiledExpression[]
     */
    protected function parseArgs(array $arguments, Context $context)
    {
        $compiled = [];

        if ($arguments) {

The expression $arguments of type PhpParser\Node\Arg[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($arguments as $argument) {
                $compiled[] = $context->getExpressionCompiler()->compile($argument->value);
            }
        }

        return $compiled;
    }
}