ReturnVoid::pass() - Code Metrics - Inspection of "Add ReturnVoid analyzer" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e0270b...8de424 )

by Дмитрий

created 2017-01-01 10:37 UTC

ReturnVoid::pass() A

↳ Parent: ReturnVoid

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	8
nc	2
nop	2
dl	0
loc	15
ccs	8
cts	8
cp	1
crap	2
rs	9.4285
c	0
b	0
f	0

<?php

namespace PHPSA\Analyzer\Pass\Statement;

use PhpParser\Node\Stmt\Return_;
use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;
use PHPSA\Analyzer\Pass;
use PHPSA\Context;

class ReturnVoid implements Pass\AnalyzerPassInterface
{
    use DefaultMetadataPassTrait;

    const DESCRIPTION = 'Checks for return void statements.';

    /**
     * @param $stmt
     * @param Context $context
     * @return bool
     */
    public function pass(Return_ $stmt, Context $context)
    {
        // this is not the value null but "no value"
        if ($stmt->expr === null) {
            $context->notice(
                'return.void',
                'You are trying to return void',
                $stmt
            );

            return true;
        }

        return false;
    }

    /**
     * @return array
     */
    public function getRegister()
    {
        return [
            Return_::class,
        ];
    }
}


1		<?php
2
3		namespace PHPSA\Analyzer\Pass\Statement;
4
5		use PhpParser\Node\Stmt\Return_;
6		use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;
7		use PHPSA\Analyzer\Pass;
8		use PHPSA\Context;
9
10		class ReturnVoid implements Pass\AnalyzerPassInterface
11		{
12		use DefaultMetadataPassTrait;
13
14		const DESCRIPTION = 'Checks for return void statements.';
15
16		/**
17		* @param $stmt
18		* @param Context $context
19		* @return bool
20		*/
21	5	public function pass(Return_ $stmt, Context $context)
22		{
23		// this is not the value null but "no value"
24	5	if ($stmt->expr === null) {
25	1	$context->notice(
26	1	'return.void',
27	1	'You are trying to return void',
28		$stmt
29	1	);
30
31	1	return true;
32		}
33
34	5	return false;
35		}
36
37		/**
38		* @return array
39		*/
40	2	public function getRegister()
41		{
42		return [
43	2	Return_::class,
44	2	];
45		}
46		}
47

ovr / phpsa

Push — master ( e0270b...8de424 )

ReturnVoid::pass() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like