for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
/**
* @author Patsura Dmitry https://github.com/ovr <[email protected]>
*/
namespace PHPSA\Analyzer\Pass\FunctionCall;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Name;
use PHPSA\Compiler\Expression;
use PHPSA\Context;
class AliasCheck implements PassFunctionCallInterface
{
protected $map = array(
'join' => 'implode',
'sizeof' => 'count'
);
public function pass(FuncCall $funcCall, Context $context)
$funcNameCompiledExpression = $context->getExpressionCompiler()->compile($funcCall->name);
$funcNameCompiledExpression
20
Very long variable names usually make code harder to read. It is therefore recommended not to make variable names too verbose.
if ($funcNameCompiledExpression->isString() && $funcNameCompiledExpression->isCorrectValue()) {
$name = $funcNameCompiledExpression->getValue();
} else {
$context->debug(
'Unexpected function name type ' . $funcNameCompiledExpression->getType(),
$funcCall->name
return false;
}
if (isset($this->map[$name])) {
$context->notice(
'fcall.alias',
sprintf('%s() is an alias of function. Use %s(...).', $name, $this->map[$name]),
$funcCall
Very long variable names usually make code harder to read. It is therefore recommended not to make variable names too verbose.