Completed
Pull Request — master (#124)
by Enrico
04:04
created

Concat::compile()   C

Complexity

Conditions 13
Paths 33

Size

Total Lines 47
Code Lines 34

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 29
CRAP Score 15.8486

Importance

Changes 2
Bugs 0 Features 0
Metric Value
cc 13
eloc 34
nc 33
nop 2
dl 0
loc 47
ccs 29
cts 39
cp 0.7436
crap 15.8486
rs 5.0999
c 2
b 0
f 0

How to fix   Complexity   

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

1
<?php
2
/**
3
 * PHP Smart Analysis project 2015-2016
4
 *
5
 * @author Patsura Dmitry https://github.com/ovr <[email protected]>
6
 */
7
8
namespace PHPSA\Compiler\Expression\Operators;
9
10
use PHPSA\CompiledExpression;
11
use PHPSA\Compiler\Expression\AbstractExpressionCompiler;
12
use PHPSA\Context;
13
use PHPSA\Compiler\Expression;
14
15
class Concat extends AbstractExpressionCompiler
16
{
17
    protected $name = 'PhpParser\Node\Expr\BinaryOp\Concat';
18
19
    /**
20
     * @param \PhpParser\Node\Expr\BinaryOp\Concat $expr
21
     * @param Context $context
22
     * @return CompiledExpression
23
     */
24 15
    protected function compile($expr, Context $context)
25
    {
26 15
        $expressionCompiler = $context->getExpressionCompiler();
27 15
        $leftExpression = $expressionCompiler->compile($expr->left);
28 15
        $rightExpression = $expressionCompiler->compile($expr->right);
29
30 15
        switch ($leftExpression->getType()) {
31 15
            case CompiledExpression::ARR:
32
                $context->notice(
33
                    'unsupported-operand-types',
34
                    'Unsupported operand types -{array}',
35
                    $expr
36
                );
37
                return new CompiledExpression();
38 15
        }
39
40 15
        switch ($rightExpression->getType()) {
41 15
            case CompiledExpression::ARR:
42
                $context->notice(
43
                    'unsupported-operand-types',
44
                    'Unsupported operand types -{array}',
45
                    $expr
46
                );
47
                return new CompiledExpression();
48 15
        }
49
50 15
        switch ($leftExpression->getType()) {
51 15
            case CompiledExpression::STRING:
52 15
            case CompiledExpression::NUMBER:
53 15
            case CompiledExpression::INTEGER:
54 15
            case CompiledExpression::DOUBLE:
55 15
            case CompiledExpression::BOOLEAN:
56 14
                switch ($rightExpression->getType()) {
57 14
                    case CompiledExpression::STRING:
58 14
                    case CompiledExpression::NUMBER:
59 14
                    case CompiledExpression::INTEGER:
60 14
                    case CompiledExpression::DOUBLE:
61 14
                    case CompiledExpression::BOOLEAN:
62 12
                        return new CompiledExpression(
63 12
                            CompiledExpression::STRING,
64 12
                            $leftExpression->getValue() . $rightExpression->getValue()
65 12
                        );
66 2
                }
67 3
        }
68
69 3
        return new CompiledExpression();
70
    }
71
}
72