PHPSA\Analyzer\Pass\FunctionCall\UseCast

Complexity

Total Complexity

6

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes	4
Bugs	0	Features	2

1 Method

Rating	Name	Duplication	Size	Complexity
B	visitPhpFunctionCall()	0	31	6

<?php
/**
 * @author Patsura Dmitry https://github.com/ovr <talk@dmtry.me>
 */

namespace PHPSA\Analyzer\Pass\FunctionCall;

use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Name;
use PHPSA\Compiler\Expression;
use PHPSA\Context;

class UseCast implements PassFunctionCallInterface
{
    protected $map = array(
        'boolval' => 'bool',
        'intval' => 'int',
        'floatval' => 'double',
        'doubleval' => 'double',
        'strval' => 'string'
    );

    public function visitPhpFunctionCall(FuncCall $funcCall, Context $context)
    {
        $compiler = new Expression($context);
        $funcNameCompiledExpression = $compiler->compile($funcCall->name);

The variable name $funcNameCompiledExpression exceeds the maximum configured length of 20.

        if ($funcNameCompiledExpression->isString() && $funcNameCompiledExpression->isCorrectValue()) {
            $name = $funcNameCompiledExpression->getValue();
        } else {
            $context->debug(
                'Unexpected function name type ' . $funcNameCompiledExpression->getType(),
                $funcCall->name
            );

            return false;
        }

        if (isset($this->map[$name])) {
            /**
             * Exclusion via intval with 2 args intval($number, int $base = 10);
             */
            if ($name == 'intval' && count($funcCall->args) > 1) {
                return;
            }

            $context->notice(
                'fcall.cast',
                sprintf('Please use (%s) cast instead of function call.', $this->map[$name]),
                $funcCall
            );
        }
    }
}