Issues in PropertyFetch.php - New Issues - Inspection of "Fix docblock bugs" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a6da0a...4e29e6 )

by Дмитрий

created 2017-02-26 06:57 UTC

src/Compiler/Expression/PropertyFetch.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace PHPSA\Compiler\Expression;

use PHPSA\Check;
use PHPSA\CompiledExpression;
use PHPSA\Context;
use PHPSA\Definition\ClassDefinition;

class PropertyFetch extends AbstractExpressionCompiler
{
    protected $name = 'PhpParser\Node\Expr\PropertyFetch';

    /**
     * classname->property
     *
     * @param \PhpParser\Node\Expr\PropertyFetch $expr
     * @param Context $context
     * @return CompiledExpression
     */
    protected function compile($expr, Context $context)
    {
        $compiler = $context->getExpressionCompiler();

        $propertNameCE = $compiler->compile($expr->name);

        $scopeExpression = $compiler->compile($expr->var);
        if ($scopeExpression->isObject()) {
            $scopeExpressionValue = $scopeExpression->getValue();
            if ($scopeExpressionValue instanceof ClassDefinition) {
                $propertyName = $propertNameCE->isString() ? $propertNameCE->getValue() : false;
                if ($propertyName) {
                    if ($scopeExpressionValue->hasProperty($propertyName, true)) {
                        $property = $scopeExpressionValue->getProperty($propertyName, true);
                        return $compiler->compile($property);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
                    } else {
                        $context->notice(
                            'language_error',
                            sprintf(
                                'Property %s does not exist in %s scope',
                                $propertyName,
                                $scopeExpressionValue->getName()
                            ),
                            $expr
                        );
                    }
                }
            }

            return new CompiledExpression();
        } elseif ($scopeExpression->canBeObject()) {
            return new CompiledExpression();
        }

        $context->notice(
            'language_error',
            "It's not possible to fetch a property on a non-object",
            $expr,
            Check::CHECK_BETA
        );

        return new CompiledExpression();
    }
}


1			<?php
2
3			namespace PHPSA\Compiler\Expression;
4
5			use PHPSA\Check;
6			use PHPSA\CompiledExpression;
7			use PHPSA\Context;
8			use PHPSA\Definition\ClassDefinition;
9
10			class PropertyFetch extends AbstractExpressionCompiler
11			{
12			protected $name = 'PhpParser\Node\Expr\PropertyFetch';
13
14			/**
15			* classname->property
16			*
17			* @param \PhpParser\Node\Expr\PropertyFetch $expr
18			* @param Context $context
19			* @return CompiledExpression
20			*/
21			protected function compile($expr, Context $context)
22			{
23			$compiler = $context->getExpressionCompiler();
24
25			$propertNameCE = $compiler->compile($expr->name);
26
27			$scopeExpression = $compiler->compile($expr->var);
28			if ($scopeExpression->isObject()) {
29			$scopeExpressionValue = $scopeExpression->getValue();
30			if ($scopeExpressionValue instanceof ClassDefinition) {
31			$propertyName = $propertNameCE->isString() ? $propertNameCE->getValue() : false;
32			if ($propertyName) {
33			if ($scopeExpressionValue->hasProperty($propertyName, true)) {
34			$property = $scopeExpressionValue->getProperty($propertyName, true);
35			return $compiler->compile($property);
			0 ignored issues – show Bug introduced 2017-02-23 17:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$property` defined by `$scopeExpressionValue->g...ty($propertyName, true)` on line `34` can be `null`; however, `PHPSA\Compiler\Expression::compile()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
36			} else {
37			$context->notice(
38			'language_error',
39			sprintf(
40			'Property %s does not exist in %s scope',
41			$propertyName,
42			$scopeExpressionValue->getName()
43			),
44			$expr
45			);
46			}
47			}
48			}
49
50			return new CompiledExpression();
51			} elseif ($scopeExpression->canBeObject()) {
52			return new CompiledExpression();
53			}
54
55			$context->notice(
56			'language_error',
57			"It's not possible to fetch a property on a non-object",
58			$expr,
59			Check::CHECK_BETA
60			);
61
62			return new CompiledExpression();
63			}
64			}
65

ovr / phpsa

Push — master ( a6da0a...4e29e6 )

src/Compiler/Expression/PropertyFetch.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like