PHPSA\ControlFlow\Visitor\UnreachableVisitor

Complexity

Total Complexity

8

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	leaveBlock()	0	3	1
B	enterBlock()	0	17	6
A	enterNode()	0	3	1

<?php
/**
 * @author Patsura Dmitry https://github.com/ovr <talk@dmtry.me>
 */

namespace PHPSA\ControlFlow\Visitor;

use PHPSA\ControlFlow\Block;
use PHPSA\ControlFlow\Node\AbstractNode;

/**
 *
 * function test($a) {
 *     return $a;
 *
 *     $a = 1; // Unreachable node!
 * }
 *
 */
class UnreachableVisitor extends AbstractVisitor
{
    /**
     * @param Block $block
     */
    public function enterBlock(Block $block)
    {
        $children = $block->getChildren();
        if ($children) {

The expression $children of type PHPSA\ControlFlow\Node\AbstractNode[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $childrenCount = count($children);
            if ($childrenCount <= 1) {
                return;
            }

            foreach ($children as $index => $child) {
                // Check that exit node is not the latest
                if ($child->willExit() && ($index + 1) != $childrenCount) {
                    echo 'Unreacheable block ' . $block->getId() . PHP_EOL;
                }
            }
        }
    }

    /**
     * @param Block $block
     */
    public function leaveBlock(Block $block)
    {
    }

    /**
     * @param AbstractNode $block
     */
    public function enterNode(AbstractNode $block)
    {
    }
}