PHPSA\Analyzer\Pass\Statement\MethodCannotReturn

Complexity

Total Complexity

7

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	1

1 Method

Rating	Name	Duplication	Size	Complexity
C	pass()	0	28	7

<?php
/**
 * @author Patsura Dmitry https://github.com/ovr <talk@dmtry.me>
 */

namespace PHPSA\Analyzer\Pass\Statement;

use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\Node\Stmt\Return_;
use PHPSA\Context;

class MethodCannotReturn
{
    /**
     * @param ClassMethod $st
     * @param Context $context
     * @return bool
     */
    public function pass(ClassMethod $st, Context $context)

Avoid variables with short names like $st. Configured minimum length is 3.

    {
        if (count($st->stmts) == 0) {
            return false;
        }

        $result = false;

        if ($st->name == '__construct' || $st->name == '__destruct') {
            foreach ($st->stmts as $stmt) {
                if ($stmt instanceof Return_) {
                    if (!$stmt->expr) {
                        continue;
                    }

                    $context->notice(
                        'return.construct',
                        sprintf('Method %s cannot return a value.', $st->name),
                        $stmt
                    );

                    $result = true;
                }
            }
        }

        return $result;
    }
}