Tests\PHPSA\Analyzer\Helper\ResolveExpressionTraitTest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	7

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	getDataProviderWithFunctionCallExpr()	0	29	1
A	testResolveFunctionName()	0	12	1

<?php
/**
 * @author Patsura Dmitry https://github.com/ovr <talk@dmtry.me>
 */

namespace Tests\PHPSA\Analyzer\Helper;

use PHPSA\Analyzer\Helper\ResolveExpressionTrait;
use PHPSA\CompiledExpression;

class ResolveExpressionTraitTest extends \Tests\PHPSA\TestCase
{
    use ResolveExpressionTrait;

    public function getDataProviderWithFunctionCallExpr()
    {
        $context = $this->getContext();
        $context->addVariable(
            new \PHPSA\Variable(
                'variableWithFunctionName',
                'testFunctionName',
                CompiledExpression::STRING
            )
        );

        return [
            [
                new \PhpParser\Node\Name(['testFn']),
                'testFn',
                $context
            ],
            [
                new \PhpParser\Node\Expr\Variable('unknown'),
                false,
                $context
            ],
            [
                new \PhpParser\Node\Expr\Variable('variableWithFunctionName'),
                'testFunctionName',
                $context
            ]
        ];
    }

    /**
     * @dataProvider getDataProviderWithFunctionCallExpr
     *
     * @param $nameExpr
     * @param $expectedFunctionName
     */
    public function testResolveFunctionName($nameExpr, $expectedFunctionName, $context)
    {
        parent::assertSame(

It seems like you call parent on a different method (assertSame() instead of testResolveFunctionName()). Are you sure this is correct? If so, you might want to change this to $this->assertSame().

            $expectedFunctionName,
            $this->resolveFunctionName(
                new \PhpParser\Node\Expr\FuncCall(
                    $nameExpr
                ),
                $context
            )
        );
    }
}