ArrayShortDefinition::visitPhpFunctionCall() - Code Metrics - Inspection of "Use one AstTraverser (base) to resolve name(s)" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 112230...88f6b9 )

by Дмитрий

created 2016-02-20 20:11 UTC

ArrayShortDefinition::visitPhpFunctionCall() B

↳ Parent: ArrayShortDefinition

Complexity

Conditions	5
Paths	4

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	16
ccs	0
cts	12
cp	0
rs	8.8571
cc	5
eloc	9
nc	4
nop	2
crap	30

<?php
/**
 * @author Patsura Dmitry https://github.com/ovr <[email protected]>
 */

namespace PHPSA\Analyzer\Pass\FunctionCall;

use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Name;
use PHPSA\Context;

class ArrayShortDefinition implements PassFunctionCallInterface
{
    public function visitPhpFunctionCall(FuncCall $funcCall, Context $context)
    {
        $name = false;

        if ($funcCall->name instanceof Name && !$funcCall->name->isFullyQualified()) {
            $name = $funcCall->name->getFirst();
        }

        if ($name && $name == 'array') {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $context->notice(
                'array.short-syntax',
                'Please use [] (short syntax) for array definition.',
                $funcCall
            );
        }
    }
}


1			<?php
2			/**
3			* @author Patsura Dmitry https://github.com/ovr <[email protected]>
4			*/
5
6			namespace PHPSA\Analyzer\Pass\FunctionCall;
7
8			use PhpParser\Node\Expr\FuncCall;
9			use PhpParser\Node\Name;
10			use PHPSA\Context;
11
12			class ArrayShortDefinition implements PassFunctionCallInterface
13			{
14			public function visitPhpFunctionCall(FuncCall $funcCall, Context $context)
15			{
16			$name = false;
17
18			if ($funcCall->name instanceof Name && !$funcCall->name->isFullyQualified()) {
19			$name = $funcCall->name->getFirst();
20			}
21
22			if ($name && $name == 'array') {
			0 ignored issues – show Bug Best Practice introduced 2016-02-20 20:13 UTC by Report Bug Copy Issue Report The expression `$name` of type `string\|false` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== false` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
23			$context->notice(
24			'array.short-syntax',
25			'Please use [] (short syntax) for array definition.',
26			$funcCall
27			);
28			}
29			}
30			}
31

ovr / phpsa

Push — master ( 112230...88f6b9 )

ArrayShortDefinition::visitPhpFunctionCall() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like