EasyWeChat\Payment\LuckyMoney\API

Complexity

Total Complexity

14

Size/Duplication

Total Lines	180
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	4
Bugs	1	Features	1

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	4	4	1
A	prepare()	13	13	1
A	query()	10	10	1
A	send()	12	12	2
A	sendNormal()	7	7	2
A	sendGroup()	7	7	2
A	setMerchant()	4	4	1
A	getMerchant()	4	4	1
A	request()	12	12	1
A	parseResponse()	8	8	2

<?php

/*
 * This file is part of the overtrue/wechat.
 *
 * (c) overtrue <i@overtrue.me>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

/**
 * API.php.
 *
 * @author    tianyong90 <412039588@qq.com>
 * @copyright 2015 overtrue <i@overtrue.me>
 *
 * @link      https://github.com/overtrue
 * @link      http://overtrue.me
 */
namespace EasyWeChat\Payment\LuckyMoney;

use EasyWeChat\Core\AbstractAPI;
use EasyWeChat\Payment\Merchant;
use EasyWeChat\Support\Collection;
use EasyWeChat\Support\XML;
use Psr\Http\Message\ResponseInterface;

/**
 * Class API.
 */
class API extends AbstractAPI

This class seems to be duplicated in your project.

This class seems to be duplicated in your project.

This class seems to be duplicated in your project.

The type EasyWeChat\Payment\LuckyMoney\API has been defined more than once; this definition is ignored, only the first definition in src/Payment/Luckymoney/API.php (L32-211) is considered.

The type EasyWeChat\Payment\LuckyMoney\API has been defined more than once; this definition is ignored, only the first definition in src/Payment/Luckymoney/API.php (L32-211) is considered.

{
    /**
     * Merchant instance.
     *
     * @var Merchant
     */
    protected $merchant;

    // api
    const API_SEND = 'https://api.mch.weixin.qq.com/mmpaymkttransfers/sendredpack';
    const API_SEND_GROUP = 'https://api.mch.weixin.qq.com/mmpaymkttransfers/sendgroupredpack';
    const API_QUERY = 'https://api.mch.weixin.qq.com/mmpaymkttransfers/gethbinfo';
    const API_PREPARE = 'https://api.mch.weixin.qq.com/mmpaymkttransfers/hbpreorder';

    // LuckyMoney type
    const TYPE_NORMAL = 'NORMAL';
    const TYPE_GROUP = 'GROUP';

    // Risk control type.
    const RISK_NORMAL = 'NORMAL';
    const RISK_IGN_FREQ_LMT = 'IGN_FREQ_LMT';
    const RISK_IGN_DAY_LMT = 'IGN_DAY_LMT';
    const RISK_IGN_FREQ_DAY_LMT = 'IGN_FREQ_DAY_LMT';

    /**
     * API constructor.
     *
     * @param \EasyWeChat\Payment\Merchant $merchant
     */
    public function __construct(Merchant $merchant)
    {
        $this->merchant = $merchant;
    }

    /**
     * Prepare luckymoney.
     *
     *
     * @return Collection
     */
    public function prepare(array $params)
    {
        $params['wxappid'] = $this->merchant->app_id;

        //This parameter is fixed and can not be changed.
        $params['auth_mchid'] = '1000052601';
        //This parameter is fixed and can not be changed.
        $params['auth_appid'] = 'wxbf42bd79c4391863';

        $params['amt_type'] = 'ALL_RAND';

        return $this->request(self::API_PREPARE, $params);
    }

    /**
     * Query luckymoney.
     *
     * @param string $mchBillNo

There is no parameter named $mchBillNo. Was it maybe removed?

There is no parameter named $mchBillNo. Was it maybe removed?

There is no parameter named $mchBillNo. Was it maybe removed?

     */
    public function query($orderNo)
    {
        $params = [
            'appid' => $this->merchant->app_id,
            'mch_billno' => $orderNo,
            'bill_type' => 'MCHT',
        ];

        return $this->request(self::API_QUERY, $params);
    }

    /**
     * Send Luckymoney.
     *
     * @param array  $params
     * @param string $type
     */
    public function send(array $params, $type = self::TYPE_NORMAL)
    {
        if ($type === self::TYPE_NORMAL) {
            $api = self::API_SEND;
        } else {
            $api = self::API_SEND_GROUP;
        }

        $params['wxappid'] = $this->merchant->app_id;

        return $this->request($api, $params);
    }

    /**
     * Send normal lucnymoney.
     *
     * @param array $params
     *
     * @return Collection
     */
    public function sendNormal($params)

sendNormal uses the super-global variable $_SERVER which is generally not recommended.

sendNormal uses the super-global variable $_SERVER which is generally not recommended.

sendNormal uses the super-global variable $_SERVER which is generally not recommended.

    {
        $params['total_num'] = 1;
        $params['client_ip'] = $params['client_ip'] ?: $_SERVER['HTTP_CLIENT_IP'];

        return $this->send($params, self::TYPE_NORMAL);
    }

    /**
     * Send group luckymoney.
     *
     * @param array $params
     *
     * @return Collection
     */
    public function sendGroup($params)

sendGroup uses the super-global variable $_SERVER which is generally not recommended.

sendGroup uses the super-global variable $_SERVER which is generally not recommended.

sendGroup uses the super-global variable $_SERVER which is generally not recommended.

    {
        $params['amt_type'] = 'ALL_RAND';
        $params['client_ip'] = $params['client_ip'] ?: $_SERVER['HTTP_CLIENT_IP'];

        return $this->send($params, self::TYPE_GROUP);
    }

    /**
     * Merchant setter.
     *
     * @param Merchant $merchant
     *
     * @return $this
     */
    public function setMerchant(Merchant $merchant)
    {
        $this->merchant = $merchant;
    }

    /**
     * Merchant getter.
     *
     * @return Merchant
     */
    public function getMerchant()
    {
        return $this->merchant;
    }

    /**
     * Make a API request.
     *
     * @param string $api
     * @param array  $params
     * @param string $method
     *
     * @return Collection
     */
    protected function request($api, array $params, $method = 'post')
    {
        $params['mch_id'] = $this->merchant->merchant_id;
        $params['nonce_str'] = uniqid();
        $params['sign'] = \EasyWeChat\Payment\generate_sign($params, $this->merchant->key, 'md5');

        $options['body'] = XML::build($params);

$options was never initialized. Although not strictly required by PHP, it is generally a good practice to add $options = array(); before regardless.

$options was never initialized. Although not strictly required by PHP, it is generally a good practice to add $options = array(); before regardless.

$options was never initialized. Although not strictly required by PHP, it is generally a good practice to add $options = array(); before regardless.

        $options['cert'] = $this->merchant->get('cert_path');
        $options['ssl_key'] = $this->merchant->get('key_path');

        return $this->parseResponse($this->getHttp()->request($api, $method, $options));

$this->getHttp()->request($api, $method, $options) is of type object<Psr\Http\Message\ResponseInterface>, but the function expects a string.

$this->getHttp()->request($api, $method, $options) is of type object<Psr\Http\Message\ResponseInterface>, but the function expects a string.

$this->getHttp()->request($api, $method, $options) is of type object<Psr\Http\Message\ResponseInterface>, but the function expects a string.

    }

    /**
     * Parse Response XML to array.
     *
     * @param string $response
     *
     * @return Collection
     */
    protected function parseResponse($response)
    {
        if ($response instanceof ResponseInterface) {
            $response = $response->getBody();
        }

        return new Collection((array) XML::parse($response));
    }
}