Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 31 | class Transformer |
||
| 32 | { |
||
| 33 | /** |
||
| 34 | * transform message to XML. |
||
| 35 | * |
||
| 36 | * @param array|string|AbstractMessage $message |
||
| 37 | * |
||
| 38 | * @return array |
||
| 39 | */ |
||
| 40 | 10 | View Code Duplication | public function transform($message) |
| 41 | { |
||
| 42 | 10 | if (is_array($message)) { |
|
| 43 | 1 | $class = News::class; |
|
| 44 | } else { |
||
| 45 | 10 | if (is_string($message)) { |
|
| 46 | 1 | $message = new Text(['content' => $message]); |
|
| 47 | } |
||
| 48 | |||
| 49 | 10 | $class = get_class($message); |
|
| 50 | } |
||
| 51 | |||
| 52 | 10 | $handle = 'transform'.substr($class, strlen('EasyWeChat\Message\\')); |
|
| 53 | |||
| 54 | 10 | return method_exists($this, $handle) ? $this->$handle($message) : []; |
|
| 55 | } |
||
| 56 | |||
| 57 | /** |
||
| 58 | * Transform text message. |
||
| 59 | * |
||
| 60 | * @return array |
||
| 61 | */ |
||
| 62 | 5 | public function transformText(AbstractMessage $message) |
|
| 68 | |||
| 69 | /** |
||
| 70 | * Transform image message. |
||
| 71 | * |
||
| 72 | * @return array |
||
| 73 | */ |
||
| 74 | 1 | public function transformImage(AbstractMessage $message) |
|
| 75 | { |
||
| 76 | return [ |
||
| 77 | 'Image' => [ |
||
| 78 | 1 | 'MediaId' => $message->get('media_id'), |
|
| 79 | ], |
||
| 80 | ]; |
||
| 81 | } |
||
| 82 | |||
| 83 | /** |
||
| 84 | * Transform video message. |
||
| 85 | * |
||
| 86 | * @return array |
||
| 87 | */ |
||
| 88 | 1 | public function transformVideo(AbstractMessage $message) |
|
| 89 | { |
||
| 90 | $response = [ |
||
| 91 | 'Video' => [ |
||
| 92 | 1 | 'MediaId' => $message->get('media_id'), |
|
| 93 | 1 | 'Title' => $message->get('title'), |
|
| 94 | 1 | 'Description' => $message->get('description'), |
|
| 95 | ], |
||
| 96 | ]; |
||
| 97 | |||
| 98 | 1 | return $response; |
|
| 99 | } |
||
| 100 | |||
| 101 | /** |
||
| 102 | * Transform music message. |
||
| 103 | * |
||
| 104 | * @return array |
||
| 105 | */ |
||
| 106 | public function transformMusic(AbstractMessage $message) |
||
| 107 | { |
||
| 108 | $response = [ |
||
| 109 | 'Music' => [ |
||
| 110 | 'Title' => $message->get('title'), |
||
| 111 | 'Description' => $message->get('description'), |
||
| 112 | 'MusicUrl' => $message->get('url'), |
||
| 113 | 'HQMusicUrl' => $message->get('hq_url'), |
||
| 114 | 'ThumbMediaId' => $message->get('thumb_media_id'), |
||
| 115 | ], |
||
| 116 | ]; |
||
| 117 | |||
| 118 | return $response; |
||
| 119 | } |
||
| 120 | |||
| 121 | /** |
||
| 122 | * Transform voice message. |
||
| 123 | * |
||
| 124 | * @return array |
||
| 125 | */ |
||
| 126 | 1 | public function transformVoice(AbstractMessage $message) |
|
| 127 | { |
||
| 128 | return [ |
||
| 129 | 'Voice' => [ |
||
| 130 | 1 | 'MediaId' => $message->get('media_id'), |
|
| 131 | ], |
||
| 132 | ]; |
||
| 133 | } |
||
| 134 | |||
| 135 | /** |
||
| 136 | * Transform transfer message. |
||
| 137 | * |
||
| 138 | * @return array |
||
| 139 | */ |
||
| 140 | 1 | public function transformTransfer(AbstractMessage $message) |
|
| 153 | |||
| 154 | /** |
||
| 155 | * Transform news message. |
||
| 156 | * |
||
| 157 | * @param array|\EasyWeChat\Message\News $news |
||
| 158 | * |
||
| 159 | * @return array |
||
| 160 | */ |
||
| 161 | 1 | View Code Duplication | public function transformNews($news) |
| 162 | { |
||
| 163 | 1 | $articles = []; |
|
| 164 | |||
| 165 | 1 | if (!is_array($news)) { |
|
| 166 | 1 | $news = [$news]; |
|
| 167 | } |
||
| 168 | |||
| 169 | 1 | foreach ($news as $item) { |
|
| 170 | 1 | $articles[] = [ |
|
| 171 | 1 | 'Title' => $item->get('title'), |
|
| 172 | 1 | 'Description' => $item->get('description'), |
|
| 173 | 1 | 'Url' => $item->get('url'), |
|
| 174 | 1 | 'PicUrl' => $item->get('pic_url'), |
|
| 175 | ]; |
||
| 176 | } |
||
| 177 | |||
| 178 | return [ |
||
| 179 | 1 | 'ArticleCount' => count($articles), |
|
| 180 | 1 | 'Articles' => $articles, |
|
| 181 | ]; |
||
| 182 | } |
||
| 183 | |||
| 184 | public function transformDeviceText(AbstractMessage $message) |
||
| 195 | } |
||
| 196 |