MediaPress::mediaPress() - Code Metrics - Inspection of "新增图文消息留言管理接口" - overtrue/wechat - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#716)

by mingyoung

created 2017-05-26 15:37 UTC

MediaPress::mediaPress() A

↳ Parent: MediaPress

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2.0625

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	4
c	1
b	0
f	0
nc	2
nop	0
dl	0
loc	8
rs	9.4285
ccs	3
cts	4
cp	0.75
crap	2.0625

<?php

/*
 * This file is part of the overtrue/wechat.
 *
 * (c) overtrue <[email protected]>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

/**
 * MediaPress.php.
 *
 * Part of Overtrue\WeChat.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @author    mingyoung <[email protected]>
 * @copyright 2017
 *
 * @see      https://github.com/overtrue
 * @see      http://overtrue.me
 */

namespace EasyWeChat\MediaPress;

use EasyWeChat\Core\AbstractAPI;
use EasyWeChat\Core\Exceptions\InvalidArgumentException;

class MediaPress extends AbstractAPI
{
    use ManageComments, ManageCommentReplies;

    const API_OPEN_COMMENT = 'https://api.weixin.qq.com/cgi-bin/comment/open';
    const API_CLOSE_COMMENT = 'https://api.weixin.qq.com/cgi-bin/comment/close';
    const API_LIST_COMMENT = 'https://api.weixin.qq.com/cgi-bin/comment/list';
    const API_MARK_ELECT = 'https://api.weixin.qq.com/cgi-bin/comment/markelect';
    const API_UNMARK_ELECT = 'https://api.weixin.qq.com/cgi-bin/comment/unmarkelect';
    const API_DELETE_COMMENT = 'https://api.weixin.qq.com/cgi-bin/comment/delete';
    const API_REPLY_COMMENT = 'https://api.weixin.qq.com/cgi-bin/comment/reply/add';
    const API_DELETE_REPLY = 'https://api.weixin.qq.com/cgi-bin/comment/reply/delete';

    /**
     * @var array
     */
    protected $mediaPress;

    /**
     * Select an article.
     *
     * @param int $dataId
     * @param int $index
     *
     * @return $this
     */
    public function select($dataId, $index = null)
    {
        $this->mediaPress = [
            'msg_data_id' => $dataId,
            'index' => $index,
        ];

        return $this;
    }

    /**
     * Return the media-press.
     *
     * @return array
     *
     * @throws \EasyWeChat\Core\Exceptions\InvalidArgumentException
     */
    protected function mediaPress()

    {
        if ($this->mediaPress) {

            return $this->mediaPress;
        }

        throw new InvalidArgumentException('Missing media-press data.');
    }
}


1		<?php
2
3		/*
4		* This file is part of the overtrue/wechat.
5		*
6		* (c) overtrue <[email protected]>
7		*
8		* This source file is subject to the MIT license that is bundled
9		* with this source code in the file LICENSE.
10		*/
11
12		/**
13		* MediaPress.php.
14		*
15		* Part of Overtrue\WeChat.
16		*
17		* For the full copyright and license information, please view the LICENSE
18		* file that was distributed with this source code.
19		*
20		* @author mingyoung <[email protected]>
21		* @copyright 2017
22		*
23		* @see https://github.com/overtrue
24		* @see http://overtrue.me
25		*/
26
27		namespace EasyWeChat\MediaPress;
28
29		use EasyWeChat\Core\AbstractAPI;
30		use EasyWeChat\Core\Exceptions\InvalidArgumentException;
31
32		class MediaPress extends AbstractAPI
33		{
34		use ManageComments, ManageCommentReplies;
35
36		const API_OPEN_COMMENT = 'https://api.weixin.qq.com/cgi-bin/comment/open';
37		const API_CLOSE_COMMENT = 'https://api.weixin.qq.com/cgi-bin/comment/close';
38		const API_LIST_COMMENT = 'https://api.weixin.qq.com/cgi-bin/comment/list';
39		const API_MARK_ELECT = 'https://api.weixin.qq.com/cgi-bin/comment/markelect';
40		const API_UNMARK_ELECT = 'https://api.weixin.qq.com/cgi-bin/comment/unmarkelect';
41		const API_DELETE_COMMENT = 'https://api.weixin.qq.com/cgi-bin/comment/delete';
42		const API_REPLY_COMMENT = 'https://api.weixin.qq.com/cgi-bin/comment/reply/add';
43		const API_DELETE_REPLY = 'https://api.weixin.qq.com/cgi-bin/comment/reply/delete';
44
45		/**
46		* @var array
47		*/
48		protected $mediaPress;
49
50		/**
51		* Select an article.
52		*
53		* @param int $dataId
54		* @param int $index
55		*
56		* @return $this
57		*/
58	8	public function select($dataId, $index = null)
59		{
60	8	$this->mediaPress = [
61	8	'msg_data_id' => $dataId,
62	8	'index' => $index,
63		];
64
65	8	return $this;
66		}
67
68		/**
69		* Return the media-press.
70		*
71		* @return array
72		*
73		* @throws \EasyWeChat\Core\Exceptions\InvalidArgumentException
74		*/
75	8	protected function mediaPress()
		0 ignored issues – show Best Practice introduced 2017-05-26 15:23 UTC by Report Bug Copy Issue Report Using PHP4-style constructors that are named like the class is not recommend; better use the more explicit `__construct` method. Loading history...
76		{
77	8	if ($this->mediaPress) {
		0 ignored issues – show Bug Best Practice introduced 2017-05-26 15:23 UTC by Report Bug Copy Issue Report The expression `$this->mediaPress` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
78	8	return $this->mediaPress;
79		}
80
81		throw new InvalidArgumentException('Missing media-press data.');
82		}
83		}
84

overtrue / wechat

Pull Request — master (#716)

MediaPress::mediaPress() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like