Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 31 | class Transformer |
||
| 32 | { |
||
| 33 | /** |
||
| 34 | * transform message to XML. |
||
| 35 | * |
||
| 36 | * @param array|string|AbstractMessage $message |
||
| 37 | * |
||
| 38 | * @return array |
||
| 39 | */ |
||
| 40 | 7 | View Code Duplication | public function transform($message) |
| 56 | |||
| 57 | /** |
||
| 58 | * Transform text message. |
||
| 59 | * |
||
| 60 | * @return array |
||
| 61 | */ |
||
| 62 | 2 | public function transformText(AbstractMessage $message) |
|
| 71 | |||
| 72 | /** |
||
| 73 | * Transform image message. |
||
| 74 | * |
||
| 75 | * @return array |
||
| 76 | */ |
||
| 77 | 1 | public function transformImage(AbstractMessage $message) |
|
| 86 | |||
| 87 | /** |
||
| 88 | * Transform music message. |
||
| 89 | * |
||
| 90 | * @return array |
||
| 91 | */ |
||
| 92 | public function transformMusic(AbstractMessage $message) |
||
| 105 | |||
| 106 | /** |
||
| 107 | * Transform video message. |
||
| 108 | * |
||
| 109 | * @return array |
||
| 110 | */ |
||
| 111 | 1 | public function transformVideo(AbstractMessage $message) |
|
| 123 | |||
| 124 | /** |
||
| 125 | * Transform voice message. |
||
| 126 | * |
||
| 127 | * @return array |
||
| 128 | */ |
||
| 129 | 1 | public function transformVoice(AbstractMessage $message) |
|
| 138 | |||
| 139 | /** |
||
| 140 | * Transform articles message. |
||
| 141 | * |
||
| 142 | * @return array |
||
| 143 | */ |
||
| 144 | 1 | View Code Duplication | public function transformNews($news) |
| 163 | |||
| 164 | /** |
||
| 165 | * Transform material message. |
||
| 166 | * |
||
| 167 | * @return array |
||
| 168 | */ |
||
| 169 | View Code Duplication | public function transformMaterial(AbstractMessage $message) |
|
| 180 | |||
| 181 | /** |
||
| 182 | * Transform wxcard message. |
||
| 183 | * |
||
| 184 | * @return array |
||
| 185 | */ |
||
| 186 | View Code Duplication | public function transformCard(AbstractMessage $message) |
|
| 197 | } |
||
| 198 |