LuckMoney - Code Metrics - Inspection of "Merge branch '2.1'" - overtrue/wechat - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( c335f0 )

by Carlos
created 2016-01-02 12:49 UTC
LuckMoney A

↳ Parent: Project
Complexity

Total Complexity
Size/Duplication

Total Lines	289
Duplicated Lines	0 %
Coupling/Cohesion

Components	1
Dependencies	5
Importance

Changes	2
Bugs	0	Features	0
Metric	Value
wmc	16
c	2
b	0
f	0
lcom	1
cbo	5
dl	0
loc	289
rs	10
7 Methods

Rating	Name	Size	Complexity
A	__construct()	6	2
A	setBusiness()	7	2
B	preOrder()	41	2
B	send()	48	5
A	sendNormal()	4	1
A	sendGroup()	4	1
B	query()	38	3
<?php
/**
 * LuckMoney.php
 *
 * Part of Overtrue\Wechat.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @author bontian <[email protected]>
 *
 */

namespace Overtrue\Wechat;

use Overtrue\Wechat\Exception;
use Overtrue\Wechat\Payment\Business;
use Overtrue\Wechat\Utils\XML;
use Overtrue\Wechat\Utils\SignGenerator;
use Overtrue\Wechat\Http;

class LuckMoney
{
    /**
     * 发送现金红包
     */
    const API_SEND = 'https://api.mch.weixin.qq.com/mmpaymkttransfers/sendredpack';

    /**
     * 发送裂变红包
     */
    const API_GROUP_SEND = 'https://api.mch.weixin.qq.com/mmpaymkttransfers/sendgroupredpack';

    /**
     * 红包查询
     */
    const API_QUERY = 'https://api.mch.weixin.qq.com/mmpaymkttransfers/gethbinfo';

    /**
     * 红包预下单接口
     */
    const API_PREORDER = 'https://api.mch.weixin.qq.com/mmpaymkttransfers/hbpreorder';

    const TYPE_CASH_LUCK_MONEY = 'NORMAL';   //红包类型，现金红包
    const TYPE_GROUP_LUCK_MONEY = 'GROUP';  //红包类型，裂变红包



    /**
     * 商户信息
     *
     * @var Business
     */
    protected $business;

    public function __construct(Business $business)
    {
        if (!is_null($business)) {
            $this->setBusiness($business);
        }
    }

    /**
     * 设置商户
     *
     * @param Business $business
     *
     * @return $this
     */
    public function setBusiness(Business $business)
    {
        if (!is_null($business)) {
            $this->business = $business;
        }
        return $this;
    }

    /**
     * 红包预下单，主要用于摇一摇红包活动
     *
     * <pre>
     * $data:
     * {
     *     "mch_billno": "198374613512",
     *     "send_name":"某某公司",
     *     "hb_type":"某某公司",
     *     "total_amount": 1000,
     *     "total_num": 1,
     *     "wishing": "祝福语",
     *     "act_name": "活动名称",
     *     "remark": "红包备注"，
     *     "risk_cntl": "NORMAL"，
     * }
     * </pre>
     *
     * @param array $data
     *
     * @return array
     */
    public function preOrder(array $data)
    {
        $defaultParam['nonce_str'] = uniqid('pre_');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $defaultParam['mch_id'] = $this->business->mch_id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $defaultParam['wxappid'] = $this->business->appid;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        //用于发红包时微信支付识别摇周边红包，所有开发者统一填写摇周边平台的商户号：1000052601
        $defaultParam['auth_mchid'] = '1000052601';
        //用于发红包时微信支付识别摇周边红包，所有开发者统一填写摇周边平台的appid:wxbf42bd79c4391863
        $defaultParam['auth_appid'] = 'wxbf42bd79c4391863';

        $defaultParam['amt_type'] = 'ALL_RAND';

        $param = array_merge($data, $defaultParam);
        $signGenerator = new SignGenerator($param);
        $me = $this;
        $signGenerator->onSortAfter(function (SignGenerator $that) use ($me) {
            $that->key = $me->business->mch_key;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        });

        $sign = $signGenerator->getResult();
        $param['sign'] = $sign;

        $request = XML::build($param);

        //设置Http使用的证书
        $options['sslcert_path'] = $this->business->getClientCert();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $options['sslkey_path'] = $this->business->getClientKey();

        $http = new Http();

        $response = $http->request(self::API_PREORDER, Http::POST, $request, $options);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        if (empty($response)) {
            throw new Exception('Create PreOrder failed.');
        }

        $result = XML::parse($response);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        return $result;
    }

    /**
     * 发送红包
     *
     * <pre>
     * $data:
     * {
     *     "mch_billno": "198374613512",
     *     "send_name":"某某公司",
     *     "re_openid": "oJCvDjjQKx5LMtM_1kjK0gGQLsew",
     *     "total_amount": 1000,
     *     "wishing": "祝福语",
     *     "act_name": "活动名称",
     *     "total_num": 1,
     *     "remark": "红包备注"
     * }
     * </pre>
     *
     * @param array $data
     * @param int   $type
     *
     * @return array
     */
    public function send(array $data, $type = self::TYPE_CASH_LUCK_MONEY)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $defaultParam['nonce_str'] = uniqid('pre_');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $defaultParam['mch_id'] = $this->business->mch_id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $defaultParam['wxappid'] = $this->business->appid;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        if ($type == self::TYPE_CASH_LUCK_MONEY) {
            $defaultParam['client_ip'] = $_SERVER['REMOTE_ADDR'];
        }

        if ($type == self::TYPE_GROUP_LUCK_MONEY) {
            $defaultParam['amt_type'] = 'ALL_RAND';
        }

        $param = array_merge($data, $defaultParam);
        $signGenerator = new SignGenerator($param);
        $me = $this;
        $signGenerator->onSortAfter(function (SignGenerator $that) use ($me) {
            $that->key = $me->business->mch_key;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        });

        $sign = $signGenerator->getResult();
        $param['sign'] = $sign;

        $request = XML::build($param);

        //设置Http使用的证书
        $options['sslcert_path'] = $this->business->getClientCert();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $options['sslkey_path'] = $this->business->getClientKey();

        $http = new Http();

        //根据红包类型决定调用的API
        if ($type == self::TYPE_CASH_LUCK_MONEY) {
            $url = self::API_SEND;
        } else {
            $url = self::API_GROUP_SEND;
        }
        $response = $http->request($url, Http::POST, $request, $options);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        if (empty($response)) {
            throw new Exception('Send LuckMoney failed.');
        }

        $result = XML::parse($response);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        return $result;
    }

    /**
     * 发送普通红包
     *
     * <pre>
     * $data:
     * {
     *     "mch_billno": "198374613512",
     *     "send_name":"某某公司",
     *     "re_openid": "oJCvDjjQKx5LMtM_1kjK0gGQLsew",
     *     "total_amount": 1000,
     *     "wishing": "祝福语",
     *     "act_name": "活动名称",
     *     "total_num": 1,
     *     "remark": "红包备注"
     * }
     * </pre>
     *
     * @param array $data
     *
     * @return array
     */
    public function sendNormal(array $data)
    {
        return $this->send($data, self::TYPE_CASH_LUCK_MONEY);
    }

    /**
     * 发送裂变红包
     *
     * <pre>
     * $data:
     * {
     *     "mch_billno": "198374613512",
     *     "send_name":"某某公司",
     *     "re_openid": "oJCvDjjQKx5LMtM_1kjK0gGQLsew",
     *     "total_amount": 1000,
     *     "wishing": "祝福语",
     *     "act_name": "活动名称",
     *     "total_num": 1,
     *     "remark": "红包备注"
     * }
     * </pre>
     *
     * @param array $data
     *
     * @return array
     */
    public function sendGroup(array $data)
    {
        return $this->send($data, self::TYPE_GROUP_LUCK_MONEY);
    }

    /**
     * 查询红包信息
     *
     * @param string $mchBillNumber
     *
     * @return array
     */
    public function query($mchBillNumber)
    {
        if (empty($mchBillNumber)) {
            throw new Exception('mch_id is required');
        }

        $param['mch_billno'] = $mchBillNumber;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $param['nonce_str'] = uniqid('pre_');
        $param['mch_id'] = $this->business->mch_id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $param['appid'] = $this->business->appid;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $param['bill_type'] = 'MCHT';

        $signGenerator = new SignGenerator($param);
        $me = $this;
        $signGenerator->onSortAfter(function (SignGenerator $that) use ($me) {
            $that->key = $me->business->mch_key;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        });

        $sign = $signGenerator->getResult();
        $param['sign'] = $sign;

        $request = XML::build($param);

        //设置Http使用的证书
        $options['sslcert_path'] = $this->business->getClientCert();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $options['sslkey_path'] = $this->business->getClientKey();

        $http = new Http();
        $response = $http->request(static::API_QUERY, Http::POST, $request, $options);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        if (empty($response)) {
            throw new Exception('Get LuckMoneyInfo failed.');
        }

        $result = XML::parse($response);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        return $result;
    }
}

1			<?php
2			/**
3			* LuckMoney.php
4			*
5			* Part of Overtrue\Wechat.
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*
10			* @author bontian <[email protected]>
11			*
12			*/
13
14			namespace Overtrue\Wechat;
15
16			use Overtrue\Wechat\Exception;
17			use Overtrue\Wechat\Payment\Business;
18			use Overtrue\Wechat\Utils\XML;
19			use Overtrue\Wechat\Utils\SignGenerator;
20			use Overtrue\Wechat\Http;
21
22			class LuckMoney
23			{
24			/**
25			* 发送现金红包
26			*/
27			const API_SEND = 'https://api.mch.weixin.qq.com/mmpaymkttransfers/sendredpack';
28
29			/**
30			* 发送裂变红包
31			*/
32			const API_GROUP_SEND = 'https://api.mch.weixin.qq.com/mmpaymkttransfers/sendgroupredpack';
33
34			/**
35			* 红包查询
36			*/
37			const API_QUERY = 'https://api.mch.weixin.qq.com/mmpaymkttransfers/gethbinfo';
38
39			/**
40			* 红包预下单接口
overtrue / wechat

Push — master ( c335f0 )

LuckMoney A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

Duplication Side-by-Side

Filter issues like
