Refund::getResponse() - Code Metrics - Inspection of "Applied fixes from StyleCI" - overtrue/wechat - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#200)

by Carlos

created 2016-01-02 12:50 UTC

Refund::getResponse() C

↳ Parent: Refund

Complexity

Conditions	12
Paths	8

Size

Total Lines	59
Code Lines	37

Duplication

Lines	12
Ratio	20.34 %

Importance

Changes	4
Bugs	1	Features	1

Metric	Value
c	4
b	1
f	1
dl	12
loc	59
rs	6.4485
cc	12
eloc	37
nc	8
nop	0

How to fix Long Method Complexity

<?php
/**
 * Refund.php
 *
 * Part of Overtrue\Wechat.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @author    jaring <[email protected]>
 *
 *
 *Usage:
 *   $business = new Business($appId, $appSecret, $mchId, $mchKey);
 *   $business->setClientCert(dirname(__FILE__).'/cert/apiclient_cert.pem');
 *   $business->setClientKey(dirname(__FILE__).'/cert/apiclient_key.pem');
 *   $refund =new Refund($business);
 *   $refund->out_refund_no= md5(uniqid(microtime()));//退单单号
 *   $refund->total_fee=1; //订单金额
 *   $refund->refund_fee=1;//退款金额
 *   $refund->out_trade_no=$order_id;//原商户订单号
 *   var_dump($trans->getResponse());
*/
namespace Overtrue\Wechat\Payment;

use Overtrue\Wechat\Utils\XML;
use Overtrue\Wechat\Utils\SignGenerator;
use Overtrue\Wechat\Http;

class Refund
{
    /**
     * 退款接口链接：https://api.mch.weixin.qq.com/secapi/pay/refund
     */
    const REFUNDORDER_URL = 'https://api.mch.weixin.qq.com/secapi/pay/refund';

    /**
     * 商户信息
     * 
     * @var Business
     */
    protected $business;

    /**
     * 退款订单必填项
     *
     * @var array
     */
    protected static $required = array('out_refund_no', 'total_fee', 'refund_fee');

    /**
     * 退款订单选填项
     *
     * @var array
     */
    protected static $optional = array('out_trade_no', 'transaction_id', 'device_info', 'fee_type', 'op_user_id');

    /**
     * @var array
     */
    protected static $params      = array();
    protected static $allowParams = array();

    /**
     * 退款返回信息
     *
     * @var array
     */
    protected $refundInfo = null;

    public function __construct(Business $business = null)
    {
        if (!is_null($business)) {
            $this->setBusiness($business);
        }
        if (count(static::$allowParams) === 0) {
            static::$allowParams = array_merge(static::$required, static::$optional);
        }
    }

    /**
     * 设置商户
     * 
     * @param Business $business
     *
     * @return $this
     *
     * @throws Exception
     */
    public function setBusiness(Business $business)

    {
        if (!is_null($business)) {
            try {
                $business->checkParams();
            } catch (Exception $e) {
                throw new Exception($e->getMessage());
            }
            $this->business   = $business;
            $this->refundInfo = null;

        }

        return $this;
    }

    /**
     * 获取商户
     * 
     * @return Business
     */
    public function getBusiness()
    {
        return $this->business;
    }

    /**
     * 获取退款结果
     *
     * @return array
     *
     * @throws Exception
     */
    public function getResponse()
    {
        if (is_null($this->business)) {
            throw new Exception('Business is required');
        }

        static::$params['appid']    = $this->business->appid;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        static::$params['mch_id']   = $this->business->mch_id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->checkParams();
        $signGenerator = new SignGenerator(static::$params);
        $signGenerator->onSortAfter(function (SignGenerator $that) {
            $that->key = $this->business->mch_key;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        });
        static::$params['sign'] = $signGenerator->getResult();

        $request = XML::build(static::$params);
        //设置Http使用的证书
        $options['sslcert_path'] = $this->business->getClientCert();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $options['sslkey_path']  = $this->business->getClientKey();

        $http     = new Http();
        $response = $http->request(static::REFUNDORDER_URL, Http::POST, $request, $options);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        if (empty($response)) {
            throw new Exception('Get Refund Failure:');
        }
        $refundOrder = XML::parse($response);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        if (isset($refundOrder['return_code']) &&

            $refundOrder['return_code'] === 'FAIL') {
            throw new Exception($refundOrder['return_code'].': '.$refundOrder['return_msg']);
        }

        //返回签名数据校验
        if (empty($refundOrder) || empty($refundOrder['sign'])) {
            throw new Exception('param sign is missing or empty');
        }
        $sign = $refundOrder['sign'];
        unset($refundOrder['sign']);
        $signGenerator = new SignGenerator($refundOrder);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $signGenerator->onSortAfter(function (SignGenerator $that) {
            $that->key = $this->business->mch_key;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        });
        if ($sign !== $signGenerator->getResult()) {
            throw new Exception('check sign error');
        }

        //返回结果判断
        if (isset($refundOrder['result_code']) &&

            ($refundOrder['result_code'] === 'FAIL')) {
            throw new Exception($refundOrder['err_code'].': '.$refundOrder['err_code_des']);
        }

        if (isset($refundOrder['return_code']) &&

            $refundOrder['return_code'] === 'FAIL') {
            throw new Exception($refundOrder['return_code'].': '.$refundOrder['return_msg']);
        }

        return $this->refundInfo = $refundOrder;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    /**
     * 检测参数值是否有效
     *
     * @throws Exception
     */
    public function checkParams()
    {
        foreach (static::$required as $paramName) {
            if (!array_key_exists($paramName, static::$params)) {
                throw new Exception(sprintf('"%s" is required', $paramName));
            }
        }

        if (!array_key_exists('transaction_id', static::$params) && !array_key_exists('out_trade_no', static::$params)) {
            throw new Exception('transaction_id or out_trade_no is required');
        }

        if (!array_key_exists('nonce_str', static::$params)) {
            static::$params['nonce_str'] = md5(uniqid(microtime()));
        }

        if (!array_key_exists('op_user_id', static::$params)) {
            static::$params['op_user_id'] = $this->business->mch_id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
    }

    public function __set($property, $value)

    {
        if (!in_array($property, static::$allowParams, true)) {
            throw new Exception(sprintf('"%s" is not required', $property));
        }

        return static::$params[$property] = $value;
    }
}


1			<?php
2			/**
3			* Refund.php
4			*
5			* Part of Overtrue\Wechat.
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*
10			* @author jaring <[email protected]>
11			*
12			*
13			*Usage:
14			* $business = new Business($appId, $appSecret, $mchId, $mchKey);
15			* $business->setClientCert(dirname(__FILE__).'/cert/apiclient_cert.pem');
16			* $business->setClientKey(dirname(__FILE__).'/cert/apiclient_key.pem');
17			* $refund =new Refund($business);
18			* $refund->out_refund_no= md5(uniqid(microtime()));//退单单号
19			* $refund->total_fee=1; //订单金额
20			* $refund->refund_fee=1;//退款金额
21			* $refund->out_trade_no=$order_id;//原商户订单号
22			* var_dump($trans->getResponse());
23			*/
24			namespace Overtrue\Wechat\Payment;
25
26			use Overtrue\Wechat\Utils\XML;
27			use Overtrue\Wechat\Utils\SignGenerator;
28			use Overtrue\Wechat\Http;
29
30			class Refund
31			{
32			/**
33			* 退款接口链接：https://api.mch.weixin.qq.com/secapi/pay/refund
34			*/
35			const REFUNDORDER_URL = 'https://api.mch.weixin.qq.com/secapi/pay/refund';
36
37			/**
38			* 商户信息
39			*
40			* @var Business

overtrue / wechat

Pull Request — master (#200)

Refund::getResponse() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like