Guard::shouldReturnRawResponse() - Code Metrics - Inspection of "企业微信服务商" - overtrue/wechat - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1278)

unknown

created 2018-06-28 14:20 UTC

Guard::shouldReturnRawResponse() A

↳ Parent: Guard

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php

/*
 * This file is part of the overtrue/wechat.
 *
 * (c) overtrue <[email protected]>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace EasyWeChat\OpenWork\Server;

use EasyWeChat\Kernel\ServerGuard;

/**
 * Guard.
 *
 * @author xiaomin <[email protected]>
 */
class Guard extends ServerGuard
{
    /**
     * @var bool
     */
    protected $alwaysValidate = true;

    /**
     * @return bool
     */
    public function validate()
    {
        return $this;

    }

    /**
     * @return bool
     */
    protected function shouldReturnRawResponse(): bool
    {
        return !is_null($this->app['request']->get('echostr'));
    }

    protected function isSafeMode(): bool
    {
        return true;
    }
}


1			<?php
2
3			/*
4			* This file is part of the overtrue/wechat.
5			*
6			* (c) overtrue <[email protected]>
7			*
8			* This source file is subject to the MIT license that is bundled
9			* with this source code in the file LICENSE.
10			*/
11
12			namespace EasyWeChat\OpenWork\Server;
13
14			use EasyWeChat\Kernel\ServerGuard;
15
16			/**
17			* Guard.
18			*
19			* @author xiaomin <[email protected]>
20			*/
21			class Guard extends ServerGuard
22			{
23			/**
24			* @var bool
25			*/
26			protected $alwaysValidate = true;
27
28			/**
29			* @return bool
30			*/
31			public function validate()
32			{
33			return $this;
			0 ignored issues – show Bug Best Practice introduced 2018-06-28 09:59 UTC by Report Bug Copy Issue Report The expression `return $this` returns the type `EasyWeChat\OpenWork\Server\Guard` which is incompatible with the documented return type `boolean`. Loading history...
34			}
35
36			/**
37			* @return bool
38			*/
39			protected function shouldReturnRawResponse(): bool
40			{
41			return !is_null($this->app['request']->get('echostr'));
42			}
43
44			protected function isSafeMode(): bool
45			{
46			return true;
47			}
48			}
49

overtrue / wechat

Pull Request — master (#1278)

Guard::shouldReturnRawResponse() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like