Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 30 | class Transformer |
||
| 31 | { |
||
| 32 | /** |
||
| 33 | * transform message to XML. |
||
| 34 | * |
||
| 35 | * @param array|string|AbstractMessage $message |
||
| 36 | * |
||
| 37 | * @return array |
||
| 38 | */ |
||
| 39 | 7 | View Code Duplication | public function transform($message) |
| 55 | |||
| 56 | /** |
||
| 57 | * Transform text message. |
||
| 58 | * |
||
| 59 | * @return array |
||
| 60 | */ |
||
| 61 | 2 | public function transformText(AbstractMessage $message) |
|
| 70 | |||
| 71 | /** |
||
| 72 | * Transform image message. |
||
| 73 | * |
||
| 74 | * @return array |
||
| 75 | */ |
||
| 76 | 1 | public function transformImage(AbstractMessage $message) |
|
| 85 | |||
| 86 | /** |
||
| 87 | * Transform video message. |
||
| 88 | * |
||
| 89 | * @return array |
||
| 90 | */ |
||
| 91 | 1 | public function transformVideo(AbstractMessage $message) |
|
| 103 | |||
| 104 | /** |
||
| 105 | * Transform voice message. |
||
| 106 | * |
||
| 107 | * @return array |
||
| 108 | */ |
||
| 109 | 1 | public function transformVoice(AbstractMessage $message) |
|
| 118 | |||
| 119 | /** |
||
| 120 | * Transform articles message. |
||
| 121 | * |
||
| 122 | * @return array |
||
| 123 | */ |
||
| 124 | 1 | View Code Duplication | public function transformNews($news) |
| 143 | |||
| 144 | /** |
||
| 145 | * Transform material message. |
||
| 146 | * |
||
| 147 | * @return array |
||
| 148 | */ |
||
| 149 | public function transformMaterial(AbstractMessage $message) |
||
| 160 | } |
||
| 161 |